From: Jakub Kicinski <kuba@kernel.org>
To: Marek Mietus <mmietus97@yahoo.com>
Cc: netdev@vger.kernel.org, antonio@openvpn.net,
openvpn-devel@lists.sourceforge.net
Subject: Re: [PATCH net-next 1/3] net: dst_cache: implement RCU variants for dst_cache helpers
Date: Thu, 11 Sep 2025 18:01:37 -0700 [thread overview]
Message-ID: <20250911180137.28b076a4@kernel.org> (raw)
In-Reply-To: <20250909054333.12572-2-mmietus97@yahoo.com>
On Tue, 9 Sep 2025 07:43:31 +0200 Marek Mietus wrote:
> +/**
> + * dst_cache_get_ip4_rcu - perform cache lookup and fetch ipv4 source
> + * address without taking a reference on the dst
This belongs in the body, summary can be just
lookup cache and ipv4 source under RCU
> + * @dst_cache: the cache
> + * @saddr: return value for the retrieved source address
> + *
> + * Must be called with local BH disabled, and within an rcu read side
> + * critical section
> + */
> +struct rtable *dst_cache_get_ip4_rcu(struct dst_cache *dst_cache, __be32 *saddr);
Return: values needs to be documented these days (kernel-doc -Wall ..).
While at it please remove the old school indent by a tab.
--
pw-bot: cr
next prev parent reply other threads:[~2025-09-12 1:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250909054333.12572-1-mmietus97.ref@yahoo.com>
2025-09-09 5:43 ` [PATCH net-next 0/3] net: tunnel: introduce noref xmit flows for tunnels Marek Mietus
2025-09-09 5:43 ` [PATCH net-next 1/3] net: dst_cache: implement RCU variants for dst_cache helpers Marek Mietus
2025-09-12 1:01 ` Jakub Kicinski [this message]
2025-09-09 5:43 ` [PATCH net-next 2/3] net: tunnel: implement noref flows in udp_tunnel_xmit_skb Marek Mietus
2025-09-09 5:43 ` [PATCH net-next 3/3] net: ovpn: use new noref xmit flow in ovpn_udp4_output Marek Mietus
2025-09-09 11:17 ` [PATCH net-next 0/3] net: tunnel: introduce noref xmit flows for tunnels Antonio Quartulli
2025-09-09 14:43 ` Marek Mietus
2025-09-16 10:43 ` Sabrina Dubroca
2025-09-18 16:31 ` Marek Mietus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250911180137.28b076a4@kernel.org \
--to=kuba@kernel.org \
--cc=antonio@openvpn.net \
--cc=mmietus97@yahoo.com \
--cc=netdev@vger.kernel.org \
--cc=openvpn-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.