From: Eric Biggers <ebiggers@kernel.org>
To: Guan-Chun Wu <409411716@gms.tku.edu.tw>
Cc: akpm@linux-foundation.org, axboe@kernel.dk,
ceph-devel@vger.kernel.org, hch@lst.de, home7438072@gmail.com,
idryomov@gmail.com, jaegeuk@kernel.org, kbusch@kernel.org,
linux-fscrypt@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-nvme@lists.infradead.org, sagi@grimberg.me, tytso@mit.edu,
visitorckw@gmail.com, xiubli@redhat.com
Subject: Re: [PATCH v2 4/5] fscrypt: replace local base64url helpers with generic lib/base64 helpers
Date: Thu, 11 Sep 2025 11:47:05 -0700 [thread overview]
Message-ID: <20250911184705.GD1376@sol> (raw)
In-Reply-To: <20250911074556.691401-1-409411716@gms.tku.edu.tw>
On Thu, Sep 11, 2025 at 03:45:56PM +0800, Guan-Chun Wu wrote:
> Replace the existing local base64url encoding and decoding functions in
> fscrypt with the generic base64_encode_custom and base64_decode_custom
> helpers from the kernel's lib/base64 library.
But those aren't the functions that are actually used.
> This removes custom implementations in fscrypt, reduces code duplication,
> and leverages the well-maintained,
Who is maintaining lib/base64.c? I guess Andrew?
> standard base64 code within the kernel.
fscrypt uses "base64url", not "base64".
> /* Encoded size of max-size no-key name */
> #define FSCRYPT_NOKEY_NAME_MAX_ENCODED \
> - FSCRYPT_BASE64URL_CHARS(FSCRYPT_NOKEY_NAME_MAX)
> + BASE64_CHARS(FSCRYPT_NOKEY_NAME_MAX)
Does BASE64_CHARS() include '=' padding or not?
- Eric
next prev parent reply other threads:[~2025-09-11 18:48 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-11 7:29 [PATCH v2 0/5] lib/base64: add generic encoder/decoder, migrate users Guan-Chun Wu
2025-09-11 7:32 ` [PATCH v2 1/5] lib/base64: Replace strchr() for better performance Guan-Chun Wu
2025-09-11 15:50 ` Caleb Sander Mateos
2025-09-11 16:02 ` Caleb Sander Mateos
2025-09-11 16:25 ` Kuan-Wei Chiu
2025-09-11 16:38 ` Kuan-Wei Chiu
2025-09-14 20:12 ` David Laight
2025-09-15 7:50 ` Kuan-Wei Chiu
2025-09-15 11:02 ` David Laight
2025-09-16 7:22 ` Kuan-Wei Chiu
2025-09-11 18:14 ` Eric Biggers
2025-09-11 18:44 ` Kuan-Wei Chiu
2025-09-11 18:49 ` Eric Biggers
2025-09-11 19:00 ` Kuan-Wei Chiu
2025-09-13 21:27 ` David Laight
2025-09-12 22:54 ` David Laight
2025-09-11 7:41 ` [PATCH v2 2/5] lib/base64: rework encoder/decoder with customizable support and update nvme-auth Guan-Chun Wu
2025-09-11 15:59 ` Caleb Sander Mateos
2025-09-12 7:21 ` Guan-Chun Wu
2025-09-11 18:27 ` Eric Biggers
2025-09-12 6:37 ` FIRST_NAME LAST_NAME
2025-09-12 6:52 ` Guan-Chun Wu
2025-09-12 7:15 ` Guan-Chun Wu
2025-09-11 7:45 ` [PATCH v2 3/5] lib: add KUnit tests for base64 encoding/decoding Guan-Chun Wu
2025-09-11 7:45 ` [PATCH v2 4/5] fscrypt: replace local base64url helpers with generic lib/base64 helpers Guan-Chun Wu
2025-09-11 18:47 ` Eric Biggers [this message]
2025-09-12 7:51 ` Guan-Chun Wu
2025-09-11 7:46 ` [PATCH v2 5/5] ceph: replace local base64 encode/decode " Guan-Chun Wu
-- strict thread matches above, loose matches on Subject: below --
2025-09-11 7:32 [PATCH v2 4/5] fscrypt: replace local base64url helpers " Guan-Chun Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250911184705.GD1376@sol \
--to=ebiggers@kernel.org \
--cc=409411716@gms.tku.edu.tw \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=ceph-devel@vger.kernel.org \
--cc=hch@lst.de \
--cc=home7438072@gmail.com \
--cc=idryomov@gmail.com \
--cc=jaegeuk@kernel.org \
--cc=kbusch@kernel.org \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=tytso@mit.edu \
--cc=visitorckw@gmail.com \
--cc=xiubli@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.