From: kernel test robot <lkp@intel.com>
To: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Cc: oe-kbuild-all@lists.linux.dev
Subject: Re: [PATCH v2 15/16] fs/proc: update vmcore to use .proc_mmap_prepare
Date: Fri, 12 Sep 2025 00:42:15 +0800 [thread overview]
Message-ID: <202509120057.bt4ckSKn-lkp@intel.com> (raw)
In-Reply-To: <163fba3d7ec775ec3eb9a13bd641d3255e8ec96c.1757534913.git.lorenzo.stoakes@oracle.com>
Hi Lorenzo,
kernel test robot noticed the following build warnings:
[auto build test WARNING on akpm-mm/mm-everything]
[cannot apply to brauner-vfs/vfs.all char-misc/char-misc-testing char-misc/char-misc-next char-misc/char-misc-linus s390/features lwn/docs-next linus/master v6.17-rc5 next-20250911]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Lorenzo-Stoakes/mm-shmem-update-shmem-to-use-mmap_prepare/20250911-042432
base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link: https://lore.kernel.org/r/163fba3d7ec775ec3eb9a13bd641d3255e8ec96c.1757534913.git.lorenzo.stoakes%40oracle.com
patch subject: [PATCH v2 15/16] fs/proc: update vmcore to use .proc_mmap_prepare
config: x86_64-buildonly-randconfig-001-20250911 (https://download.01.org/0day-ci/archive/20250912/202509120057.bt4ckSKn-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250912/202509120057.bt4ckSKn-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202509120057.bt4ckSKn-lkp@intel.com/
All warnings (new ones prefixed by >>):
fs/proc/vmcore.c: In function 'mmap_prepare_action_vmcore':
>> fs/proc/vmcore.c:595:20: warning: variable 'end' set but not used [-Wunused-but-set-variable]
595 | u64 start, end, len, tsz;
| ^~~
vim +/end +595 fs/proc/vmcore.c
0692dedcf64bf3 Vitaly Kuznetsov 2014-08-08 590
a8a91e1ced449b Lorenzo Stoakes 2025-09-10 591 static int mmap_prepare_action_vmcore(struct vm_area_struct *vma)
83086978c63afd HATAYAMA Daisuke 2013-07-03 592 {
a8a91e1ced449b Lorenzo Stoakes 2025-09-10 593 struct mmap_action action;
83086978c63afd HATAYAMA Daisuke 2013-07-03 594 size_t size = vma->vm_end - vma->vm_start;
83086978c63afd HATAYAMA Daisuke 2013-07-03 @595 u64 start, end, len, tsz;
819403c893551c David Hildenbrand 2024-12-04 596 struct vmcore_range *m;
83086978c63afd HATAYAMA Daisuke 2013-07-03 597
83086978c63afd HATAYAMA Daisuke 2013-07-03 598 start = (u64)vma->vm_pgoff << PAGE_SHIFT;
83086978c63afd HATAYAMA Daisuke 2013-07-03 599 end = start + size;
83086978c63afd HATAYAMA Daisuke 2013-07-03 600 len = 0;
83086978c63afd HATAYAMA Daisuke 2013-07-03 601
83086978c63afd HATAYAMA Daisuke 2013-07-03 602 if (start < elfcorebuf_sz) {
83086978c63afd HATAYAMA Daisuke 2013-07-03 603 u64 pfn;
83086978c63afd HATAYAMA Daisuke 2013-07-03 604
83086978c63afd HATAYAMA Daisuke 2013-07-03 605 tsz = min(elfcorebuf_sz - (size_t)start, size);
83086978c63afd HATAYAMA Daisuke 2013-07-03 606 pfn = __pa(elfcorebuf + start) >> PAGE_SHIFT;
a8a91e1ced449b Lorenzo Stoakes 2025-09-10 607
a8a91e1ced449b Lorenzo Stoakes 2025-09-10 608 mmap_action_remap(&action, vma->vm_start, pfn, tsz,
a8a91e1ced449b Lorenzo Stoakes 2025-09-10 609 vma->vm_page_prot);
a8a91e1ced449b Lorenzo Stoakes 2025-09-10 610 if (mmap_action_complete(&action, vma))
83086978c63afd HATAYAMA Daisuke 2013-07-03 611 return -EAGAIN;
83086978c63afd HATAYAMA Daisuke 2013-07-03 612 size -= tsz;
83086978c63afd HATAYAMA Daisuke 2013-07-03 613 start += tsz;
83086978c63afd HATAYAMA Daisuke 2013-07-03 614 len += tsz;
83086978c63afd HATAYAMA Daisuke 2013-07-03 615
83086978c63afd HATAYAMA Daisuke 2013-07-03 616 if (size == 0)
83086978c63afd HATAYAMA Daisuke 2013-07-03 617 return 0;
83086978c63afd HATAYAMA Daisuke 2013-07-03 618 }
83086978c63afd HATAYAMA Daisuke 2013-07-03 619
83086978c63afd HATAYAMA Daisuke 2013-07-03 620 if (start < elfcorebuf_sz + elfnotes_sz) {
83086978c63afd HATAYAMA Daisuke 2013-07-03 621 void *kaddr;
83086978c63afd HATAYAMA Daisuke 2013-07-03 622
7efe48df8a3df6 Rahul Lakkireddy 2018-05-02 623 /* We add device dumps before other elf notes because the
7efe48df8a3df6 Rahul Lakkireddy 2018-05-02 624 * other elf notes may not fill the elf notes buffer
7efe48df8a3df6 Rahul Lakkireddy 2018-05-02 625 * completely and we will end up with zero-filled data
7efe48df8a3df6 Rahul Lakkireddy 2018-05-02 626 * between the elf notes and the device dumps. Tools will
7efe48df8a3df6 Rahul Lakkireddy 2018-05-02 627 * then try to decode this zero-filled data as valid notes
7efe48df8a3df6 Rahul Lakkireddy 2018-05-02 628 * and we don't want that. Hence, adding device dumps before
7efe48df8a3df6 Rahul Lakkireddy 2018-05-02 629 * the other elf notes ensure that zero-filled data can be
7efe48df8a3df6 Rahul Lakkireddy 2018-05-02 630 * avoided. This also ensures that the device dumps and
7efe48df8a3df6 Rahul Lakkireddy 2018-05-02 631 * other elf notes can be properly mmaped at page aligned
7efe48df8a3df6 Rahul Lakkireddy 2018-05-02 632 * address.
7efe48df8a3df6 Rahul Lakkireddy 2018-05-02 633 */
7efe48df8a3df6 Rahul Lakkireddy 2018-05-02 634 #ifdef CONFIG_PROC_VMCORE_DEVICE_DUMP
7efe48df8a3df6 Rahul Lakkireddy 2018-05-02 635 /* Read device dumps */
7efe48df8a3df6 Rahul Lakkireddy 2018-05-02 636 if (start < elfcorebuf_sz + vmcoredd_orig_sz) {
7efe48df8a3df6 Rahul Lakkireddy 2018-05-02 637 u64 start_off;
7efe48df8a3df6 Rahul Lakkireddy 2018-05-02 638
7efe48df8a3df6 Rahul Lakkireddy 2018-05-02 639 tsz = min(elfcorebuf_sz + vmcoredd_orig_sz -
7efe48df8a3df6 Rahul Lakkireddy 2018-05-02 640 (size_t)start, size);
7efe48df8a3df6 Rahul Lakkireddy 2018-05-02 641 start_off = start - elfcorebuf_sz;
7efe48df8a3df6 Rahul Lakkireddy 2018-05-02 642 if (vmcoredd_mmap_dumps(vma, vma->vm_start + len,
7efe48df8a3df6 Rahul Lakkireddy 2018-05-02 643 start_off, tsz))
7efe48df8a3df6 Rahul Lakkireddy 2018-05-02 644 goto fail;
7efe48df8a3df6 Rahul Lakkireddy 2018-05-02 645
7efe48df8a3df6 Rahul Lakkireddy 2018-05-02 646 size -= tsz;
7efe48df8a3df6 Rahul Lakkireddy 2018-05-02 647 start += tsz;
7efe48df8a3df6 Rahul Lakkireddy 2018-05-02 648 len += tsz;
7efe48df8a3df6 Rahul Lakkireddy 2018-05-02 649
7efe48df8a3df6 Rahul Lakkireddy 2018-05-02 650 /* leave now if filled buffer already */
7efe48df8a3df6 Rahul Lakkireddy 2018-05-02 651 if (!size)
7efe48df8a3df6 Rahul Lakkireddy 2018-05-02 652 return 0;
7efe48df8a3df6 Rahul Lakkireddy 2018-05-02 653 }
7efe48df8a3df6 Rahul Lakkireddy 2018-05-02 654 #endif /* CONFIG_PROC_VMCORE_DEVICE_DUMP */
7efe48df8a3df6 Rahul Lakkireddy 2018-05-02 655
7efe48df8a3df6 Rahul Lakkireddy 2018-05-02 656 /* Read remaining elf notes */
83086978c63afd HATAYAMA Daisuke 2013-07-03 657 tsz = min(elfcorebuf_sz + elfnotes_sz - (size_t)start, size);
7efe48df8a3df6 Rahul Lakkireddy 2018-05-02 658 kaddr = elfnotes_buf + start - elfcorebuf_sz - vmcoredd_orig_sz;
83086978c63afd HATAYAMA Daisuke 2013-07-03 659 if (remap_vmalloc_range_partial(vma, vma->vm_start + len,
a8a91e1ced449b Lorenzo Stoakes 2025-09-10 660 kaddr, 0, tsz, /* set_vma =*/false))
83086978c63afd HATAYAMA Daisuke 2013-07-03 661 goto fail;
7efe48df8a3df6 Rahul Lakkireddy 2018-05-02 662
83086978c63afd HATAYAMA Daisuke 2013-07-03 663 size -= tsz;
83086978c63afd HATAYAMA Daisuke 2013-07-03 664 start += tsz;
83086978c63afd HATAYAMA Daisuke 2013-07-03 665 len += tsz;
83086978c63afd HATAYAMA Daisuke 2013-07-03 666
83086978c63afd HATAYAMA Daisuke 2013-07-03 667 if (size == 0)
83086978c63afd HATAYAMA Daisuke 2013-07-03 668 return 0;
83086978c63afd HATAYAMA Daisuke 2013-07-03 669 }
83086978c63afd HATAYAMA Daisuke 2013-07-03 670
83086978c63afd HATAYAMA Daisuke 2013-07-03 671 list_for_each_entry(m, &vmcore_list, list) {
83086978c63afd HATAYAMA Daisuke 2013-07-03 672 if (start < m->offset + m->size) {
83086978c63afd HATAYAMA Daisuke 2013-07-03 673 u64 paddr = 0;
83086978c63afd HATAYAMA Daisuke 2013-07-03 674
0b50a2d86d8e9a Dave Young 2016-03-17 675 tsz = (size_t)min_t(unsigned long long,
0b50a2d86d8e9a Dave Young 2016-03-17 676 m->offset + m->size - start, size);
83086978c63afd HATAYAMA Daisuke 2013-07-03 677 paddr = m->paddr + start - m->offset;
0692dedcf64bf3 Vitaly Kuznetsov 2014-08-08 678 if (vmcore_remap_oldmem_pfn(vma, vma->vm_start + len,
83086978c63afd HATAYAMA Daisuke 2013-07-03 679 paddr >> PAGE_SHIFT, tsz,
83086978c63afd HATAYAMA Daisuke 2013-07-03 680 vma->vm_page_prot))
83086978c63afd HATAYAMA Daisuke 2013-07-03 681 goto fail;
83086978c63afd HATAYAMA Daisuke 2013-07-03 682 size -= tsz;
83086978c63afd HATAYAMA Daisuke 2013-07-03 683 start += tsz;
83086978c63afd HATAYAMA Daisuke 2013-07-03 684 len += tsz;
83086978c63afd HATAYAMA Daisuke 2013-07-03 685
83086978c63afd HATAYAMA Daisuke 2013-07-03 686 if (size == 0)
83086978c63afd HATAYAMA Daisuke 2013-07-03 687 return 0;
83086978c63afd HATAYAMA Daisuke 2013-07-03 688 }
83086978c63afd HATAYAMA Daisuke 2013-07-03 689 }
83086978c63afd HATAYAMA Daisuke 2013-07-03 690
83086978c63afd HATAYAMA Daisuke 2013-07-03 691 return 0;
83086978c63afd HATAYAMA Daisuke 2013-07-03 692 fail:
897ab3e0c49e24 Mike Rapoport 2017-02-24 693 do_munmap(vma->vm_mm, vma->vm_start, len, NULL);
83086978c63afd HATAYAMA Daisuke 2013-07-03 694 return -EAGAIN;
83086978c63afd HATAYAMA Daisuke 2013-07-03 695 }
a8a91e1ced449b Lorenzo Stoakes 2025-09-10 696
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2025-09-11 16:43 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-10 20:21 [PATCH v2 00/16] expand mmap_prepare functionality, port more users Lorenzo Stoakes
2025-09-10 20:21 ` [PATCH v2 01/16] mm/shmem: update shmem to use mmap_prepare Lorenzo Stoakes
2025-09-11 8:32 ` Jan Kara
2025-09-10 20:21 ` [PATCH v2 02/16] device/dax: update devdax " Lorenzo Stoakes
2025-09-11 8:35 ` Jan Kara
2025-09-10 20:21 ` [PATCH v2 03/16] mm: add vma_desc_size(), vma_desc_pages() helpers Lorenzo Stoakes
2025-09-11 8:36 ` Jan Kara
2025-09-12 17:56 ` David Hildenbrand
2025-09-15 10:12 ` Lorenzo Stoakes
2025-09-10 20:21 ` [PATCH v2 04/16] relay: update relay to use mmap_prepare Lorenzo Stoakes
2025-09-11 8:38 ` Jan Kara
2025-09-10 20:22 ` [PATCH v2 05/16] mm/vma: rename __mmap_prepare() function to avoid confusion Lorenzo Stoakes
2025-09-12 17:57 ` David Hildenbrand
2025-09-15 10:12 ` Lorenzo Stoakes
2025-09-10 20:22 ` [PATCH v2 06/16] mm: add remap_pfn_range_prepare(), remap_pfn_range_complete() Lorenzo Stoakes
2025-09-10 20:22 ` [PATCH v2 07/16] mm: introduce io_remap_pfn_range_[prepare, complete]() Lorenzo Stoakes
2025-09-12 10:23 ` Lorenzo Stoakes
2025-09-10 20:22 ` [PATCH v2 08/16] mm: add ability to take further action in vm_area_desc Lorenzo Stoakes
2025-09-11 22:07 ` Reinette Chatre
2025-09-12 10:18 ` Lorenzo Stoakes
2025-09-12 10:25 ` Lorenzo Stoakes
2025-09-13 22:54 ` Chris Mason
2025-09-15 9:56 ` Lorenzo Stoakes
2025-09-15 10:09 ` Lorenzo Stoakes
2025-09-15 12:11 ` Jason Gunthorpe
2025-09-15 12:23 ` Lorenzo Stoakes
2025-09-15 12:42 ` Jason Gunthorpe
2025-09-15 12:54 ` Lorenzo Stoakes
2025-09-15 13:11 ` Jason Gunthorpe
2025-09-15 13:51 ` Lorenzo Stoakes
2025-09-15 14:34 ` Jason Gunthorpe
2025-09-15 15:04 ` Lorenzo Stoakes
2025-09-10 20:22 ` [PATCH v2 09/16] doc: update porting, vfs documentation for mmap_prepare actions Lorenzo Stoakes
2025-09-11 8:55 ` Jan Kara
2025-09-12 10:19 ` Lorenzo Stoakes
2025-09-10 20:22 ` [PATCH v2 10/16] mm/hugetlbfs: update hugetlbfs to use mmap_prepare Lorenzo Stoakes
2025-09-10 20:22 ` [PATCH v2 11/16] mm: update mem char driver " Lorenzo Stoakes
2025-09-18 19:11 ` Chris Mason
2025-09-19 5:13 ` Lorenzo Stoakes
2025-09-10 20:22 ` [PATCH v2 12/16] mm: update resctl " Lorenzo Stoakes
2025-09-11 22:07 ` Reinette Chatre
2025-09-12 10:14 ` Lorenzo Stoakes
2025-09-10 20:22 ` [PATCH v2 13/16] mm: update cramfs " Lorenzo Stoakes
2025-09-10 20:22 ` [PATCH v2 14/16] fs/proc: add the proc_mmap_prepare hook for procfs Lorenzo Stoakes
2025-09-10 20:22 ` [PATCH v2 15/16] fs/proc: update vmcore to use .proc_mmap_prepare Lorenzo Stoakes
2025-09-11 16:42 ` kernel test robot [this message]
2025-09-12 10:09 ` Lorenzo Stoakes
2025-09-12 10:14 ` Lorenzo Stoakes
2025-09-10 20:22 ` [PATCH v2 16/16] kcov: update kcov to use mmap_prepare Lorenzo Stoakes
2025-09-15 12:16 ` Jason Gunthorpe
2025-09-15 12:43 ` Lorenzo Stoakes
2025-09-15 12:48 ` Jason Gunthorpe
2025-09-15 13:01 ` Lorenzo Stoakes
2025-09-18 19:45 ` Chris Mason
2025-09-19 5:10 ` Lorenzo Stoakes
2025-09-10 21:38 ` [PATCH v2 00/16] expand mmap_prepare functionality, port more users Andrew Morton
2025-09-11 5:19 ` Lorenzo Stoakes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202509120057.bt4ckSKn-lkp@intel.com \
--to=lkp@intel.com \
--cc=lorenzo.stoakes@oracle.com \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.