From: SeongJae Park <sj@kernel.org>
Cc: SeongJae Park <sj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
damon@lists.linux.dev, kernel-team@meta.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: [RFC PATCH 6/7] samples/damon/prcl: use damon_initialized()
Date: Thu, 11 Sep 2025 19:39:45 -0700 [thread overview]
Message-ID: <20250912023946.62337-7-sj@kernel.org> (raw)
In-Reply-To: <20250912023946.62337-1-sj@kernel.org>
damon_sample_prcl is assuming DAMON is ready to use in module_init time,
and uses its own hack to see if it is the time. Use
damon_initialized(), which is a way for seeing if DAMON is ready to be
used that is more reliable and better to maintain instead of the hack.
Signed-off-by: SeongJae Park <sj@kernel.org>
---
samples/damon/prcl.c | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/samples/damon/prcl.c b/samples/damon/prcl.c
index 0226652f94d5..b7c50f2656ce 100644
--- a/samples/damon/prcl.c
+++ b/samples/damon/prcl.c
@@ -122,8 +122,6 @@ static void damon_sample_prcl_stop(void)
}
}
-static bool init_called;
-
static int damon_sample_prcl_enable_store(
const char *val, const struct kernel_param *kp)
{
@@ -137,7 +135,7 @@ static int damon_sample_prcl_enable_store(
if (enabled == is_enabled)
return 0;
- if (!init_called)
+ if (!damon_initialized())
return 0;
if (enabled) {
@@ -154,7 +152,12 @@ static int __init damon_sample_prcl_init(void)
{
int err = 0;
- init_called = true;
+ if (!damon_initialized()) {
+ if (enabled)
+ enabled = false;
+ return -ENOMEM;
+ }
+
if (enabled) {
err = damon_sample_prcl_start();
if (err)
--
2.39.5
next prev parent reply other threads:[~2025-09-12 2:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-12 2:39 [RFC PATCH 0/7] mm/damon: define and use DAMON initialization check function SeongJae Park
2025-09-12 2:39 ` [RFC PATCH 1/7] mm/damon/core: implement damon_initialized() function SeongJae Park
2025-09-12 2:39 ` [RFC PATCH 2/7] mm/damon/stat: use damon_initialized() SeongJae Park
2025-09-12 2:39 ` [RFC PATCH 3/7] mm/damon/reclaim: " SeongJae Park
2025-09-12 2:39 ` [RFC PATCH 4/7] mm/damon/lru_sort: " SeongJae Park
2025-09-12 2:39 ` [RFC PATCH 5/7] samples/damon/wsse: " SeongJae Park
2025-09-12 2:39 ` SeongJae Park [this message]
2025-09-12 2:39 ` [RFC PATCH 7/7] samples/damon/mtier: " SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250912023946.62337-7-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.