All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Akiyoshi Kurita <weibu@redadmin.org>
Cc: Philipp Hortmann <philipp.g.hortmann@gmail.com>,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: fix coding style in hal_com_phycfg.c
Date: Fri, 12 Sep 2025 15:45:58 +0200	[thread overview]
Message-ID: <2025091233-showman-dill-3d17@gregkh> (raw)
In-Reply-To: <20250908144641.39518-1-weibu@redadmin.org>

On Mon, Sep 08, 2025 at 11:46:41PM +0900, Akiyoshi Kurita wrote:
> The function definition for phy_StoreTxPowerByRateBase() did not
> follow the kernel coding style.
> 
> Move the closing parenthesis to the same line as the argument to fix
> the style issue reported by checkpatch.pl.
> 
> Signed-off-by: Akiyoshi Kurita <weibu@redadmin.org>
> ---
>  drivers/staging/rtl8723bs/hal/hal_com_phycfg.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c b/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c
> index d5649e7d8f99..f137ec747ab3 100644
> --- a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c
> +++ b/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c
> @@ -60,9 +60,7 @@ phy_SetTxPowerByRateBase(struct adapter *Adapter, u8 RfPath,
>  }
>  
>  static void
> -phy_StoreTxPowerByRateBase(
> -struct adapter *padapter
> -	)
> +phy_StoreTxPowerByRateBase(struct adapter *padapter)

This really should end up being:

static void phy_StoreTxPowerByRateBase(struct adapter *padapter)

right?

thanks,

greg k-h

  parent reply	other threads:[~2025-09-12 13:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-08 14:46 [PATCH] staging: rtl8723bs: fix coding style in hal_com_phycfg.c Akiyoshi Kurita
2025-09-08 15:24 ` Dan Carpenter
2025-09-12 13:45 ` Greg Kroah-Hartman [this message]
2025-09-12 16:26   ` [PATCH v2] staging: rtl8723bs: hal: put return type and function name on one line Akiyoshi Kurita

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2025091233-showman-dill-3d17@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=philipp.g.hortmann@gmail.com \
    --cc=weibu@redadmin.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.