Re: [PATCH v2] staging: rtl8723bs: fix function definition style in hal_com_phycfg.c

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Tue, Sep 09, 2025 at 02:29:25AM +0900, Akiyoshi Kurita wrote:
> Several function definitions in this file did not follow the kernel
> coding style, spreading arguments across multiple lines.
> 
> As requested by Dan Carpenter, fix all instances to place the function
> parameters and the closing parenthesis on the same line as the function
> name, improving readability and conforming to style guidelines.
> 
> Signed-off-by: Akiyoshi Kurita <weibu@redadmin.org>
> ---
>  .../staging/rtl8723bs/hal/hal_com_phycfg.c    | 33 ++++---------------
>  1 file changed, 6 insertions(+), 27 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c b/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c
> index 75ed731bbb14..fa987a797b16 100644
> --- a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c
> +++ b/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c
> @@ -61,8 +61,6 @@ phy_SetTxPowerByRateBase(struct adapter *Adapter, u8 RfPath,
>  
>  static void
>  phy_StoreTxPowerByRateBase(struct adapter *padapter)
> -{
> -	u8 path, base;
>  
>  	for (path = RF_PATH_A; path <= RF_PATH_B; ++path) {
>  		base = PHY_GetTxPowerByRate(padapter, path, MGN_11M);

This patch doesn't apply, nor does it even look like it can build?  Did
you test-build the result?

thanks,

greg k-h