From: Jakub Kicinski <kuba@kernel.org>
To: "Asbjørn Sloth Tønnesen" <ast@fiberby.net>
Cc: "Jason A. Donenfeld" <Jason@zx2c4.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Donald Hunter <donald.hunter@gmail.com>,
Simon Horman <horms@kernel.org>,
Jacob Keller <jacob.e.keller@intel.com>,
Sabrina Dubroca <sd@queasysnail.net>,
wireguard@lists.zx2c4.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v4 04/11] tools: ynl-gen: refactor local vars for .attr_put() callers
Date: Sun, 14 Sep 2025 11:08:04 -0700 [thread overview]
Message-ID: <20250914110804.3549eb9d@kernel.org> (raw)
In-Reply-To: <20250913235847.358851-5-ast@fiberby.net>
On Sat, 13 Sep 2025 23:58:25 +0000 Asbjørn Sloth Tønnesen wrote:
> Refactor the generation of local variables needed when building
> requests, by moving the logic into the Type classes, and use the
> same helper in all places where .attr_put() is called.
>
> If any attributes requests identical local_vars, then they will
> be deduplicated, attributes are assumed to only use their local
> variables transiently.
Nope, this is not good enough. I prefer the obvious hack than a one-off
member mixed into the object model.
next prev parent reply other threads:[~2025-09-14 18:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-13 23:58 [PATCH net-next v4 00/11] tools: ynl: prepare for wireguard Asbjørn Sloth Tønnesen
2025-09-13 23:58 ` [PATCH net-next v4 01/11] tools: ynl-gen: allow overriding name-prefix for constants Asbjørn Sloth Tønnesen
2025-09-13 23:58 ` [PATCH net-next v4 02/11] tools: ynl-gen: generate nested array policies Asbjørn Sloth Tønnesen
2025-09-13 23:58 ` [PATCH net-next v4 03/11] tools: ynl-gen: add sub-type check Asbjørn Sloth Tønnesen
2025-09-13 23:58 ` [PATCH net-next v4 04/11] tools: ynl-gen: refactor local vars for .attr_put() callers Asbjørn Sloth Tønnesen
2025-09-14 18:08 ` Jakub Kicinski [this message]
2025-09-13 23:58 ` [PATCH net-next v4 05/11] tools: ynl-gen: avoid repetitive variables definitions Asbjørn Sloth Tønnesen
2025-09-13 23:58 ` [PATCH net-next v4 06/11] tools: ynl-gen: validate nested arrays Asbjørn Sloth Tønnesen
2025-09-13 23:58 ` [PATCH net-next v4 07/11] tools: ynl-gen: rename TypeArrayNest to TypeIndexedArray Asbjørn Sloth Tønnesen
2025-09-13 23:58 ` [PATCH net-next v4 08/11] tools: ynl: move nest packing to a helper function Asbjørn Sloth Tønnesen
2025-09-13 23:58 ` [PATCH net-next v4 09/11] tools: ynl: encode indexed-arrays Asbjørn Sloth Tønnesen
2025-09-13 23:58 ` [PATCH net-next v4 10/11] tools: ynl: decode hex input Asbjørn Sloth Tønnesen
2025-09-13 23:58 ` [PATCH net-next v4 11/11] tools: ynl: add ipv4-or-v6 display hint Asbjørn Sloth Tønnesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250914110804.3549eb9d@kernel.org \
--to=kuba@kernel.org \
--cc=Jason@zx2c4.com \
--cc=ast@fiberby.net \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sd@queasysnail.net \
--cc=wireguard@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.