From: Simon Horman <horms@kernel.org>
To: Jakub Sitnicki <jakub@cloudflare.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Kuniyuki Iwashima <kuniyu@google.com>,
Neal Cardwell <ncardwell@google.com>,
Paolo Abeni <pabeni@redhat.com>,
kernel-team@cloudflare.com,
Lee Valentine <lvalentine@cloudflare.com>
Subject: Re: [PATCH net-next v3 1/2] tcp: Update bind bucket state on port release
Date: Mon, 15 Sep 2025 11:39:04 +0100 [thread overview]
Message-ID: <20250915103904.GQ224143@horms.kernel.org> (raw)
In-Reply-To: <87a52y67we.fsf@cloudflare.com>
On Sat, Sep 13, 2025 at 11:04:01AM +0200, Jakub Sitnicki wrote:
> On Thu, Sep 11, 2025 at 06:06 PM -07, Jakub Kicinski wrote:
> > On Wed, 10 Sep 2025 15:08:31 +0200 Jakub Sitnicki wrote:
> >> +/**
> >> + * sk_is_connect_bind - Check if socket was auto-bound at connect() time.
> >> + * @sk: &struct inet_connection_sock or &struct inet_timewait_sock
> >> + */
> >
> > You need to document Return: value in the kdoc, annoyingly.
> > Unfortunately kdoc warnings gate running CI in netdev 'cause they
> > sometimes result in a lot of htmldocs noise :\
>
> Ah, thanks for the hint. 'scripts/kernel-doc -v -none' didn't complain
> about it.
FWIIW, I think -Wall would cause kernel-doc to complain about this.
>
> I think I will drop the doc comment altogether since it's just a private
> helper now and the flag it checks is properly documented.
>
next prev parent reply other threads:[~2025-09-15 10:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-10 13:08 [PATCH net-next v3 0/2] tcp: Update bind bucket state on port release Jakub Sitnicki
2025-09-10 13:08 ` [PATCH net-next v3 1/2] " Jakub Sitnicki
2025-09-12 1:06 ` Jakub Kicinski
2025-09-13 9:04 ` Jakub Sitnicki
2025-09-15 10:39 ` Simon Horman [this message]
2025-09-10 13:08 ` [PATCH net-next v3 2/2] selftests/net: Test tcp port reuse after unbinding a socket Jakub Sitnicki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250915103904.GQ224143@horms.kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jakub@cloudflare.com \
--cc=kernel-team@cloudflare.com \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=lvalentine@cloudflare.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.