From: Stefan Hajnoczi <stefanha@redhat.com>
To: Alok Tiwari <alok.a.tiwari@oracle.com>
Cc: michael.christie@oracle.com, pbonzini@redhat.com,
eperezma@redhat.com, mst@redhat.com, jasowang@redhat.com,
virtualization@lists.linux.dev, kvm@vger.kernel.org
Subject: Re: [PATCH] vhost-scsi: fix argument order in tport allocation error message
Date: Mon, 15 Sep 2025 10:46:11 -0400 [thread overview]
Message-ID: <20250915144611.GD69944@fedora> (raw)
In-Reply-To: <20250913154106.3995856-1-alok.a.tiwari@oracle.com>
[-- Attachment #1: Type: text/plain, Size: 799 bytes --]
On Sat, Sep 13, 2025 at 08:40:53AM -0700, Alok Tiwari wrote:
> The error log in vhost_scsi_make_tport() prints the arguments in the
> wrong order, producing confusing output. For example, when creating a
> target with a name in WWNN format such as "fc.port1234", the log
> looks like:
>
> Emulated fc.port1234 Address: FCP, exceeds max: 64
>
> Instead, the message should report the emulated protocol type first,
> followed by the configfs name as:
>
> Emulated FCP Address: fc.port1234, exceeds max: 64
>
> Fix the argument order so the error log is consistent and clear.
>
> Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
> ---
> drivers/vhost/scsi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2025-09-15 14:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-13 15:40 [PATCH] vhost-scsi: fix argument order in tport allocation error message Alok Tiwari
2025-09-15 14:46 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250915144611.GD69944@fedora \
--to=stefanha@redhat.com \
--cc=alok.a.tiwari@oracle.com \
--cc=eperezma@redhat.com \
--cc=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=michael.christie@oracle.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.