From: Jakub Kicinski <kuba@kernel.org>
To: "Asbjørn Sloth Tønnesen" <ast@fiberby.net>
Cc: "Jason A. Donenfeld" <Jason@zx2c4.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Donald Hunter <donald.hunter@gmail.com>,
Simon Horman <horms@kernel.org>,
Jacob Keller <jacob.e.keller@intel.com>,
Sabrina Dubroca <sd@queasysnail.net>,
wireguard@lists.zx2c4.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v5 04/11] tools: ynl-gen: refactor local vars for .attr_put() callers
Date: Mon, 15 Sep 2025 18:42:12 -0700 [thread overview]
Message-ID: <20250915184212.1dc0abf2@kernel.org> (raw)
In-Reply-To: <20250915144301.725949-5-ast@fiberby.net>
On Mon, 15 Sep 2025 14:42:49 +0000 Asbjørn Sloth Tønnesen wrote:
> Refactor the generation of local variables needed when building
> requests, by moving the logic from put_req_nested() into a new
> helper put_local_vars(), and use the helper before .attr_put() is
> called, thus generating the local variables assumed by .attr_put().
>
> Previously only put_req_nested() generated the variables assumed
> by .attr_put(), print_req() only generated the count iterator `i`,
> and print_dump() neither generated `i` nor `array`.
Reviewed-by: Jakub Kicinski <kuba@kernel.org>
next prev parent reply other threads:[~2025-09-16 1:42 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-15 14:42 [PATCH net-next v5 00/11] tools: ynl: prepare for wireguard Asbjørn Sloth Tønnesen
2025-09-15 14:42 ` [PATCH net-next v5 01/11] tools: ynl-gen: allow overriding name-prefix for constants Asbjørn Sloth Tønnesen
2025-09-15 14:42 ` [PATCH net-next v5 02/11] tools: ynl-gen: generate nested array policies Asbjørn Sloth Tønnesen
2025-09-15 14:42 ` [PATCH net-next v5 03/11] tools: ynl-gen: add sub-type check Asbjørn Sloth Tønnesen
2025-09-15 14:42 ` [PATCH net-next v5 04/11] tools: ynl-gen: refactor local vars for .attr_put() callers Asbjørn Sloth Tønnesen
2025-09-16 1:42 ` Jakub Kicinski [this message]
2025-09-15 14:42 ` [PATCH net-next v5 05/11] tools: ynl-gen: avoid repetitive variables definitions Asbjørn Sloth Tønnesen
2025-09-16 1:42 ` Jakub Kicinski
2025-09-15 14:42 ` [PATCH net-next v5 06/11] tools: ynl-gen: validate nested arrays Asbjørn Sloth Tønnesen
2025-09-16 1:42 ` Jakub Kicinski
2025-09-15 14:42 ` [PATCH net-next v5 07/11] tools: ynl-gen: rename TypeArrayNest to TypeIndexedArray Asbjørn Sloth Tønnesen
2025-09-16 1:43 ` Jakub Kicinski
2025-09-15 14:42 ` [PATCH net-next v5 08/11] tools: ynl: move nest packing to a helper function Asbjørn Sloth Tønnesen
2025-09-15 14:42 ` [PATCH net-next v5 09/11] tools: ynl: encode indexed-arrays Asbjørn Sloth Tønnesen
2025-09-15 14:42 ` [PATCH net-next v5 10/11] tools: ynl: decode hex input Asbjørn Sloth Tønnesen
2025-09-15 14:42 ` [PATCH net-next v5 11/11] tools: ynl: add ipv4-or-v6 display hint Asbjørn Sloth Tønnesen
2025-09-16 15:38 ` [PATCH net-next v5 00/11] tools: ynl: prepare for wireguard patchwork-bot+netdevbpf
2025-09-16 15:53 ` Jason A. Donenfeld
2025-09-16 22:39 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250915184212.1dc0abf2@kernel.org \
--to=kuba@kernel.org \
--cc=Jason@zx2c4.com \
--cc=ast@fiberby.net \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sd@queasysnail.net \
--cc=wireguard@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.