Re: [PATCH mlx5-next 2/3] net/mlx5: Refactor MACsec WQE metadata shifts

[Simon Horman <horms@kernel.org>]

On Mon, Sep 15, 2025 at 09:23:04AM +0300, Carolina Jubran wrote:
> 
> On 12/09/2025 18:49, Simon Horman wrote:
> > On Thu, Sep 11, 2025 at 10:10:18AM +0300, Tariq Toukan wrote:
> > > From: Carolina Jubran <cjubran@nvidia.com>

...

> Hi Simon,
> 
> Thanks for the suggestion!
> 
> The goal with this patch was to clearly show which bits are used for
> each feature in the metadata field, rather than compressing everything
> under a single mask. That’s why we chose to explicitly define MACsec,
> FS_ID_MASK, and the shift separately. This way, its easy to see at a
> glance that MACsec uses bit 1, and bits 2–5 are reserved for the fs_id.
> 
> Using FIELD_PREP can work, but it hides the bit layout behind one
> mask, which makes it harder to reason about when multiple features
> share the same 32-bit field. We wanted to keep things more readable
> and maintainable by showing the bit assignments explicitly.
> 
> Carolina

Hi Carolina.

Thanks for your response.
If this is a deliberate choice then I'm happy with the current approach.

Reviewed-by: Simon Horman <horms@kernel.org>