From: Tom Rini <trini@konsulko.com>
To: Anshul Dalal <anshuld@ti.com>
Cc: u-boot@lists.denx.de, vigneshr@ti.com, afd@ti.com,
m-chawdhry@ti.com, n-francis@ti.com, b-liu@ti.com, nm@ti.com,
bb@ti.com, kever.yang@rock-chips.com, hl@rock-chips.com,
tim@feathertop.org, marek.vasut+renesas@mailbox.org
Subject: Re: [PATCH v1 3/8] spl: mmc: split spl_mmc_do_fs_boot into regular/os_boot
Date: Tue, 16 Sep 2025 12:32:53 -0600 [thread overview]
Message-ID: <20250916183253.GC124814@bill-the-cat> (raw)
In-Reply-To: <20250916105857.163951-4-anshuld@ti.com>
[-- Attachment #1: Type: text/plain, Size: 678 bytes --]
On Tue, Sep 16, 2025 at 04:28:51PM +0530, Anshul Dalal wrote:
> Currently the logic to handle falcon mode as well as the regular boot is
> inside spl_mmc_do_fs_boot, this prevents us from cleanly extending
> falcon mode functionality like toggleable fallback to U-Boot proper.
>
> Therefore this patch splits the logic into spl_mmc_fs_load and
> spl_mmc_fs_load_os to handle the regular boot and falcon mode use case.
>
> Signed-off-by: Anshul Dalal <anshuld@ti.com>
[snip]
> + printf("%s, Failed to load falcon payload: %d\n", __func__,
> + ret);
> + printf("Fallback to U-Boot\n");
These are new. Do we really need to be adding them?
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2025-09-16 18:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-16 10:58 [PATCH v1 0/8] Add support for secure falcon mode: disable fallback Anshul Dalal
2025-09-16 10:58 ` [PATCH v1 1/8] spl: Kconfig: add SPL_OS_BOOT_SECURE config symbol Anshul Dalal
2025-09-16 10:58 ` [PATCH v1 2/8] spl: Kconfig: allow K3 devices to use falcon mode Anshul Dalal
2025-09-16 10:58 ` [PATCH v1 3/8] spl: mmc: split spl_mmc_do_fs_boot into regular/os_boot Anshul Dalal
2025-09-16 18:32 ` Tom Rini [this message]
2025-09-17 13:31 ` Anshul Dalal
2025-09-16 10:58 ` [PATCH v1 4/8] spl: ubi: refactor spl_ubi_load_image for falcon mode Anshul Dalal
2025-09-16 18:34 ` Tom Rini
2025-09-17 13:33 ` Anshul Dalal
2025-09-16 10:58 ` [PATCH v1 5/8] spl: spi: refactor spl_spi_load_image " Anshul Dalal
2025-09-16 10:58 ` [PATCH v1 6/8] spl: nor: refactor spl_nor_load_image " Anshul Dalal
2025-09-16 10:58 ` [PATCH v1 7/8] spl: nand: refactor spl_nand_load_image " Anshul Dalal
2025-09-16 10:58 ` [PATCH v1 8/8] spl: falcon: disable fallback to U-Boot on failure Anshul Dalal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250916183253.GC124814@bill-the-cat \
--to=trini@konsulko.com \
--cc=afd@ti.com \
--cc=anshuld@ti.com \
--cc=b-liu@ti.com \
--cc=bb@ti.com \
--cc=hl@rock-chips.com \
--cc=kever.yang@rock-chips.com \
--cc=m-chawdhry@ti.com \
--cc=marek.vasut+renesas@mailbox.org \
--cc=n-francis@ti.com \
--cc=nm@ti.com \
--cc=tim@feathertop.org \
--cc=u-boot@lists.denx.de \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.