Re: [PATCH net-next v4 1/2] net: libwx: support multiple RSS for every pool

[Jakub Kicinski <kuba@kernel.org>]

On Wed, 17 Sep 2025 09:51:44 +0800 Jiawen Wu wrote:
> On Tue, Sep 16, 2025 9:02 AM, Jakub Kicinski wrote:
> > On Fri, 12 Sep 2025 14:23:56 +0800 Jiawen Wu wrote:  
> > > Subject: [PATCH net-next v4 1/2] net: libwx: support multiple RSS for every pool  
> > 
> > "support multiple RSS" needs an object. Multiple RSS keys? Multiple
> > contexts? Multiple tables?  
> 
> All of these are multiple. Each pool has a different RSS scheme.

Then configuration? 
As in "support separate RSS configuration for every pool" ?

> > > -static void wx_store_reta(struct wx *wx)
> > > +u32 wx_rss_indir_tbl_entries(struct wx *wx)
> > >  {
> > > +	if (test_bit(WX_FLAG_SRIOV_ENABLED, wx->flags))
> > > +		return 64;
> > > +	else
> > > +		return 128;
> > > +}  
> > 
> > Is WX_FLAG_SRIOV_ENABLED set only when VFs are created?  
> 
> Yes.
> 
> > What if the user set a table with 128 entries?
> > The RSS table can't shrink once intentionally set to a specific size.  
> 
> Deleting VFs will reset these configurations.

You shouldn't reset user-set configuration of the PF when SR-IOV 
is disabled.