From: kernel test robot <lkp@intel.com>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: oe-kbuild-all@lists.linux.dev, Donald Dutile <ddutile@redhat.com>
Subject: [jgunthorpe:pcie_switch_groups 6/13] include/linux/pci.h:866:9: warning: "/*" within comment
Date: Tue, 16 Sep 2025 19:27:09 +0800 [thread overview]
Message-ID: <202509161957.c3t4ec9Q-lkp@intel.com> (raw)
tree: https://github.com/jgunthorpe/linux pcie_switch_groups
head: 359e58e015929f167700789bde9365e492d57b00
commit: 688297d25e0f7174014a30f873b36632eae65c38 [6/13] PCI: Add pci_reachable_bus_set()
config: i386-buildonly-randconfig-004-20250916 (https://download.01.org/0day-ci/archive/20250916/202509161957.c3t4ec9Q-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250916/202509161957.c3t4ec9Q-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202509161957.c3t4ec9Q-lkp@intel.com/
All warnings (new ones prefixed by >>):
In file included from include/linux/pci-p2pdma.h:14,
from kernel/dma/direct.c:16:
>> include/linux/pci.h:866:9: warning: "/*" within comment [-Wcomment]
866 | /*
>> include/linux/pci.h:871:9: warning: data definition has no type or storage class
871 | PCIE_ISOLATED,
| ^~~~~~~~~~~~~
include/linux/pci.h:871:9: error: type defaults to 'int' in declaration of 'PCIE_ISOLATED' [-Wimplicit-int]
include/linux/pci.h:876:9: error: type defaults to 'int' in declaration of 'PCIE_SWITCH_DSP_NON_ISOLATED' [-Wimplicit-int]
876 | PCIE_SWITCH_DSP_NON_ISOLATED,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/pci.h:878:9: error: type defaults to 'int' in declaration of 'PCIE_NON_ISOLATED' [-Wimplicit-int]
878 | PCIE_NON_ISOLATED,
| ^~~~~~~~~~~~~~~~~
include/linux/pci.h:884:9: error: type defaults to 'int' in declaration of 'PCI_BUS_NON_ISOLATED' [-Wimplicit-int]
884 | PCI_BUS_NON_ISOLATED,
| ^~~~~~~~~~~~~~~~~~~~
include/linux/pci.h:889:9: error: type defaults to 'int' in declaration of 'PCI_BRIDGE_NON_ISOLATED' [-Wimplicit-int]
889 | PCI_BRIDGE_NON_ISOLATED,
| ^~~~~~~~~~~~~~~~~~~~~~~
include/linux/pci.h:890:1: error: expected identifier or '(' before '}' token
890 | };
| ^
>> include/linux/pci.h:2099:39: warning: 'struct pci_reachable_set' declared inside parameter list will not be visible outside of this definition or declaration
2099 | struct pci_dev *start, struct pci_reachable_set *devfns,
| ^~~~~~~~~~~~~~~~~
include/linux/pci.h:2103:38: error: return type is an incomplete type
2103 | static inline enum pci_bus_isolation pci_bus_isolated(struct pci_bus *bus)
| ^~~~~~~~~~~~~~~~
include/linux/pci.h: In function 'pci_bus_isolated':
include/linux/pci.h:2104:10: error: 'return' with a value, in function returning void [-Wreturn-mismatch]
2104 | { return PCIE_NON_ISOLATED; }
| ^~~~~~~~~~~~~~~~~
include/linux/pci.h:2103:38: note: declared here
2103 | static inline enum pci_bus_isolation pci_bus_isolated(struct pci_bus *bus)
| ^~~~~~~~~~~~~~~~
vim +866 include/linux/pci.h
688297d25e0f71 Jason Gunthorpe 2025-06-26 864
516f3934ddf718 Jason Gunthorpe 2025-06-27 865 enum pci_bus_isolation {
516f3934ddf718 Jason Gunthorpe 2025-06-27 @866 /*
516f3934ddf718 Jason Gunthorpe 2025-06-27 867 * The bus is off a root port and the root port has isolated ACS flags
516f3934ddf718 Jason Gunthorpe 2025-06-27 868 * or the bus is part of a PCIe switch and the switch has isolated ACS
516f3934ddf718 Jason Gunthorpe 2025-06-27 869 * flags.
516f3934ddf718 Jason Gunthorpe 2025-06-27 870 */
516f3934ddf718 Jason Gunthorpe 2025-06-27 @871 PCIE_ISOLATED,
516f3934ddf718 Jason Gunthorpe 2025-06-27 872 /*
516f3934ddf718 Jason Gunthorpe 2025-06-27 873 * The switch's DSP's are not isolated from each other but are isolated
516f3934ddf718 Jason Gunthorpe 2025-06-27 874 * from the USP.
516f3934ddf718 Jason Gunthorpe 2025-06-27 875 */
516f3934ddf718 Jason Gunthorpe 2025-06-27 876 PCIE_SWITCH_DSP_NON_ISOLATED,
516f3934ddf718 Jason Gunthorpe 2025-06-27 877 /* The above and the USP's MMIO is not isolated. */
516f3934ddf718 Jason Gunthorpe 2025-06-27 878 PCIE_NON_ISOLATED,
516f3934ddf718 Jason Gunthorpe 2025-06-27 879 /*
516f3934ddf718 Jason Gunthorpe 2025-06-27 880 * A PCI/PCI-X bus, no isolation. This is like
516f3934ddf718 Jason Gunthorpe 2025-06-27 881 * PCIE_SWITCH_DSP_NON_ISOLATED in that the upstream bridge is isolated
516f3934ddf718 Jason Gunthorpe 2025-06-27 882 * from the bus. The bus itself may also have a shared alias of devfn=0.
516f3934ddf718 Jason Gunthorpe 2025-06-27 883 */
516f3934ddf718 Jason Gunthorpe 2025-06-27 884 PCI_BUS_NON_ISOLATED,
516f3934ddf718 Jason Gunthorpe 2025-06-27 885 /*
516f3934ddf718 Jason Gunthorpe 2025-06-27 886 * The above and the bridge's MMIO is not isolated and the bridge's RID
516f3934ddf718 Jason Gunthorpe 2025-06-27 887 * may be an alias.
516f3934ddf718 Jason Gunthorpe 2025-06-27 888 */
516f3934ddf718 Jason Gunthorpe 2025-06-27 889 PCI_BRIDGE_NON_ISOLATED,
516f3934ddf718 Jason Gunthorpe 2025-06-27 890 };
f7625980f5820e Bjorn Helgaas 2013-11-14 891
:::::: The code at line 866 was first introduced by commit
:::::: 516f3934ddf7189eb3e137e05ef645a5b9b8e83b PCI: Add pci_bus_isolated()
:::::: TO: Jason Gunthorpe <jgg@nvidia.com>
:::::: CC: Jason Gunthorpe <jgg@nvidia.com>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2025-09-16 11:27 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202509161957.c3t4ec9Q-lkp@intel.com \
--to=lkp@intel.com \
--cc=ddutile@redhat.com \
--cc=jgg@nvidia.com \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.