All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kuniyuki Iwashima <kuniyu@google.com>
To: "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	 Jakub Kicinski <kuba@kernel.org>,
	Paolo Abeni <pabeni@redhat.com>
Cc: Simon Horman <horms@kernel.org>,
	Kuniyuki Iwashima <kuniyu@google.com>,
	 Kuniyuki Iwashima <kuni1840@gmail.com>,
	netdev@vger.kernel.org
Subject: [PATCH v2 net-next 0/7] net: Fix UAF of sk_dst_get(sk)->dev.
Date: Tue, 16 Sep 2025 21:47:18 +0000	[thread overview]
Message-ID: <20250916214758.650211-1-kuniyu@google.com> (raw)

syzbot caught use-after-free of sk_dst_get(sk)->dev,
which was not fetched under RCU nor RTNL. [0]

Patch 1 ~ 5, 7 fix UAF in smc, tcp, ktls, mptcp
Patch 6 fixes dst ref leak in mptcp


[0]: https://lore.kernel.org/netdev/68c237c7.050a0220.3c6139.0036.GAE@google.com/


Changes:
  v2:
    * Rebase to net-next (Eric)
    * Drop tcp patch as it's already fixed in net-next (Eric)
    * Drop sk_dst_dev_rcu() helper patch and use dst_dev_rcu() directly (Eric)
    * Split mptcp dst_release() patch (Matthieu)

  v1: https://lore.kernel.org/netdev/20250911030620.1284754-1-kuniyu@google.com/


Kuniyuki Iwashima (7):
  smc: Fix use-after-free in __pnet_find_base_ndev().
  smc: Use __sk_dst_get() and dst_dev_rcu() in in smc_clc_prfx_set().
  smc: Use __sk_dst_get() and dst_dev_rcu() in smc_clc_prfx_match().
  smc: Use __sk_dst_get() and dst_dev_rcu() in smc_vlan_by_tcpsk().
  tls: Use __sk_dst_get() and dst_dev_rcu() in get_netdev_for_sock().
  mptcp: Call dst_release() in mptcp_active_enable().
  mptcp: Use __sk_dst_get() and dst_dev_rcu() in mptcp_active_enable().

 net/mptcp/ctrl.c     |  9 ++++--
 net/smc/smc_clc.c    | 67 +++++++++++++++++++++++---------------------
 net/smc/smc_core.c   | 27 ++++++++----------
 net/smc/smc_pnet.c   | 43 ++++++++++++++--------------
 net/tls/tls_device.c | 18 ++++++------
 5 files changed, 86 insertions(+), 78 deletions(-)

-- 
2.51.0.384.g4c02a37b29-goog


             reply	other threads:[~2025-09-16 21:48 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-16 21:47 Kuniyuki Iwashima [this message]
2025-09-16 21:47 ` [PATCH v2 net-next 1/7] smc: Fix use-after-free in __pnet_find_base_ndev() Kuniyuki Iwashima
2025-09-17  6:52   ` Mahanta Jambigi
2025-09-17  6:56     ` Kuniyuki Iwashima
2025-09-17 14:18   ` Eric Dumazet
2025-09-16 21:47 ` [PATCH v2 net-next 2/7] smc: Use __sk_dst_get() and dst_dev_rcu() in in smc_clc_prfx_set() Kuniyuki Iwashima
2025-09-17 14:12   ` Eric Dumazet
2025-09-16 21:47 ` [PATCH v2 net-next 3/7] smc: Use __sk_dst_get() and dst_dev_rcu() in smc_clc_prfx_match() Kuniyuki Iwashima
2025-09-17 14:13   ` Eric Dumazet
2025-09-16 21:47 ` [PATCH v2 net-next 4/7] smc: Use __sk_dst_get() and dst_dev_rcu() in smc_vlan_by_tcpsk() Kuniyuki Iwashima
2025-09-17  9:13   ` Mahanta Jambigi
2025-09-17 14:09     ` Eric Dumazet
2025-09-17 17:41       ` Kuniyuki Iwashima
2025-09-18  7:34         ` Mahanta Jambigi
2025-09-16 21:47 ` [PATCH v2 net-next 5/7] tls: Use __sk_dst_get() and dst_dev_rcu() in get_netdev_for_sock() Kuniyuki Iwashima
2025-09-17 14:14   ` Eric Dumazet
2025-09-17 15:45   ` Sabrina Dubroca
2025-09-16 21:47 ` [PATCH v2 net-next 6/7] mptcp: Call dst_release() in mptcp_active_enable() Kuniyuki Iwashima
2025-09-17 10:17   ` Matthieu Baerts
2025-09-17 14:04     ` Eric Dumazet
2025-09-17 14:51       ` Matthieu Baerts
2025-09-16 21:47 ` [PATCH v2 net-next 7/7] mptcp: Use __sk_dst_get() and dst_dev_rcu() " Kuniyuki Iwashima
2025-09-17 10:17   ` Matthieu Baerts
2025-09-17 17:43     ` Kuniyuki Iwashima
2025-09-17 14:10   ` Eric Dumazet
2025-09-18  1:20 ` [PATCH v2 net-next 0/7] net: Fix UAF of sk_dst_get(sk)->dev patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250916214758.650211-1-kuniyu@google.com \
    --to=kuniyu@google.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=kuni1840@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.