All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Krzysztof Wilczyński" <kwilczynski@kernel.org>
To: "Thomas Weißschuh" <thomas.weissschuh@linutronix.de>
Cc: Keith Busch <kbusch@kernel.org>,
	Bjorn Helgaas <helgaas@kernel.org>,
	Matthew Wood <thepacketgeek@gmail.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Mario Limonciello <superm1@kernel.org>,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [RESEND PATCH v7 1/1] PCI/sysfs: Expose PCIe device serial number
Date: Wed, 17 Sep 2025 21:16:20 +0900	[thread overview]
Message-ID: <20250917121620.GA792199@rocinante> (raw)
In-Reply-To: <20250917104859-6d38cb60-b638-4e5f-bf67-22683a441ae6@linutronix.de>

Hi Thomas,

> > > It's a waste of resources to provide a handle just to say the capability
> > > doesn't exist when the handle could just not exist instead.
> > 
> > I haven't checked how the kernfs side looks like, admittedly, but I think
> > whether an attribute is visible or not, it does not unload and/or de-allocate
> > any space for the accompanying kernfs object...  So, the resources saving
> > here might not be in any way significant.
> 
> If I read the sysfs code correctly (create_files() in fs/sysfs/group.c),
> the kernfs node should not even be allocated for invisible files.

Good to know!  I wasn't sure and did look...  I stand corrected now.

Thank you for taking the time to check this.  Much appreciated. :)

Thank you!

	Krzysztof

  reply	other threads:[~2025-09-17 12:16 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-21 23:22 [RESEND PATCH v7 0/1] PCI/sysfs: Expose PCIe device serial number Matthew Wood
2025-08-21 23:22 ` [RESEND PATCH v7 1/1] " Matthew Wood
2025-08-22  0:04   ` Keith Busch
2025-08-27  1:34   ` Hans Zhang
2025-08-27 19:39   ` Keith Busch
2025-09-12 16:56     ` Keith Busch
2025-09-13  6:17     ` Krzysztof Wilczyński
2025-09-15 10:03       ` Jonathan Cameron
2025-09-15 14:28       ` Keith Busch
2025-09-13  6:20   ` Krzysztof Wilczyński
2025-09-15 22:23     ` Keith Busch
2025-09-16 13:53       ` Jonathan Cameron
2025-09-15 19:39   ` Bjorn Helgaas
2025-09-16 22:35     ` Keith Busch
2025-09-17  8:34       ` Krzysztof Wilczyński
2025-09-17  8:52         ` Thomas Weißschuh
2025-09-17 12:16           ` Krzysztof Wilczyński [this message]
2025-09-17  9:08         ` Matthew Wood
2025-09-17 12:17           ` Krzysztof Wilczyński
2025-09-17  8:36     ` Krzysztof Wilczyński
  -- strict thread matches above, loose matches on Subject: below --
2025-08-11 17:39 [RESEND PATCH v7 0/1] " Matthew Wood
2025-08-11 17:39 ` [RESEND PATCH v7 1/1] " Matthew Wood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250917121620.GA792199@rocinante \
    --to=kwilczynski@kernel.org \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=bhelgaas@google.com \
    --cc=helgaas@kernel.org \
    --cc=kbusch@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=superm1@kernel.org \
    --cc=thepacketgeek@gmail.com \
    --cc=thomas.weissschuh@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.