From: Dmitry Bogdanov <d.bogdanov@yadro.com>
To: Mike Christie <michael.christie@oracle.com>
Cc: <bvanassche@acm.org>, <martin.petersen@oracle.com>,
<linux-scsi@vger.kernel.org>, <target-devel@vger.kernel.org>
Subject: Re: [PATCH v2 1/3] scsi: target: Fix lun/device R/W and total command stats
Date: Wed, 17 Sep 2025 16:47:45 +0300 [thread overview]
Message-ID: <20250917134745.GG624@yadro.com> (raw)
In-Reply-To: <20250908231000.10777-2-michael.christie@oracle.com>
On Mon, Sep 08, 2025 at 06:05:54PM -0500, Mike Christie wrote:
> In
>
> commit 9cf2317b795d ("scsi: target: Move I/O path stats to per CPU")
>
> I saw we sometimes use %u and also misread the spec. As a result I
> thought all the stats were supposed to be 32 bit only. However, for
> the majority of cases we support currently, the spec specifies u64 bit
> stats. This patch converts the stats changed in the commit above to
> u64.
>
> Fixes: 9cf2317b795d ("scsi: target: Move I/O path stats to per CPU")
> Signed-off-by: Mike Christie <michael.christie@oracle.com>
> ---
Reviewed-by: Dmitry Bogdanov <d.bogdanov@yadro.com>
next prev parent reply other threads:[~2025-09-17 13:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-08 23:05 [PATCH v2 0/3] target: RW/num_cmds stats improvements Mike Christie
2025-09-08 23:05 ` [PATCH v2 1/3] scsi: target: Fix lun/device R/W and total command stats Mike Christie
2025-09-17 13:47 ` Dmitry Bogdanov [this message]
2025-09-08 23:05 ` [PATCH v2 2/3] scsi: target: Create and use macro helpers for per CPU stats Mike Christie
2025-09-17 13:33 ` Dmitry Bogdanov
2025-09-08 23:05 ` [PATCH v2 3/3] scsi: target: Move LUN stats to per CPU Mike Christie
2025-09-09 15:36 ` Maurizio Lombardi
2025-09-17 13:38 ` Dmitry Bogdanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250917134745.GG624@yadro.com \
--to=d.bogdanov@yadro.com \
--cc=bvanassche@acm.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=michael.christie@oracle.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.