From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 704A12DA76C for ; Wed, 17 Sep 2025 13:24:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.176.79.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758115475; cv=none; b=UNSqOeNTxjREh/cd6On5QUF3AwNJWhKR/ubkWWd50ELjaIC3Ppv9RlI1FnegatbKqktuzUpcsyVLgkE1BTKCAStm5m5j+HQIKdUpWmZCDk0HP34xJ6RAfYrfYDHTZ51QuYj1CYb2PiKf4Dxuyw3Wizd76qxax8z5IzOlQabbI74= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758115475; c=relaxed/simple; bh=FCVWkLnUHjeQ4+kVOABHct45GhK6KK3Oxcex8LSoYsc=; h=Date:From:To:CC:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ic5e7Uc7WR8SNIrnn5W0qiIE6xFP6xhT+U5thC2TVtwfSfuKb0yVR64tPCNdaFuNAkMcEkB5UHi3CbQa1sEKCXiTHGDMBSae70oEt1nYvfp9iFrJ8UsjaelspHQv/iY45IGwJi2QpNfzcwNKGHyrezCl0+837Y5x7U1oBlJthiE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=185.176.79.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4cRfb36G2vz6GDKy; Wed, 17 Sep 2025 21:22:55 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id CF4CE1400F4; Wed, 17 Sep 2025 21:24:28 +0800 (CST) Received: from localhost (10.203.177.15) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 17 Sep 2025 15:24:25 +0200 Date: Wed, 17 Sep 2025 14:24:24 +0100 From: Jonathan Cameron To: Akihiko Odaki CC: , Richard Henderson , Peter Maydell , "=?ISO-8859-1?Q?C=E9dric?= Le Goater" , Steven Lee , Troy Lee , Jamin Lin , Andrew Jeffery , Joel Stanley , Eric Auger , Helge Deller , Philippe =?ISO-8859-1?Q?Mathieu-Daud=E9?= , =?ISO-8859-1?Q?Herv?= =?ISO-8859-1?Q?=E9?= Poussineau , Aleksandar Rikalo , "Edgar E. Iglesias" , Alistair Francis , Ninad Palsule , Paolo Bonzini , "Eduardo Habkost" , "Michael S. Tsirkin" , Marcel Apfelbaum , Jason Wang , Yi Liu , =?ISO-8859-1?Q?Cl=E9m?= =?ISO-8859-1?Q?ent?= Mathieu--Drif , Nicholas Piggin , Aditya Gupta , Gautam Menghani , Song Gao , Bibo Mao , Jiaxun Yang , "Fan Ni" , David Hildenbrand , "Igor Mammedov" , Xiao Guangrong , Beniamino Galvani , Strahinja Jankovic , Subbaraya Sundeep , Jan Kiszka , Laurent Vivier , Andrey Smirnov , "Aurelien Jarno" , BALATON Zoltan , Bernhard Beschow , Harsh Prateek Bora , Elena Ufimtseva , Jagannathan Raman , Palmer Dabbelt , Weiwei Li , "Daniel Henrique Barboza" , Liu Zhiwei , Matthew Rosato , Eric Farman , Thomas Huth , "Halil Pasic" , Christian Borntraeger , Ilya Leoshkevich , "Fam Zheng" , Bin Meng , Mark Cave-Ayland , Artyom Tarasenko , Peter Xu , Marcelo Tosatti , "Max Filippov" , , , , , , , Alex Williamson , =?ISO-8859-1?Q?C=E9dric?= Le Goater , Stefano Garzarella , "Alistair Francis" Subject: Re: [PATCH 13/35] hw/mem: QOM-ify AddressSpace Message-ID: <20250917142424.000019d3@huawei.com> In-Reply-To: <20250917-qom-v1-13-7262db7b0a84@rsg.ci.i.u-tokyo.ac.jp> References: <20250917-qom-v1-0-7262db7b0a84@rsg.ci.i.u-tokyo.ac.jp> <20250917-qom-v1-13-7262db7b0a84@rsg.ci.i.u-tokyo.ac.jp> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: lhrpeml500006.china.huawei.com (7.191.161.198) To frapeml500008.china.huawei.com (7.182.85.71) On Wed, 17 Sep 2025 21:56:25 +0900 Akihiko Odaki wrote: > Make AddressSpaces QOM objects to ensure that they are destroyed when > their owners are finalized and also to get a unique path for debugging > output. > > The name arguments were used to distinguish AddresSpaces in debugging > output, but they will represent property names after QOM-ification and > debugging output will show QOM paths. So change them to make them more > concise and also avoid conflicts with other properties. > > Signed-off-by: Akihiko Odaki Assuming the fundamental change makes sense (which I haven't looked into in enough depth!), this CXL bit looks fine to me. Acked-by: Jonathan Cameron > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1E89ECAC599 for ; Wed, 17 Sep 2025 13:43:27 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uysQx-0003gi-4W; Wed, 17 Sep 2025 09:42:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uysQu-0003gE-61; Wed, 17 Sep 2025 09:42:52 -0400 Received: from [185.176.79.56] (helo=frasgout.his.huawei.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uysQq-0003x3-1Q; Wed, 17 Sep 2025 09:42:51 -0400 Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4cRfb36G2vz6GDKy; Wed, 17 Sep 2025 21:22:55 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id CF4CE1400F4; Wed, 17 Sep 2025 21:24:28 +0800 (CST) Received: from localhost (10.203.177.15) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 17 Sep 2025 15:24:25 +0200 Date: Wed, 17 Sep 2025 14:24:24 +0100 To: Akihiko Odaki CC: , Richard Henderson , Peter Maydell , "=?ISO-8859-1?Q?C=E9dric?= Le Goater" , Steven Lee , Troy Lee , Jamin Lin , Andrew Jeffery , Joel Stanley , Eric Auger , Helge Deller , Philippe =?ISO-8859-1?Q?Mathieu-Daud=E9?= , =?ISO-8859-1?Q?Herv?= =?ISO-8859-1?Q?=E9?= Poussineau , Aleksandar Rikalo , "Edgar E. Iglesias" , Alistair Francis , Ninad Palsule , Paolo Bonzini , "Eduardo Habkost" , "Michael S. Tsirkin" , Marcel Apfelbaum , Jason Wang , Yi Liu , =?ISO-8859-1?Q?Cl=E9m?= =?ISO-8859-1?Q?ent?= Mathieu--Drif , Nicholas Piggin , Aditya Gupta , Gautam Menghani , Song Gao , Bibo Mao , Jiaxun Yang , "Fan Ni" , David Hildenbrand , "Igor Mammedov" , Xiao Guangrong , Beniamino Galvani , Strahinja Jankovic , Subbaraya Sundeep , Jan Kiszka , Laurent Vivier , Andrey Smirnov , "Aurelien Jarno" , BALATON Zoltan , Bernhard Beschow , Harsh Prateek Bora , Elena Ufimtseva , Jagannathan Raman , Palmer Dabbelt , Weiwei Li , "Daniel Henrique Barboza" , Liu Zhiwei , Matthew Rosato , Eric Farman , Thomas Huth , "Halil Pasic" , Christian Borntraeger , Ilya Leoshkevich , "Fam Zheng" , Bin Meng , Mark Cave-Ayland , Artyom Tarasenko , Peter Xu , Marcelo Tosatti , "Max Filippov" , , , , , , , Alex Williamson , =?ISO-8859-1?Q?C=E9dric?= Le Goater , Stefano Garzarella , "Alistair Francis" Subject: Re: [PATCH 13/35] hw/mem: QOM-ify AddressSpace Message-ID: <20250917142424.000019d3@huawei.com> In-Reply-To: <20250917-qom-v1-13-7262db7b0a84@rsg.ci.i.u-tokyo.ac.jp> References: <20250917-qom-v1-0-7262db7b0a84@rsg.ci.i.u-tokyo.ac.jp> <20250917-qom-v1-13-7262db7b0a84@rsg.ci.i.u-tokyo.ac.jp> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.203.177.15] X-ClientProxiedBy: lhrpeml500006.china.huawei.com (7.191.161.198) To frapeml500008.china.huawei.com (7.182.85.71) X-Host-Lookup-Failed: Reverse DNS lookup failed for 185.176.79.56 (deferred) Received-SPF: pass client-ip=185.176.79.56; envelope-from=jonathan.cameron@huawei.com; helo=frasgout.his.huawei.com X-Spam_score_int: -33 X-Spam_score: -3.4 X-Spam_bar: --- X-Spam_report: (-3.4 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Jonathan Cameron From: Jonathan Cameron via Errors-To: qemu-riscv-bounces+qemu-riscv=archiver.kernel.org@nongnu.org Sender: qemu-riscv-bounces+qemu-riscv=archiver.kernel.org@nongnu.org On Wed, 17 Sep 2025 21:56:25 +0900 Akihiko Odaki wrote: > Make AddressSpaces QOM objects to ensure that they are destroyed when > their owners are finalized and also to get a unique path for debugging > output. > > The name arguments were used to distinguish AddresSpaces in debugging > output, but they will represent property names after QOM-ification and > debugging output will show QOM paths. So change them to make them more > concise and also avoid conflicts with other properties. > > Signed-off-by: Akihiko Odaki Assuming the fundamental change makes sense (which I haven't looked into in enough depth!), this CXL bit looks fine to me. Acked-by: Jonathan Cameron > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EB4A8CAC599 for ; Wed, 17 Sep 2025 13:25:01 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uys9N-00042z-8p; Wed, 17 Sep 2025 09:24:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uys9H-0003wk-TF; Wed, 17 Sep 2025 09:24:40 -0400 Received: from [185.176.79.56] (helo=frasgout.his.huawei.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uys9F-0001UD-UO; Wed, 17 Sep 2025 09:24:39 -0400 Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4cRfYc1PwSz6M4ks; Wed, 17 Sep 2025 21:21:40 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id CF4CE1400F4; Wed, 17 Sep 2025 21:24:28 +0800 (CST) Received: from localhost (10.203.177.15) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 17 Sep 2025 15:24:25 +0200 Date: Wed, 17 Sep 2025 14:24:24 +0100 To: Akihiko Odaki CC: , Richard Henderson , Peter Maydell , "=?ISO-8859-1?Q?C=E9dric?= Le Goater" , Steven Lee , Troy Lee , Jamin Lin , Andrew Jeffery , Joel Stanley , Eric Auger , Helge Deller , Philippe =?ISO-8859-1?Q?Mathieu-Daud=E9?= , =?ISO-8859-1?Q?Herv?= =?ISO-8859-1?Q?=E9?= Poussineau , Aleksandar Rikalo , "Edgar E. Iglesias" , Alistair Francis , Ninad Palsule , Paolo Bonzini , "Eduardo Habkost" , "Michael S. Tsirkin" , Marcel Apfelbaum , Jason Wang , Yi Liu , =?ISO-8859-1?Q?Cl=E9m?= =?ISO-8859-1?Q?ent?= Mathieu--Drif , Nicholas Piggin , Aditya Gupta , Gautam Menghani , Song Gao , Bibo Mao , Jiaxun Yang , "Fan Ni" , David Hildenbrand , "Igor Mammedov" , Xiao Guangrong , Beniamino Galvani , Strahinja Jankovic , Subbaraya Sundeep , Jan Kiszka , Laurent Vivier , Andrey Smirnov , "Aurelien Jarno" , BALATON Zoltan , Bernhard Beschow , Harsh Prateek Bora , Elena Ufimtseva , Jagannathan Raman , Palmer Dabbelt , Weiwei Li , "Daniel Henrique Barboza" , Liu Zhiwei , Matthew Rosato , Eric Farman , Thomas Huth , "Halil Pasic" , Christian Borntraeger , Ilya Leoshkevich , "Fam Zheng" , Bin Meng , Mark Cave-Ayland , Artyom Tarasenko , Peter Xu , Marcelo Tosatti , "Max Filippov" , , , , , , , Alex Williamson , =?ISO-8859-1?Q?C=E9dric?= Le Goater , Stefano Garzarella , "Alistair Francis" Subject: Re: [PATCH 13/35] hw/mem: QOM-ify AddressSpace Message-ID: <20250917142424.000019d3@huawei.com> In-Reply-To: <20250917-qom-v1-13-7262db7b0a84@rsg.ci.i.u-tokyo.ac.jp> References: <20250917-qom-v1-0-7262db7b0a84@rsg.ci.i.u-tokyo.ac.jp> <20250917-qom-v1-13-7262db7b0a84@rsg.ci.i.u-tokyo.ac.jp> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.203.177.15] X-ClientProxiedBy: lhrpeml500006.china.huawei.com (7.191.161.198) To frapeml500008.china.huawei.com (7.182.85.71) X-Host-Lookup-Failed: Reverse DNS lookup failed for 185.176.79.56 (deferred) Received-SPF: pass client-ip=185.176.79.56; envelope-from=jonathan.cameron@huawei.com; helo=frasgout.his.huawei.com X-Spam_score_int: -33 X-Spam_score: -3.4 X-Spam_bar: --- X-Spam_report: (-3.4 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Jonathan Cameron From: Jonathan Cameron via Errors-To: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Sender: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org On Wed, 17 Sep 2025 21:56:25 +0900 Akihiko Odaki wrote: > Make AddressSpaces QOM objects to ensure that they are destroyed when > their owners are finalized and also to get a unique path for debugging > output. > > The name arguments were used to distinguish AddresSpaces in debugging > output, but they will represent property names after QOM-ification and > debugging output will show QOM paths. So change them to make them more > concise and also avoid conflicts with other properties. > > Signed-off-by: Akihiko Odaki Assuming the fundamental change makes sense (which I haven't looked into in enough depth!), this CXL bit looks fine to me. Acked-by: Jonathan Cameron > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 88B0DCAC599 for ; Wed, 17 Sep 2025 13:25:31 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uys9Q-00043t-PA; Wed, 17 Sep 2025 09:24:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uys9H-0003wk-TF; Wed, 17 Sep 2025 09:24:40 -0400 Received: from [185.176.79.56] (helo=frasgout.his.huawei.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uys9F-0001UD-UO; Wed, 17 Sep 2025 09:24:39 -0400 Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4cRfYc1PwSz6M4ks; Wed, 17 Sep 2025 21:21:40 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id CF4CE1400F4; Wed, 17 Sep 2025 21:24:28 +0800 (CST) Received: from localhost (10.203.177.15) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 17 Sep 2025 15:24:25 +0200 Date: Wed, 17 Sep 2025 14:24:24 +0100 To: Akihiko Odaki CC: , Richard Henderson , Peter Maydell , "=?ISO-8859-1?Q?C=E9dric?= Le Goater" , Steven Lee , Troy Lee , Jamin Lin , Andrew Jeffery , Joel Stanley , Eric Auger , Helge Deller , Philippe =?ISO-8859-1?Q?Mathieu-Daud=E9?= , =?ISO-8859-1?Q?Herv?= =?ISO-8859-1?Q?=E9?= Poussineau , Aleksandar Rikalo , "Edgar E. Iglesias" , Alistair Francis , Ninad Palsule , Paolo Bonzini , "Eduardo Habkost" , "Michael S. Tsirkin" , Marcel Apfelbaum , Jason Wang , Yi Liu , =?ISO-8859-1?Q?Cl=E9m?= =?ISO-8859-1?Q?ent?= Mathieu--Drif , Nicholas Piggin , Aditya Gupta , Gautam Menghani , Song Gao , Bibo Mao , Jiaxun Yang , "Fan Ni" , David Hildenbrand , "Igor Mammedov" , Xiao Guangrong , Beniamino Galvani , Strahinja Jankovic , Subbaraya Sundeep , Jan Kiszka , Laurent Vivier , Andrey Smirnov , "Aurelien Jarno" , BALATON Zoltan , Bernhard Beschow , Harsh Prateek Bora , Elena Ufimtseva , Jagannathan Raman , Palmer Dabbelt , Weiwei Li , "Daniel Henrique Barboza" , Liu Zhiwei , Matthew Rosato , Eric Farman , Thomas Huth , "Halil Pasic" , Christian Borntraeger , Ilya Leoshkevich , "Fam Zheng" , Bin Meng , Mark Cave-Ayland , Artyom Tarasenko , Peter Xu , Marcelo Tosatti , "Max Filippov" , , , , , , , Alex Williamson , =?ISO-8859-1?Q?C=E9dric?= Le Goater , Stefano Garzarella , "Alistair Francis" Subject: Re: [PATCH 13/35] hw/mem: QOM-ify AddressSpace Message-ID: <20250917142424.000019d3@huawei.com> In-Reply-To: <20250917-qom-v1-13-7262db7b0a84@rsg.ci.i.u-tokyo.ac.jp> References: <20250917-qom-v1-0-7262db7b0a84@rsg.ci.i.u-tokyo.ac.jp> <20250917-qom-v1-13-7262db7b0a84@rsg.ci.i.u-tokyo.ac.jp> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.203.177.15] X-ClientProxiedBy: lhrpeml500006.china.huawei.com (7.191.161.198) To frapeml500008.china.huawei.com (7.182.85.71) X-Host-Lookup-Failed: Reverse DNS lookup failed for 185.176.79.56 (deferred) Received-SPF: pass client-ip=185.176.79.56; envelope-from=jonathan.cameron@huawei.com; helo=frasgout.his.huawei.com X-Spam_score_int: -33 X-Spam_score: -3.4 X-Spam_bar: --- X-Spam_report: (-3.4 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Jonathan Cameron From: Jonathan Cameron via Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Wed, 17 Sep 2025 21:56:25 +0900 Akihiko Odaki wrote: > Make AddressSpaces QOM objects to ensure that they are destroyed when > their owners are finalized and also to get a unique path for debugging > output. > > The name arguments were used to distinguish AddresSpaces in debugging > output, but they will represent property names after QOM-ification and > debugging output will show QOM paths. So change them to make them more > concise and also avoid conflicts with other properties. > > Signed-off-by: Akihiko Odaki Assuming the fundamental change makes sense (which I haven't looked into in enough depth!), this CXL bit looks fine to me. Acked-by: Jonathan Cameron >