From: Simon Horman <horms@kernel.org>
To: Konrad Leszczynski <konrad.leszczynski@intel.com>
Cc: davem@davemloft.net, andrew+netdev@lunn.ch, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, cezary.rojewski@intel.com,
sebastian.basierski@intel.com,
Piotr Warpechowski <piotr.warpechowski@intel.com>,
Karol Jurczenia <karol.jurczenia@intel.com>
Subject: Re: [PATCH net-next v3 1/3] net: stmmac: enhance VLAN protocol detection for GRO
Date: Wed, 17 Sep 2025 15:54:43 +0100 [thread overview]
Message-ID: <20250917145443.GN394836@horms.kernel.org> (raw)
In-Reply-To: <20250916124808.218514-2-konrad.leszczynski@intel.com>
On Tue, Sep 16, 2025 at 02:48:06PM +0200, Konrad Leszczynski wrote:
> From: Piotr Warpechowski <piotr.warpechowski@intel.com>
>
> Enhance protocol extraction in stmmac_has_ip_ethertype() by introducing
> MAC offset parameter and changing:
>
> __vlan_get_protocol() -> __vlan_get_protocol_offset()
>
> Add correct header length for VLAN tags, which enable Generic Receive
> Offload (GRO) in VLAN.
>
> Co-developed-by: Karol Jurczenia <karol.jurczenia@intel.com>
> Signed-off-by: Karol Jurczenia <karol.jurczenia@intel.com>
> Reviewed-by: Konrad Leszczynski <konrad.leszczynski@intel.com>
> Reviewed-by: Sebastian Basierski <sebastian.basierski@intel.com>
> Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com>
> Signed-off-by: Piotr Warpechowski <piotr.warpechowski@intel.com>
Hi Konrad,
As you are sending these patches, your Signed-off-by line is needed.
I would suggest at the end of the tags. And when present,
you can drop your Reviewed-by tag (it is implied).
Otherwise this patch looks good to me.
Same for the other patches in this series.
--
pw-bot: changes-requested
next prev parent reply other threads:[~2025-09-17 14:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-16 12:48 [PATCH net-next v3 0/3] net: stmmac: new features Konrad Leszczynski
2025-09-16 12:48 ` [PATCH net-next v3 1/3] net: stmmac: enhance VLAN protocol detection for GRO Konrad Leszczynski
2025-09-17 14:54 ` Simon Horman [this message]
2025-09-16 12:48 ` [PATCH net-next v3 2/3] net: stmmac: add TC flower filter support for IP EtherType Konrad Leszczynski
2025-09-16 12:48 ` [PATCH net-next v3 3/3] net: stmmac: correct Tx descriptors debugfs prints Konrad Leszczynski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250917145443.GN394836@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=cezary.rojewski@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=karol.jurczenia@intel.com \
--cc=konrad.leszczynski@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=piotr.warpechowski@intel.com \
--cc=sebastian.basierski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.