From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from zeniv.linux.org.uk (zeniv.linux.org.uk [62.89.141.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B2422F2604; Wed, 17 Sep 2025 21:10:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=62.89.141.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758143413; cv=none; b=Wl2NwWyB/9lOrag18CY5kJreB1IVAsSr/1yAv/RUNA+R0Mip9HWDLZDUbZykZsQ9Dw0bhOKB9B5u8efmfvlKyYdcGYC3YgSK+6FUjB+T3UxGvG+mWwb67jM5JINHNFdBULReYRbCeP/xmIXvSt2OSG/VAaQ0nV+StquzBH47Cns= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758143413; c=relaxed/simple; bh=2vIOMdy4Vj9yN8eIvTrykpOLQsfLeeAOAEeq7Z/Fd7Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jrAdmhijGhkbyCJRAYCS3VeHrd96cf4U6KJPf9yHqkoMXfkOVC3VbmgbvhM1wKXywdqpxCngjUsl6CzQRCRFAUa1gX7F7hhEJqugjCmL6zw6oIV/FnXYqlog/xsEvVilkrP0mrCXUCu+ppz3h5aJ5SXHaPF0WfdTj7xwzK4o0RA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=zeniv.linux.org.uk; spf=none smtp.mailfrom=ftp.linux.org.uk; dkim=pass (2048-bit key) header.d=linux.org.uk header.i=@linux.org.uk header.b=C8jYwmOY; arc=none smtp.client-ip=62.89.141.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=zeniv.linux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=ftp.linux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linux.org.uk header.i=@linux.org.uk header.b="C8jYwmOY" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linux.org.uk; s=zeniv-20220401; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description; bh=4zCJt6toGovk2j2NYp2jgoQbUCVgHY4TcWg2PTIc63E=; b=C8jYwmOYevWbVc6pf7aTmx8bBK ZKVs/QU3wTUQhsll2PGahlaXKDvDiZjDPuBKP+nl2ilLTquFNbNkaBwA7l6y7kD0pRBCEKgu17Z9c Zj/WuauoJxZrG+v+0RkolMxZb0YzY4BtuoiLaMieXsVhnTfO2nvmCwyg4QaG3lMFkkUf+K+bNOBdo gb4pt2DK+NkKXEBPGrnIgzEeHid/W12ivCUcnXuZn/wDnQiP8Uzpm566RJcZjwjsJFj+EVCGmv+be lEp4cjlG/tAQIj6pbYOymDA2XQWSsfyXgBkFWYp0UT7LpYvtNY+vz5GCSqsQLmIsPgIyVEucMogS9 zJhAVV+g==; Received: from viro by zeniv.linux.org.uk with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1uyzPl-00000008YoM-1TR8; Wed, 17 Sep 2025 21:10:09 +0000 Date: Wed, 17 Sep 2025 22:10:09 +0100 From: Al Viro To: Max Kellermann Cc: Mateusz Guzik , linux-fsdevel , Linux Memory Management List , ceph-devel@vger.kernel.org Subject: Re: Need advice with iput() deadlock during writeback Message-ID: <20250917211009.GE39973@ZenIV> References: <4z3imll6zbzwqcyfl225xn3rc4mev6ppjnx5itmvznj2yormug@utk6twdablj3> <20250917201408.GX39973@ZenIV> <20250917203435.GA39973@ZenIV> Precedence: bulk X-Mailing-List: ceph-devel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: Al Viro On Wed, Sep 17, 2025 at 10:36:48PM +0200, Max Kellermann wrote: > On Wed, Sep 17, 2025 at 10:34 PM Al Viro wrote: > > Suppose two threads do umount() on two different filesystems. The first > > one to flush picks *everything* you've delayed and starts handling that. > > The second sees nothing to do and proceeds to taking the filesystem > > it's unmounting apart, right under the nose of the first thread doing > > work on both filesystems... > > Each filesystem (struct ceph_fs_client) has its own inode_wq. Yes, but if (llist_add(&ci->async_llist, &delayed_ceph_iput_list)) schedule_delayed_work(&delayed_ceph_iput_work, 1); won't have anything to do with that.