From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8AB80CAC59A for ; Thu, 18 Sep 2025 14:40:57 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 41D4784566; Thu, 18 Sep 2025 14:40:56 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id dPo6zTeu6HPF; Thu, 18 Sep 2025 14:40:55 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 88856844DB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1758206455; bh=cb39dSrqocHlslF00dbHVz6qUIck2mU9q6mkn//uO+c=; h=Date:From:To:Cc:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=SEQOQinriDcjHLScF0jN9RSe4eqtfEPF2Y6vf0bVWrhwKcFXF9P5CshIAueX6+2Bd zM3p1Wt+0l7TlVKETeOYtrhkZe2VTiBx5rkMz3I9xSq2Qpqz6YJiF+H2JFCBjlhrKT H46GfRuvEdhmGPEPEnfXxK0qZy7AOeGu6t6GUYiDaXj/NWduh7LF2reCz8I4r5X7yj M/XsK9QrdgFu5n6OqJHXkEFEaCn0kestcd54u+eV+IvxjJ7VToaDc4qv0m1Mlre8cb LzL+ZGcY5sg5v9nrDW3YzP7OR0gzE/+T/THC29u7OZ1AyXP/HjdzD2Ty3jyEzw1/kg apemWxQ6GedBg== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp1.osuosl.org (Postfix) with ESMTP id 88856844DB; Thu, 18 Sep 2025 14:40:55 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists1.osuosl.org (Postfix) with ESMTP id 91B1B199 for ; Thu, 18 Sep 2025 14:40:53 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 60DC584406 for ; Thu, 18 Sep 2025 14:40:51 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id AdaEC-xzefCY for ; Thu, 18 Sep 2025 14:40:50 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=172.234.252.31; helo=sea.source.kernel.org; envelope-from=kuba@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp1.osuosl.org 7AF09842A4 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 7AF09842A4 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by smtp1.osuosl.org (Postfix) with ESMTPS id 7AF09842A4 for ; Thu, 18 Sep 2025 14:40:47 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 0884F438F2; Thu, 18 Sep 2025 14:40:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 08552C4CEE7; Thu, 18 Sep 2025 14:40:44 +0000 (UTC) Date: Thu, 18 Sep 2025 07:40:44 -0700 From: Jakub Kicinski To: Vadim Fedorenko Cc: Andrew Lunn , Michael Chan , Pavan Chebbi , Tariq Toukan , Gal Pressman , intel-wired-lan@lists.osuosl.org, Donald Hunter , Carolina Jubran , Paolo Abeni , Simon Horman , netdev@vger.kernel.org, Yael Chemla , Dragos Tatulea Message-ID: <20250918074044.4b3e8ac2@kernel.org> In-Reply-To: <28315831-21f7-49e0-b445-b3df0cb123e0@linux.dev> References: <20250916191257.13343-1-vadim.fedorenko@linux.dev> <20250916191257.13343-5-vadim.fedorenko@linux.dev> <20250917174837.5ea2d864@kernel.org> <28315831-21f7-49e0-b445-b3df0cb123e0@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1758206445; bh=Lf3DkMG5CSfOckaU6onnP263E2CUT5+6A9+k8/tvYqM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ZIL1fY4rmW6BOX721LiMRpVNCdWyKsX/5ajxk+VSvpH6f/FllLOdcRMGCh/CD4v5B CL0rkh6FsbBs5oJrW/17+IX5scqPkpX+ekJWmxcYk0Kg0Btn1SOmAJAlNgC/FyhCEq qF/YTykFUWbqU1BpvmgqH+EA20+ZhLm+U52elFLkbXONw1YVSsHlE/mRHOZph+uO2h Hu0cauc5PVCeB/V5sUkFgJRKzxxJhLKIrkxCdDRxMrQttTrRaOTX6IhYguZBT7N3A0 PpLT+tD8QT9aZnSNjhm64RjNOJQsnphuXV3t5pStapRIDA461cPBzmUP7Ka4sn0oSm 7cCiNp7fvKsPg== X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=ZIL1fY4r Subject: Re: [Intel-wired-lan] [PATCH net-next v3 4/4] net/mlx5e: Report RS-FEC histogram statistics via ethtool X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Thu, 18 Sep 2025 15:32:51 +0100 Vadim Fedorenko wrote: > On 18/09/2025 01:48, Jakub Kicinski wrote: > > On Tue, 16 Sep 2025 19:12:57 +0000 Vadim Fedorenko wrote: > >> + for (int i = 0; i < num_of_bins; i++) { > > > > brackets unnecessary > > > > in the other patch you picked u8 for i, good to be consistent > > (int is better) > > > >> + hist->values[i].bin_value = MLX5_GET64(rs_histogram_cntrs, > >> + rs_histogram_cntrs, > >> + hist[i]); > > > > could also be written as: > > > > hist->values[i].bin_value = > > MLX5_GET64(rs_histogram_cntrs, rs_histogram_cntrs, hist[i]); > > this doesn't actually fit into 80 chars (84 chars long)... unless we are > not too strict in the drivers.. Thought it did, ignore the suggestion, then From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 07B2F1F9F70 for ; Thu, 18 Sep 2025 14:40:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758206446; cv=none; b=ZW2wJZ+yJ7bN2xwoQEe21arR/hBPysqd7wPBrwJHS4+Y3OHT/jG6kd76A/RLpTEoLyTuVoN0FnrLVPogk1hoRJiRvp2NAGb+B21joMiKD3XcHXTO8J9tkXLirBIBhGFMcL42u+LeeyQEW+IE5+ht/6Z9SEXvq4goDkyNJOSNatE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758206446; c=relaxed/simple; bh=Lf3DkMG5CSfOckaU6onnP263E2CUT5+6A9+k8/tvYqM=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=LHtbJk6Jp7DtvHZLxRViskGIwCxhQa3p2Xbt8gn/H7Vs5sRQQFJpXqd4G6HKG+SnViCnJeLbG+HSI/oYIm3YIMTSNDXnNsay+rEQ17XgtdA2/Uk6MJGicgTrPK1FA7nh4fyULi/pJ0pHOdj9s4edR+czr3B4btkB0wic43yGDkU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ZIL1fY4r; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZIL1fY4r" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 08552C4CEE7; Thu, 18 Sep 2025 14:40:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1758206445; bh=Lf3DkMG5CSfOckaU6onnP263E2CUT5+6A9+k8/tvYqM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ZIL1fY4rmW6BOX721LiMRpVNCdWyKsX/5ajxk+VSvpH6f/FllLOdcRMGCh/CD4v5B CL0rkh6FsbBs5oJrW/17+IX5scqPkpX+ekJWmxcYk0Kg0Btn1SOmAJAlNgC/FyhCEq qF/YTykFUWbqU1BpvmgqH+EA20+ZhLm+U52elFLkbXONw1YVSsHlE/mRHOZph+uO2h Hu0cauc5PVCeB/V5sUkFgJRKzxxJhLKIrkxCdDRxMrQttTrRaOTX6IhYguZBT7N3A0 PpLT+tD8QT9aZnSNjhm64RjNOJQsnphuXV3t5pStapRIDA461cPBzmUP7Ka4sn0oSm 7cCiNp7fvKsPg== Date: Thu, 18 Sep 2025 07:40:44 -0700 From: Jakub Kicinski To: Vadim Fedorenko Cc: Andrew Lunn , Michael Chan , Pavan Chebbi , Tariq Toukan , Gal Pressman , intel-wired-lan@lists.osuosl.org, Donald Hunter , Carolina Jubran , Paolo Abeni , Simon Horman , netdev@vger.kernel.org, Yael Chemla , Dragos Tatulea Subject: Re: [PATCH net-next v3 4/4] net/mlx5e: Report RS-FEC histogram statistics via ethtool Message-ID: <20250918074044.4b3e8ac2@kernel.org> In-Reply-To: <28315831-21f7-49e0-b445-b3df0cb123e0@linux.dev> References: <20250916191257.13343-1-vadim.fedorenko@linux.dev> <20250916191257.13343-5-vadim.fedorenko@linux.dev> <20250917174837.5ea2d864@kernel.org> <28315831-21f7-49e0-b445-b3df0cb123e0@linux.dev> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 18 Sep 2025 15:32:51 +0100 Vadim Fedorenko wrote: > On 18/09/2025 01:48, Jakub Kicinski wrote: > > On Tue, 16 Sep 2025 19:12:57 +0000 Vadim Fedorenko wrote: > >> + for (int i = 0; i < num_of_bins; i++) { > > > > brackets unnecessary > > > > in the other patch you picked u8 for i, good to be consistent > > (int is better) > > > >> + hist->values[i].bin_value = MLX5_GET64(rs_histogram_cntrs, > >> + rs_histogram_cntrs, > >> + hist[i]); > > > > could also be written as: > > > > hist->values[i].bin_value = > > MLX5_GET64(rs_histogram_cntrs, rs_histogram_cntrs, hist[i]); > > this doesn't actually fit into 80 chars (84 chars long)... unless we are > not too strict in the drivers.. Thought it did, ignore the suggestion, then