All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@nvidia.com>
To: Nicolin Chen <nicolinc@nvidia.com>
Cc: iommu@lists.linux.dev,
	Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
	Lu Baolu <baolu.lu@linux.intel.com>,
	Kevin Tian <kevin.tian@intel.com>,
	patches@lists.linux.dev, Pranjal Shrivastava <praan@google.com>
Subject: Re: [PATCH] iommufd: Fix refcounting race during mmap
Date: Thu, 18 Sep 2025 11:44:24 -0300	[thread overview]
Message-ID: <20250918144424.GN1391379@nvidia.com> (raw)
In-Reply-To: <aMr/JyYjV97r+vqx@Asurada-Nvidia>

On Wed, Sep 17, 2025 at 11:34:15AM -0700, Nicolin Chen wrote:
> > @@ -551,15 +551,22 @@ static int iommufd_fops_mmap(struct file *filp, struct vm_area_struct *vma)
> >  		return -EPERM;
> >  
> >  	/* vma->vm_pgoff carries a page-shifted start position to an immap */
> > +	mtree_lock(&ictx->mt_mmap);
> >  	immap = mtree_load(&ictx->mt_mmap, vma->vm_pgoff << PAGE_SHIFT);
> 
> Nit: should we put the comment line closer to mtree_load()?

Ok

Thanks,
Jason

  reply	other threads:[~2025-09-18 14:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-16 16:10 [PATCH] iommufd: Fix refcounting race during mmap Jason Gunthorpe
2025-09-17 18:34 ` Nicolin Chen
2025-09-18 14:44   ` Jason Gunthorpe [this message]
2025-09-19  8:13 ` Tian, Kevin
2025-09-19 13:42 ` Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250918144424.GN1391379@nvidia.com \
    --to=jgg@nvidia.com \
    --cc=baolu.lu@linux.intel.com \
    --cc=iommu@lists.linux.dev \
    --cc=kevin.tian@intel.com \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=nicolinc@nvidia.com \
    --cc=patches@lists.linux.dev \
    --cc=praan@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.