From: Simon Horman <horms@kernel.org>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Roger Quadros <rogerq@ti.com>,
MD Danish Anwar <danishanwar@ti.com>,
Parvathi Pudi <parvathi@couthit.com>,
Roger Quadros <rogerq@kernel.org>,
Mohan Reddy Putluru <pmohan@couthit.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Basharath Hussain Khaja <basharath@couthit.com>,
"Andrew F. Davis" <afd@ti.com>,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net-next] net: ti: icssm-prueth: unwind cleanly in probe()
Date: Thu, 18 Sep 2025 17:27:56 +0100 [thread overview]
Message-ID: <20250918162756.GA394836@horms.kernel.org> (raw)
In-Reply-To: <aMvVagz8aBRxMvFn@stanley.mountain>
On Thu, Sep 18, 2025 at 12:48:26PM +0300, Dan Carpenter wrote:
> This error handling triggers a Smatch warning:
>
> drivers/net/ethernet/ti/icssm/icssm_prueth.c:1574 icssm_prueth_probe()
> warn: 'prueth->pru1' is an error pointer or valid
>
> The warning is harmless because the pru_rproc_put() function has an
> IS_ERR_OR_NULL() check built in. However, there is a small bug if
> syscon_regmap_lookup_by_phandle() fails. In that case we should call
> of_node_put() on eth0_node and eth1_node.
>
> It's a little bit easier to re-write this code to only free things which
> we know have been allocated successfully.
>
> Fixes: 511f6c1ae093 ("net: ti: icssm-prueth: Adds ICSSM Ethernet driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Thanks Dan.
I'm pretty sure I reviewed this code at some point.
Sorry for not noticing this problem then.
Reviewed-by: Simon Horman <horms@kernel.org>
...
next prev parent reply other threads:[~2025-09-18 16:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-18 9:48 [PATCH net-next] net: ti: icssm-prueth: unwind cleanly in probe() Dan Carpenter
2025-09-18 16:27 ` Simon Horman [this message]
2025-09-19 14:04 ` Jakub Kicinski
2025-09-19 16:26 ` Parvathi Pudi
2025-09-20 0:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250918162756.GA394836@horms.kernel.org \
--to=horms@kernel.org \
--cc=afd@ti.com \
--cc=andrew+netdev@lunn.ch \
--cc=basharath@couthit.com \
--cc=dan.carpenter@linaro.org \
--cc=danishanwar@ti.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=parvathi@couthit.com \
--cc=pmohan@couthit.com \
--cc=rogerq@kernel.org \
--cc=rogerq@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.