From: Rob Herring <robh@kernel.org>
To: Eddie James <eajames@linux.ibm.com>
Cc: linux-aspeed@lists.ozlabs.org, devicetree@vger.kernel.org,
andrew@codeconstruct.com.au, conor+dt@kernel.org,
krzk+dt@kernel.org
Subject: Re: [PATCH v6 5/7] dt-bindings: hwmon: max31790: Document address and size cells
Date: Thu, 18 Sep 2025 18:01:29 -0500 [thread overview]
Message-ID: <20250918230129.GB3127900-robh@kernel.org> (raw)
In-Reply-To: <20250918180402.199373-6-eajames@linux.ibm.com>
On Thu, Sep 18, 2025 at 01:04:00PM -0500, Eddie James wrote:
> Since fan properties can include reg, the fan controller should be
> able to specify address-cells and size-cells properties.
>
> Signed-off-by: Eddie James <eajames@linux.ibm.com>
> ---
> Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml b/Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml
> index b2dc813b1ab44..42e7030360f1c 100644
> --- a/Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml
> @@ -35,6 +35,12 @@ properties:
> resets:
> maxItems: 1
>
> + '#address-cells':
> + const: 1
> +
> + '#size-cells':
> + const: 0
> +
As I explained, this is wrong if the child nodes don't have an address
and are named "fan-[0-9]" which they are.
> "#pwm-cells":
> const: 1
>
> --
> 2.51.0
>
next prev parent reply other threads:[~2025-09-18 23:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-18 18:03 [PATCH v6 0/7] ARM: dts: aspeed: Add Balcones system Eddie James
2025-09-18 18:03 ` [PATCH v6 1/7] dt-bindings: arm: aspeed: add IBM Balcones board Eddie James
2025-09-18 18:03 ` [PATCH v6 2/7] dt-bindings: arm: aspeed: add IBM Bonnell board Eddie James
2025-09-18 18:03 ` [PATCH v6 3/7] dt-bindings: iio: Add Infineon DPS310 sensor documentation Eddie James
2025-09-18 18:03 ` [PATCH v6 4/7] dt-bindings: hwmon: Move max31785 compatibles to max31790 document Eddie James
2025-09-18 18:04 ` [PATCH v6 5/7] dt-bindings: hwmon: max31790: Document address and size cells Eddie James
2025-09-18 23:01 ` Rob Herring [this message]
2025-09-18 18:04 ` [PATCH v6 6/7] ARM: dts: aspeed: Add Balcones system Eddie James
2025-09-18 18:04 ` [PATCH v6 7/7] ARM: dts: aspeed: Fix max31785 fan node naming Eddie James
2025-09-18 22:33 ` [PATCH v6 0/7] ARM: dts: aspeed: Add Balcones system Rob Herring (Arm)
2025-09-18 22:59 ` Rob Herring
2025-09-22 14:35 ` Eddie James
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250918230129.GB3127900-robh@kernel.org \
--to=robh@kernel.org \
--cc=andrew@codeconstruct.com.au \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eajames@linux.ibm.com \
--cc=krzk+dt@kernel.org \
--cc=linux-aspeed@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.