From: "Mickaël Salaün" <mic@digikod.net>
To: Tingmao Wang <m@maowtm.org>
Cc: "Günther Noack" <gnoack@google.com>, "Jan Kara" <jack@suse.cz>,
linux-security-module@vger.kernel.org
Subject: Re: [RFC PATCH 4/6] landlock/audit: Fix wrong type usage
Date: Fri, 19 Sep 2025 18:03:13 +0200 [thread overview]
Message-ID: <20250919.foh6Zea7ugie@digikod.net> (raw)
In-Reply-To: <ad6c155f38dda6ed31be1f1cbc6def6cdbd9769c.1757376311.git.m@maowtm.org>
On Tue, Sep 09, 2025 at 01:06:38AM +0100, Tingmao Wang wrote:
> I think, based on my best understanding, that this type is likely a typo
> (even though in the end both are u16)
>
> Signed-off-by: Tingmao Wang <m@maowtm.org>
Indeed, good catch!
You can add:
Fixes: 2fc80c69df82 ("landlock: Log file-related denials")
> ---
> security/landlock/audit.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/landlock/audit.c b/security/landlock/audit.c
> index 2b3edd1ab374..a67155c7f0c3 100644
> --- a/security/landlock/audit.c
> +++ b/security/landlock/audit.c
> @@ -191,7 +191,7 @@ static size_t get_denied_layer(const struct landlock_ruleset *const domain,
> long youngest_layer = -1;
>
> for_each_set_bit(access_bit, &access_req, layer_masks_size) {
> - const access_mask_t mask = (*layer_masks)[access_bit];
> + const layer_mask_t mask = (*layer_masks)[access_bit];
> long layer;
>
> if (!mask)
> --
> 2.51.0
>
>
next prev parent reply other threads:[~2025-09-19 16:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-09 0:06 [RFC PATCH 0/6] Implement LANDLOCK_ADD_RULE_QUIET Tingmao Wang
2025-09-09 0:06 ` [RFC PATCH 1/6] landlock: Add a place for flags to layer rules Tingmao Wang
2025-09-19 16:02 ` Mickaël Salaün
2025-09-21 23:52 ` Tingmao Wang
2025-09-24 9:20 ` Mickaël Salaün
2025-09-27 15:43 ` Tingmao Wang
2025-09-27 19:00 ` Mickaël Salaün
2025-09-27 23:12 ` Tingmao Wang
2025-09-09 0:06 ` [RFC PATCH 2/6] landlock: Add API support for the quiet flag Tingmao Wang
2025-09-19 16:02 ` Mickaël Salaün
2025-09-09 0:06 ` [RFC PATCH 3/6] landlock/audit: Check for quiet flag in landlock_log_denial Tingmao Wang
2025-09-19 16:02 ` Mickaël Salaün
2025-09-09 0:06 ` [RFC PATCH 4/6] landlock/audit: Fix wrong type usage Tingmao Wang
2025-09-19 16:03 ` Mickaël Salaün [this message]
2025-09-09 0:06 ` [RFC PATCH 5/6] landlock/access: Improve explanation on the deny_masks_t Tingmao Wang
2025-09-19 16:04 ` Mickaël Salaün
2025-09-21 23:52 ` Tingmao Wang
2025-09-09 0:06 ` [RFC PATCH 6/6] samples/landlock: Add FS quiet flag support to sandboxer Tingmao Wang
2025-09-19 16:01 ` [RFC PATCH 0/6] Implement LANDLOCK_ADD_RULE_QUIET Mickaël Salaün
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250919.foh6Zea7ugie@digikod.net \
--to=mic@digikod.net \
--cc=gnoack@google.com \
--cc=jack@suse.cz \
--cc=linux-security-module@vger.kernel.org \
--cc=m@maowtm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.