From: Eliav Farber <farbere@amazon.com>
To: <linux@armlinux.org.uk>, <jdike@addtoit.com>, <richard@nod.at>,
<anton.ivanov@cambridgegreys.com>, <dave.hansen@linux.intel.com>,
<luto@kernel.org>, <peterz@infradead.org>, <tglx@linutronix.de>,
<mingo@redhat.com>, <bp@alien8.de>, <x86@kernel.org>,
<hpa@zytor.com>, <tony.luck@intel.com>, <qiuxu.zhuo@intel.com>,
<mchehab@kernel.org>, <james.morse@arm.com>, <rric@kernel.org>,
<harry.wentland@amd.com>, <sunpeng.li@amd.com>,
<alexander.deucher@amd.com>, <christian.koenig@amd.com>,
<airlied@linux.ie>, <daniel@ffwll.ch>, <evan.quan@amd.com>,
<james.qian.wang@arm.com>, <liviu.dudau@arm.com>,
<mihail.atanassov@arm.com>, <brian.starkey@arm.com>,
<maarten.lankhorst@linux.intel.com>, <mripard@kernel.org>,
<tzimmermann@suse.de>, <robdclark@gmail.com>, <sean@poorly.run>,
<jdelvare@suse.com>, <linux@roeck-us.net>, <fery@cypress.com>,
<dmitry.torokhov@gmail.com>, <agk@redhat.com>,
<snitzer@redhat.com>, <dm-devel@redhat.com>, <rajur@chelsio.com>,
<davem@davemloft.net>, <kuba@kernel.org>,
<peppe.cavallaro@st.com>, <alexandre.torgue@st.com>,
<joabreu@synopsys.com>, <mcoquelin.stm32@gmail.com>,
<malattia@linux.it>, <hdegoede@redhat.com>,
<mgross@linux.intel.com>, <intel-linux-scu@intel.com>,
<artur.paszkiewicz@intel.com>, <jejb@linux.ibm.com>,
<martin.petersen@oracle.com>, <sakari.ailus@linux.intel.com>,
<gregkh@linuxfoundation.org>, <clm@fb.com>,
<josef@toxicpanda.com>, <dsterba@suse.com>, <jack@suse.com>,
<tytso@mit.edu>, <adilger.kernel@dilger.ca>, <dushistov@mail.ru>,
<luc.vanoostenryck@gmail.com>, <rostedt@goodmis.org>,
<pmladek@suse.com>, <sergey.senozhatsky@gmail.com>,
<andriy.shevchenko@linux.intel.com>, <linux@rasmusvillemoes.dk>,
<minchan@kernel.org>, <ngupta@vflare.org>,
<akpm@linux-foundation.org>, <kuznet@ms2.inr.ac.ru>,
<yoshfuji@linux-ipv6.org>, <pablo@netfilter.org>,
<kadlec@netfilter.org>, <fw@strlen.de>, <jmaloy@redhat.com>,
<ying.xue@windriver.com>, <willy@infradead.org>,
<farbere@amazon.com>, <sashal@kernel.org>,
<ruanjinjie@huawei.com>, <David.Laight@ACULAB.COM>,
<herve.codina@bootlin.com>, <Jason@zx2c4.com>,
<bvanassche@acm.org>, <keescook@chromium.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <linux-um@lists.infradead.org>,
<linux-edac@vger.kernel.org>, <amd-gfx@lists.freedesktop.org>,
<dri-devel@lists.freedesktop.org>,
<linux-arm-msm@vger.kernel.org>,
<freedreno@lists.freedesktop.org>, <linux-hwmon@vger.kernel.org>,
<linux-input@vger.kernel.org>, <linux-media@vger.kernel.org>,
<netdev@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
<platform-driver-x86@vger.kernel.org>,
<linux-scsi@vger.kernel.org>, <linux-staging@lists.linux.dev>,
<linux-btrfs@vger.kernel.org>, <linux-ext4@vger.kernel.org>,
<linux-sparse@vger.kernel.org>, <linux-mm@kvack.org>,
<netfilter-devel@vger.kernel.org>, <coreteam@netfilter.org>,
<tipc-discussion@lists.sourceforge.net>, <stable@vger.kernel.org>
Cc: <jonnyc@amazon.com>, Christoph Hellwig <hch@infradead.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: [PATCH 10/27 5.10.y] minmax: allow comparisons of 'int' against 'unsigned char/short'
Date: Fri, 19 Sep 2025 10:17:10 +0000 [thread overview]
Message-ID: <20250919101727.16152-11-farbere@amazon.com> (raw)
In-Reply-To: <20250919101727.16152-1-farbere@amazon.com>
From: David Laight <David.Laight@ACULAB.COM>
[ Upstream commit 4ead534fba42fc4fd41163297528d2aa731cd121 ]
Since 'unsigned char/short' get promoted to 'signed int' it is safe to
compare them against an 'int' value.
Link: https://lkml.kernel.org/r/8732ef5f809c47c28a7be47c938b28d4@AcuMS.aculab.com
Signed-off-by: David Laight <david.laight@aculab.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Jason A. Donenfeld <Jason@zx2c4.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Matthew Wilcox (Oracle) <willy@infradead.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Eliav Farber <farbere@amazon.com>
---
include/linux/minmax.h | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/include/linux/minmax.h b/include/linux/minmax.h
index c0e738eacefa..842c1db62ffe 100644
--- a/include/linux/minmax.h
+++ b/include/linux/minmax.h
@@ -26,8 +26,9 @@
__builtin_choose_expr(__is_constexpr(is_signed_type(typeof(x))), \
is_signed_type(typeof(x)), 0)
-#define __types_ok(x, y) \
- (__is_signed(x) == __is_signed(y))
+#define __types_ok(x, y) \
+ (__is_signed(x) == __is_signed(y) || \
+ __is_signed((x) + 0) == __is_signed((y) + 0))
#define __cmp_op_min <
#define __cmp_op_max >
--
2.47.3
next prev parent reply other threads:[~2025-09-21 9:02 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-19 10:17 [PATCH 00/27 5.10.y] Backport minmax.h updates from v6.17-rc6 Eliav Farber
2025-09-19 10:17 ` [PATCH 01/27 5.10.y] overflow, tracing: Define the is_signed_type() macro once Eliav Farber
2025-09-19 10:17 ` [PATCH 02/27 5.10.y] minmax: sanity check constant bounds when clamping Eliav Farber
2025-09-19 10:17 ` [PATCH 03/27 5.10.y] minmax: clamp more efficiently by avoiding extra comparison Eliav Farber
2025-09-19 10:17 ` [PATCH 04/27 5.10.y] minmax: add in_range() macro Eliav Farber
2025-09-22 13:10 ` Liviu Dudau
2025-09-19 10:17 ` [PATCH 05/27 5.10.y] minmax: Introduce {min,max}_array() Eliav Farber
2025-09-19 10:17 ` [PATCH 06/27 5.10.y] minmax: deduplicate __unconst_integer_typeof() Eliav Farber
2025-09-19 10:17 ` [PATCH 07/27 5.10.y] minmax: fix header inclusions Eliav Farber
2025-09-19 10:17 ` [PATCH 08/27 5.10.y] minmax: allow min()/max()/clamp() if the arguments have the same signedness Eliav Farber
2025-09-19 10:17 ` [PATCH 09/27 5.10.y] minmax: fix indentation of __cmp_once() and __clamp_once() Eliav Farber
2025-09-19 10:17 ` Eliav Farber [this message]
2025-09-19 10:17 ` [PATCH 11/27 5.10.y] minmax: relax check to allow comparison between unsigned arguments and signed constants Eliav Farber
2025-09-19 10:17 ` [PATCH 12/27 5.10.y] minmax: avoid overly complicated constant expressions in VM code Eliav Farber
2025-09-19 10:17 ` [PATCH 13/27 5.10.y] minmax: add a few more MIN_T/MAX_T users Eliav Farber
2025-09-19 10:17 ` [PATCH 14/27 5.10.y] minmax: simplify and clarify min_t()/max_t() implementation Eliav Farber
2025-09-19 10:17 ` [PATCH 15/27 5.10.y] minmax: make generic MIN() and MAX() macros available everywhere Eliav Farber
2025-09-19 10:17 ` [PATCH 16/27 5.10.y] lib: zstd: drop local MIN/MAX macros in favor of generic ones Eliav Farber
2025-09-19 10:17 ` [PATCH 17/27 5.10.y] minmax: don't use max() in situations that want a C constant expression Eliav Farber
2025-09-19 10:17 ` [PATCH 18/27 5.10.y] minmax: simplify min()/max()/clamp() implementation Eliav Farber
2025-09-19 10:17 ` [PATCH 19/27 5.10.y] minmax: improve macro expansion and type checking Eliav Farber
2025-09-19 10:17 ` [PATCH 20/27 5.10.y] minmax: fix up min3() and max3() too Eliav Farber
2025-09-19 10:17 ` [PATCH 21/27 5.10.y] minmax.h: add whitespace around operators and after commas Eliav Farber
2025-09-19 10:17 ` [PATCH 22/27 5.10.y] minmax.h: update some comments Eliav Farber
2025-09-19 10:17 ` [PATCH 23/27 5.10.y] minmax.h: reduce the #define expansion of min(), max() and clamp() Eliav Farber
2025-09-19 10:17 ` [PATCH 24/27 5.10.y] minmax.h: use BUILD_BUG_ON_MSG() for the lo < hi test in clamp() Eliav Farber
2025-09-19 10:17 ` [PATCH 25/27 5.10.y] minmax.h: move all the clamp() definitions after the min/max() ones Eliav Farber
2025-09-19 10:17 ` [PATCH 26/27 5.10.y] minmax.h: simplify the variants of clamp() Eliav Farber
2025-09-19 10:17 ` [PATCH 27/27 5.10.y] minmax.h: remove some #defines that are only expanded once Eliav Farber
2025-09-19 12:11 ` [PATCH 00/27 5.10.y] Backport minmax.h updates from v6.17-rc6 Christian König
2025-09-20 10:21 ` David Laight
2025-09-22 8:45 ` Christian König
2025-09-21 17:28 ` Greg KH
2025-09-21 21:37 ` Farber, Eliav
2025-09-22 5:02 ` Greg KH
2025-09-22 10:45 ` Farber, Eliav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250919101727.16152-11-farbere@amazon.com \
--to=farbere@amazon.com \
--cc=David.Laight@ACULAB.COM \
--cc=Jason@zx2c4.com \
--cc=adilger.kernel@dilger.ca \
--cc=agk@redhat.com \
--cc=airlied@linux.ie \
--cc=akpm@linux-foundation.org \
--cc=alexander.deucher@amd.com \
--cc=alexandre.torgue@st.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=anton.ivanov@cambridgegreys.com \
--cc=artur.paszkiewicz@intel.com \
--cc=bp@alien8.de \
--cc=brian.starkey@arm.com \
--cc=bvanassche@acm.org \
--cc=christian.koenig@amd.com \
--cc=clm@fb.com \
--cc=coreteam@netfilter.org \
--cc=daniel@ffwll.ch \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=dm-devel@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=dsterba@suse.com \
--cc=dushistov@mail.ru \
--cc=evan.quan@amd.com \
--cc=fery@cypress.com \
--cc=freedreno@lists.freedesktop.org \
--cc=fw@strlen.de \
--cc=gregkh@linuxfoundation.org \
--cc=harry.wentland@amd.com \
--cc=hch@infradead.org \
--cc=hdegoede@redhat.com \
--cc=herve.codina@bootlin.com \
--cc=hpa@zytor.com \
--cc=intel-linux-scu@intel.com \
--cc=jack@suse.com \
--cc=james.morse@arm.com \
--cc=james.qian.wang@arm.com \
--cc=jdelvare@suse.com \
--cc=jdike@addtoit.com \
--cc=jejb@linux.ibm.com \
--cc=jmaloy@redhat.com \
--cc=joabreu@synopsys.com \
--cc=jonnyc@amazon.com \
--cc=josef@toxicpanda.com \
--cc=kadlec@netfilter.org \
--cc=keescook@chromium.org \
--cc=kuba@kernel.org \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-sparse@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-um@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=linux@rasmusvillemoes.dk \
--cc=linux@roeck-us.net \
--cc=liviu.dudau@arm.com \
--cc=luc.vanoostenryck@gmail.com \
--cc=luto@kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=malattia@linux.it \
--cc=martin.petersen@oracle.com \
--cc=mchehab@kernel.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=mgross@linux.intel.com \
--cc=mihail.atanassov@arm.com \
--cc=minchan@kernel.org \
--cc=mingo@redhat.com \
--cc=mripard@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=ngupta@vflare.org \
--cc=pablo@netfilter.org \
--cc=peppe.cavallaro@st.com \
--cc=peterz@infradead.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=qiuxu.zhuo@intel.com \
--cc=rajur@chelsio.com \
--cc=richard@nod.at \
--cc=robdclark@gmail.com \
--cc=rostedt@goodmis.org \
--cc=rric@kernel.org \
--cc=ruanjinjie@huawei.com \
--cc=sakari.ailus@linux.intel.com \
--cc=sashal@kernel.org \
--cc=sean@poorly.run \
--cc=sergey.senozhatsky@gmail.com \
--cc=snitzer@redhat.com \
--cc=stable@vger.kernel.org \
--cc=sunpeng.li@amd.com \
--cc=tglx@linutronix.de \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=tony.luck@intel.com \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
--cc=tzimmermann@suse.de \
--cc=willy@infradead.org \
--cc=x86@kernel.org \
--cc=ying.xue@windriver.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.