Re: [PATCH 3/3] tune2fs: try to use the SET_TUNE_SB_PARAM ioctl on mounted file systems

["Theodore Ts'o" <tytso@mit.edu>]

On Thu, Sep 18, 2025 at 10:47:24AM -0700, Darrick J. Wong wrote:
> > -#else
> > -	return -1;
> 
> Shouldn't this still return 1 if this isn't being built on __linux__?
> 
> >  #endif
> > +	return 0;
> >  }

The calling convention for try_mounted_tune2fs() is to return -1 if
the caller should bail out and exit; and 0 if we should fall back to
modifying the block device thle old fashioned way.  So that's what
should happen if tune2fs is run on FreeBSD or GNU Hurd.

I'll add a comment documenting this.

> > +	if (get_mount_flags() < 0 || try_mounted_tune2fs() << 0) {
> 
> Why shift left here                                        ^^ ??

Whoops, typo that should have been < 0.

		     	  	      	     - Ted