From: kernel test robot <lkp@intel.com>
To: David Howells <dhowells@redhat.com>, Eric Biggers <ebiggers@kernel.org>
Cc: oe-kbuild-all@lists.linux.dev, dhowells@redhat.com,
"Jason A. Donenfeld" <Jason@zx2c4.com>,
Ard Biesheuvel <ardb@kernel.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
Stephan Mueller <smueller@chronox.de>,
linux-crypto@vger.kernel.org, keyrings@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lib/crypto: Add SHA3-224, SHA3-256, SHA3-384, SHA-512, SHAKE128, SHAKE256
Date: Fri, 19 Sep 2025 18:20:31 +0800 [thread overview]
Message-ID: <202509191807.9daDknje-lkp@intel.com> (raw)
In-Reply-To: <3605112.1758233248@warthog.procyon.org.uk>
Hi David,
kernel test robot noticed the following build errors:
[auto build test ERROR on ebiggers/libcrypto-fixes]
[also build test ERROR on herbert-cryptodev-2.6/master herbert-crypto-2.6/master linus/master v6.17-rc6 next-20250918]
[cannot apply to ebiggers/libcrypto-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/David-Howells/lib-crypto-Add-SHA3-224-SHA3-256-SHA3-384-SHA-512-SHAKE128-SHAKE256/20250919-061024
base: https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git libcrypto-fixes
patch link: https://lore.kernel.org/r/3605112.1758233248%40warthog.procyon.org.uk
patch subject: [PATCH] lib/crypto: Add SHA3-224, SHA3-256, SHA3-384, SHA-512, SHAKE128, SHAKE256
config: s390-randconfig-001-20250919 (https://download.01.org/0day-ci/archive/20250919/202509191807.9daDknje-lkp@intel.com/config)
compiler: s390-linux-gcc (GCC) 8.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250919/202509191807.9daDknje-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202509191807.9daDknje-lkp@intel.com/
All errors (new ones prefixed by >>):
>> arch/s390/crypto/sha3_256_s390.c:22:12: error: conflicting types for 'sha3_256_init'
static int sha3_256_init(struct shash_desc *desc)
^~~~~~~~~~~~~
In file included from arch/s390/crypto/sha3_256_s390.c:13:
include/crypto/sha3.h:71:20: note: previous definition of 'sha3_256_init' was here
static inline void sha3_256_init(struct sha3_ctx *ctx)
^~~~~~~~~~~~~
>> arch/s390/crypto/sha3_256_s390.c:99:12: error: conflicting types for 'sha3_224_init'
static int sha3_224_init(struct shash_desc *desc)
^~~~~~~~~~~~~
In file included from arch/s390/crypto/sha3_256_s390.c:13:
include/crypto/sha3.h:59:20: note: previous definition of 'sha3_224_init' was here
static inline void sha3_224_init(struct sha3_ctx *ctx)
^~~~~~~~~~~~~
vim +/sha3_256_init +22 arch/s390/crypto/sha3_256_s390.c
3c2eb6b76cabb7 Joerg Schmidbauer 2019-08-14 21
3c2eb6b76cabb7 Joerg Schmidbauer 2019-08-14 @22 static int sha3_256_init(struct shash_desc *desc)
3c2eb6b76cabb7 Joerg Schmidbauer 2019-08-14 23 {
3c2eb6b76cabb7 Joerg Schmidbauer 2019-08-14 24 struct s390_sha_ctx *sctx = shash_desc_ctx(desc);
3c2eb6b76cabb7 Joerg Schmidbauer 2019-08-14 25
6f90ba7065515d Herbert Xu 2025-04-18 26 sctx->first_message_part = test_facility(86);
6f90ba7065515d Herbert Xu 2025-04-18 27 if (!sctx->first_message_part)
3c2eb6b76cabb7 Joerg Schmidbauer 2019-08-14 28 memset(sctx->state, 0, sizeof(sctx->state));
3c2eb6b76cabb7 Joerg Schmidbauer 2019-08-14 29 sctx->count = 0;
3c2eb6b76cabb7 Joerg Schmidbauer 2019-08-14 30 sctx->func = CPACF_KIMD_SHA3_256;
3c2eb6b76cabb7 Joerg Schmidbauer 2019-08-14 31
3c2eb6b76cabb7 Joerg Schmidbauer 2019-08-14 32 return 0;
3c2eb6b76cabb7 Joerg Schmidbauer 2019-08-14 33 }
3c2eb6b76cabb7 Joerg Schmidbauer 2019-08-14 34
3c2eb6b76cabb7 Joerg Schmidbauer 2019-08-14 35 static int sha3_256_export(struct shash_desc *desc, void *out)
3c2eb6b76cabb7 Joerg Schmidbauer 2019-08-14 36 {
3c2eb6b76cabb7 Joerg Schmidbauer 2019-08-14 37 struct s390_sha_ctx *sctx = shash_desc_ctx(desc);
73c2437109c3ea Herbert Xu 2025-05-23 38 union {
73c2437109c3ea Herbert Xu 2025-05-23 39 u8 *u8;
73c2437109c3ea Herbert Xu 2025-05-23 40 u64 *u64;
73c2437109c3ea Herbert Xu 2025-05-23 41 } p = { .u8 = out };
73c2437109c3ea Herbert Xu 2025-05-23 42 int i;
3c2eb6b76cabb7 Joerg Schmidbauer 2019-08-14 43
6f90ba7065515d Herbert Xu 2025-04-18 44 if (sctx->first_message_part) {
73c2437109c3ea Herbert Xu 2025-05-23 45 memset(out, 0, SHA3_STATE_SIZE);
73c2437109c3ea Herbert Xu 2025-05-23 46 return 0;
6f90ba7065515d Herbert Xu 2025-04-18 47 }
73c2437109c3ea Herbert Xu 2025-05-23 48 for (i = 0; i < SHA3_STATE_SIZE / 8; i++)
73c2437109c3ea Herbert Xu 2025-05-23 49 put_unaligned(le64_to_cpu(sctx->sha3.state[i]), p.u64++);
3c2eb6b76cabb7 Joerg Schmidbauer 2019-08-14 50 return 0;
3c2eb6b76cabb7 Joerg Schmidbauer 2019-08-14 51 }
3c2eb6b76cabb7 Joerg Schmidbauer 2019-08-14 52
3c2eb6b76cabb7 Joerg Schmidbauer 2019-08-14 53 static int sha3_256_import(struct shash_desc *desc, const void *in)
3c2eb6b76cabb7 Joerg Schmidbauer 2019-08-14 54 {
3c2eb6b76cabb7 Joerg Schmidbauer 2019-08-14 55 struct s390_sha_ctx *sctx = shash_desc_ctx(desc);
73c2437109c3ea Herbert Xu 2025-05-23 56 union {
73c2437109c3ea Herbert Xu 2025-05-23 57 const u8 *u8;
73c2437109c3ea Herbert Xu 2025-05-23 58 const u64 *u64;
73c2437109c3ea Herbert Xu 2025-05-23 59 } p = { .u8 = in };
73c2437109c3ea Herbert Xu 2025-05-23 60 int i;
3c2eb6b76cabb7 Joerg Schmidbauer 2019-08-14 61
73c2437109c3ea Herbert Xu 2025-05-23 62 for (i = 0; i < SHA3_STATE_SIZE / 8; i++)
73c2437109c3ea Herbert Xu 2025-05-23 63 sctx->sha3.state[i] = cpu_to_le64(get_unaligned(p.u64++));
6f90ba7065515d Herbert Xu 2025-04-18 64 sctx->count = 0;
6f90ba7065515d Herbert Xu 2025-04-18 65 sctx->first_message_part = 0;
3c2eb6b76cabb7 Joerg Schmidbauer 2019-08-14 66 sctx->func = CPACF_KIMD_SHA3_256;
3c2eb6b76cabb7 Joerg Schmidbauer 2019-08-14 67
3c2eb6b76cabb7 Joerg Schmidbauer 2019-08-14 68 return 0;
3c2eb6b76cabb7 Joerg Schmidbauer 2019-08-14 69 }
3c2eb6b76cabb7 Joerg Schmidbauer 2019-08-14 70
3c2eb6b76cabb7 Joerg Schmidbauer 2019-08-14 71 static int sha3_224_import(struct shash_desc *desc, const void *in)
3c2eb6b76cabb7 Joerg Schmidbauer 2019-08-14 72 {
3c2eb6b76cabb7 Joerg Schmidbauer 2019-08-14 73 struct s390_sha_ctx *sctx = shash_desc_ctx(desc);
3c2eb6b76cabb7 Joerg Schmidbauer 2019-08-14 74
6f90ba7065515d Herbert Xu 2025-04-18 75 sha3_256_import(desc, in);
3c2eb6b76cabb7 Joerg Schmidbauer 2019-08-14 76 sctx->func = CPACF_KIMD_SHA3_224;
3c2eb6b76cabb7 Joerg Schmidbauer 2019-08-14 77 return 0;
3c2eb6b76cabb7 Joerg Schmidbauer 2019-08-14 78 }
3c2eb6b76cabb7 Joerg Schmidbauer 2019-08-14 79
3c2eb6b76cabb7 Joerg Schmidbauer 2019-08-14 80 static struct shash_alg sha3_256_alg = {
3c2eb6b76cabb7 Joerg Schmidbauer 2019-08-14 81 .digestsize = SHA3_256_DIGEST_SIZE, /* = 32 */
3c2eb6b76cabb7 Joerg Schmidbauer 2019-08-14 82 .init = sha3_256_init,
6f90ba7065515d Herbert Xu 2025-04-18 83 .update = s390_sha_update_blocks,
6f90ba7065515d Herbert Xu 2025-04-18 84 .finup = s390_sha_finup,
3c2eb6b76cabb7 Joerg Schmidbauer 2019-08-14 85 .export = sha3_256_export,
3c2eb6b76cabb7 Joerg Schmidbauer 2019-08-14 86 .import = sha3_256_import,
6f90ba7065515d Herbert Xu 2025-04-18 87 .descsize = S390_SHA_CTX_SIZE,
6f90ba7065515d Herbert Xu 2025-04-18 88 .statesize = SHA3_STATE_SIZE,
3c2eb6b76cabb7 Joerg Schmidbauer 2019-08-14 89 .base = {
3c2eb6b76cabb7 Joerg Schmidbauer 2019-08-14 90 .cra_name = "sha3-256",
3c2eb6b76cabb7 Joerg Schmidbauer 2019-08-14 91 .cra_driver_name = "sha3-256-s390",
3c2eb6b76cabb7 Joerg Schmidbauer 2019-08-14 92 .cra_priority = 300,
6f90ba7065515d Herbert Xu 2025-04-18 93 .cra_flags = CRYPTO_AHASH_ALG_BLOCK_ONLY,
3c2eb6b76cabb7 Joerg Schmidbauer 2019-08-14 94 .cra_blocksize = SHA3_256_BLOCK_SIZE,
3c2eb6b76cabb7 Joerg Schmidbauer 2019-08-14 95 .cra_module = THIS_MODULE,
3c2eb6b76cabb7 Joerg Schmidbauer 2019-08-14 96 }
3c2eb6b76cabb7 Joerg Schmidbauer 2019-08-14 97 };
3c2eb6b76cabb7 Joerg Schmidbauer 2019-08-14 98
3c2eb6b76cabb7 Joerg Schmidbauer 2019-08-14 @99 static int sha3_224_init(struct shash_desc *desc)
3c2eb6b76cabb7 Joerg Schmidbauer 2019-08-14 100 {
3c2eb6b76cabb7 Joerg Schmidbauer 2019-08-14 101 struct s390_sha_ctx *sctx = shash_desc_ctx(desc);
3c2eb6b76cabb7 Joerg Schmidbauer 2019-08-14 102
6f90ba7065515d Herbert Xu 2025-04-18 103 sha3_256_init(desc);
3c2eb6b76cabb7 Joerg Schmidbauer 2019-08-14 104 sctx->func = CPACF_KIMD_SHA3_224;
3c2eb6b76cabb7 Joerg Schmidbauer 2019-08-14 105 return 0;
3c2eb6b76cabb7 Joerg Schmidbauer 2019-08-14 106 }
3c2eb6b76cabb7 Joerg Schmidbauer 2019-08-14 107
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2025-09-19 10:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-18 22:07 [PATCH] lib/crypto: Add SHA3-224, SHA3-256, SHA3-384, SHA-512, SHAKE128, SHAKE256 David Howells
2025-09-19 2:42 ` Stephan Müller
2025-09-19 6:17 ` David Howells
2025-09-19 13:59 ` Simo Sorce
2025-09-19 15:34 ` David Howells
2025-09-19 15:40 ` Stephan Müller
2025-09-19 10:10 ` kernel test robot
2025-09-19 10:20 ` kernel test robot [this message]
2025-09-19 11:33 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202509191807.9daDknje-lkp@intel.com \
--to=lkp@intel.com \
--cc=Jason@zx2c4.com \
--cc=ardb@kernel.org \
--cc=dhowells@redhat.com \
--cc=ebiggers@kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=keyrings@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=smueller@chronox.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.