From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Julien Olivain <ju.o@free.fr>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] support/scripts/gen-bootlin-toolchains: avoid selecting _HAS_THREADS multiple times
Date: Sun, 21 Sep 2025 18:50:34 +0200 [thread overview]
Message-ID: <20250921185034.7025c654@windsurf> (raw)
In-Reply-To: <20250921161721.2070176-1-ju.o@free.fr>
On Sun, 21 Sep 2025 18:17:21 +0200
Julien Olivain <ju.o@free.fr> wrote:
> The Bootlin external toolchain file Config.in.options contains multiple
> occurrences of "select BR2_TOOLCHAIN_HAS_THREADS". See for example [1].
>
> This file is generated by the support/scripts/gen-bootlin-toolchains
> script from the information published at [2].
>
> Those multiple occurrences happens with toolchains having
> BR2_TOOLCHAIN_HAS_THREADS_DEBUG and/or BR2_TOOLCHAIN_HAS_THREADS_NPTL.
>
> Since the script uses the startswith() method, the _HAS_THREADS
> selection is also generated for _HAS_THREADS_DEBUG and
> _HAS_THREADS_NPTL. See [3].
>
> This commit solve the issue by adding a '=' character to make sure the
> test will be distinct from other strings having the same prefix.
>
> Note: there is no functional problem due to those multiple selections,
> since it is allowed by Kconfig. This commit is simply cosmetic, for
> correctness.
>
> [1] https://gitlab.com/buildroot.org/buildroot/-/blob/2025.08/toolchain/toolchain-external/toolchain-external-bootlin/Config.in.options#L167
> [2] https://toolchains.bootlin.com/
> [3] https://gitlab.com/buildroot.org/buildroot/-/blob/2025.08/support/scripts/gen-bootlin-toolchains#L366
>
> Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> Signed-off-by: Julien Olivain <ju.o@free.fr>
Acked-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Thanks a lot!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2025-09-21 16:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-21 16:17 [Buildroot] [PATCH 1/1] support/scripts/gen-bootlin-toolchains: avoid selecting _HAS_THREADS multiple times Julien Olivain via buildroot
2025-09-21 16:50 ` Thomas Petazzoni via buildroot [this message]
2025-09-21 19:24 ` Julien Olivain via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250921185034.7025c654@windsurf \
--to=buildroot@buildroot.org \
--cc=ju.o@free.fr \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.