All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Alok Tiwari <alok.a.tiwari@oracle.com>
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev
Subject: Re: [PATCH RFC] PCI: Convert devm_pci_alloc_host_bridge() users to error-pointer returns
Date: Mon, 22 Sep 2025 03:50:44 +0800	[thread overview]
Message-ID: <202509220322.JzCVMkDb-lkp@intel.com> (raw)
In-Reply-To: <20250921161434.1561770-1-alok.a.tiwari@oracle.com>

Hi Alok,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build errors:

[auto build test ERROR on pci/for-linus]
[also build test ERROR on linus/master v6.17-rc6]
[cannot apply to pci/next next-20250919]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Alok-Tiwari/PCI-Convert-devm_pci_alloc_host_bridge-users-to-error-pointer-returns/20250922-001734
base:   https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git for-linus
patch link:    https://lore.kernel.org/r/20250921161434.1561770-1-alok.a.tiwari%40oracle.com
patch subject: [PATCH RFC] PCI: Convert devm_pci_alloc_host_bridge() users to error-pointer returns
config: um-randconfig-002-20250922 (https://download.01.org/0day-ci/archive/20250922/202509220322.JzCVMkDb-lkp@intel.com/config)
compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project efd96afedf2c0f6f2cc34cf5a9a7e3e78f592255)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250922/202509220322.JzCVMkDb-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202509220322.JzCVMkDb-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from drivers/pci/controller/pcie-mediatek-gen3.c:13:
   In file included from include/linux/iopoll.h:14:
   In file included from include/linux/io.h:12:
   In file included from arch/um/include/asm/io.h:24:
   include/asm-generic/io.h:1175:55: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
    1175 |         return (port > MMIO_UPPER_LIMIT) ? NULL : PCI_IOBASE + port;
         |                                                   ~~~~~~~~~~ ^
>> drivers/pci/controller/pcie-mediatek-gen3.c:1178:21: error: use of undeclared identifier 'bridge'
    1178 |         if (IS_ERR_OR_NULL(bridge))
         |                            ^~~~~~
   drivers/pci/controller/pcie-mediatek-gen3.c:1179:18: error: use of undeclared identifier 'bridge'
    1179 |                 return PTR_ERR(bridge);
         |                                ^~~~~~
   1 warning and 2 errors generated.
--
   In file included from drivers/pci/controller/pci-tegra.c:21:
   In file included from include/linux/interrupt.h:11:
   In file included from include/linux/hardirq.h:11:
   In file included from arch/um/include/asm/hardirq.h:5:
   In file included from include/asm-generic/hardirq.h:17:
   In file included from include/linux/irq.h:20:
   In file included from include/linux/io.h:12:
   In file included from arch/um/include/asm/io.h:24:
   include/asm-generic/io.h:1175:55: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
    1175 |         return (port > MMIO_UPPER_LIMIT) ? NULL : PCI_IOBASE + port;
         |                                                   ~~~~~~~~~~ ^
>> drivers/pci/controller/pci-tegra.c:2571:21: error: use of undeclared identifier 'bridge'
    2571 |         if (IS_ERR_OR_NULL(bridge))
         |                            ^~~~~~
   drivers/pci/controller/pci-tegra.c:2572:18: error: use of undeclared identifier 'bridge'
    2572 |                 return PTR_ERR(bridge);
         |                                ^~~~~~
   1 warning and 2 errors generated.


vim +/bridge +1178 drivers/pci/controller/pcie-mediatek-gen3.c

  1169	
  1170	static int mtk_pcie_probe(struct platform_device *pdev)
  1171	{
  1172		struct device *dev = &pdev->dev;
  1173		struct mtk_gen3_pcie *pcie;
  1174		struct pci_host_bridge *host;
  1175		int err;
  1176	
  1177		host = devm_pci_alloc_host_bridge(dev, sizeof(*pcie));
> 1178		if (IS_ERR_OR_NULL(bridge))
  1179			return PTR_ERR(bridge);
  1180	
  1181		pcie = pci_host_bridge_priv(host);
  1182	
  1183		pcie->dev = dev;
  1184		pcie->soc = device_get_match_data(dev);
  1185		platform_set_drvdata(pdev, pcie);
  1186	
  1187		err = mtk_pcie_setup(pcie);
  1188		if (err)
  1189			return err;
  1190	
  1191		host->ops = &mtk_pcie_ops;
  1192		host->sysdata = pcie;
  1193	
  1194		err = pci_host_probe(host);
  1195		if (err) {
  1196			mtk_pcie_irq_teardown(pcie);
  1197			mtk_pcie_power_down(pcie);
  1198			return err;
  1199		}
  1200	
  1201		return 0;
  1202	}
  1203	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

  parent reply	other threads:[~2025-09-21 19:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-21 16:14 [PATCH RFC] PCI: Convert devm_pci_alloc_host_bridge() users to error-pointer returns Alok Tiwari
2025-09-21 16:14 ` Alok Tiwari
2025-09-21 17:19 ` Marc Zyngier
2025-09-21 17:19   ` Marc Zyngier
2025-09-21 19:50 ` kernel test robot [this message]
2025-09-22 10:55 ` AngeloGioacchino Del Regno
2025-09-22 10:55   ` AngeloGioacchino Del Regno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202509220322.JzCVMkDb-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=alok.a.tiwari@oracle.com \
    --cc=llvm@lists.linux.dev \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.