All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luis Chamberlain <mcgrof@kernel.org>
To: Chuck Lever <cel@kernel.org>, Daniel Gomez <da.gomez@kruces.com>,
	kdevops@lists.linux.dev
Cc: Luis Chamberlain <mcgrof@kernel.org>
Subject: [PATCH 09/13] nfsd_add_export: fix become method for filesystem formatting
Date: Mon, 22 Sep 2025 02:36:51 -0700	[thread overview]
Message-ID: <20250922093656.2361016-10-mcgrof@kernel.org> (raw)
In-Reply-To: <20250922093656.2361016-1-mcgrof@kernel.org>

The filesystem module was unable to find mkfs.xfs when using
'become_flags: "su - -c"' which changes the environment.
Change to use standard 'become_method: sudo' to preserve
the PATH and allow the module to find the mkfs.xfs executable.

Generated-by: Claude AI
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
---
 playbooks/roles/nfsd_add_export/tasks/storage/local.yml | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/playbooks/roles/nfsd_add_export/tasks/storage/local.yml b/playbooks/roles/nfsd_add_export/tasks/storage/local.yml
index c366a13f..aaaf1de1 100644
--- a/playbooks/roles/nfsd_add_export/tasks/storage/local.yml
+++ b/playbooks/roles/nfsd_add_export/tasks/storage/local.yml
@@ -11,8 +11,7 @@
 
 - name: Format new volume for {{ export_fstype }}
   become: true
-  become_flags: "su - -c"
-  become_method: ansible.builtin.sudo
+  become_method: sudo
   delegate_to: "{{ server_host }}"
   community.general.filesystem:
     fstype: "{{ export_fstype }}"
-- 
2.51.0


  parent reply	other threads:[~2025-09-22  9:36 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-22  9:36 [PATCH 00/13] nfs: few fixes and enhancements Luis Chamberlain
2025-09-22  9:36 ` [PATCH 01/13] defconfigs: add NFS testing configurations Luis Chamberlain
2025-09-22  9:36 ` [PATCH 02/13] devconfig: exclude nfsd from journal upload client configuration Luis Chamberlain
2025-09-22  9:36 ` [PATCH 03/13] iscsi: add missing initiator packages for Debian Luis Chamberlain
2025-09-22  9:36 ` [PATCH 04/13] fstests: fix pNFS block layout iSCSI setup Luis Chamberlain
2025-09-22  9:36 ` [PATCH 05/13] nfsd/fstests: fix pNFS block layout iSCSI configuration Luis Chamberlain
2025-09-22  9:36 ` [PATCH 06/13] fstests: set up iSCSI target on NFS server before test nodes Luis Chamberlain
2025-09-22  9:36 ` [PATCH 07/13] fstests: move conditional to play level for iSCSI setup Luis Chamberlain
2025-09-22  9:36 ` [PATCH 08/13] fstests: temporarily disable iSCSI setup for pNFS Luis Chamberlain
2025-09-22  9:36 ` Luis Chamberlain [this message]
2025-09-22  9:36 ` [PATCH 10/13] workflows: fstests: fix incorrect pNFS export configuration Luis Chamberlain
2025-09-22  9:36 ` [PATCH 11/13] nfstest: add results visualization support Luis Chamberlain
2025-09-22  9:36 ` [PATCH 12/13] fstests: add soak duration to nfs template Luis Chamberlain
2025-09-22  9:36 ` [PATCH 13/13] pynfs: add visualization support for test results Luis Chamberlain
2025-09-22  9:46 ` [PATCH 00/13] nfs: few fixes and enhancements Luis Chamberlain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250922093656.2361016-10-mcgrof@kernel.org \
    --to=mcgrof@kernel.org \
    --cc=cel@kernel.org \
    --cc=da.gomez@kruces.com \
    --cc=kdevops@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.