RE: [PATCH] tools/mm/slabinfo: fix buffer overflows in fread operations

[SeongJae Park <sj@kernel.org>]

On Mon, 22 Sep 2025 02:40:11 +0000 "Kumar, Kaushlendra" <kaushlendra.kumar@intel.com> wrote:

> On Fri, 29 Aug 2025, SeongJae Park wrote:
> > On Fri, 29 Aug 2025 15:29:47 +0530 Kaushlendra Kumar <kaushlendra.kumar@intel.com> wrote:
> > 
> > > The fread() calls in read_slab_obj() and read_debug_slab_obj() can 
> > > read up to sizeof(buffer) bytes, but then unconditionally write a null 
> > > terminator at buffer[l]. If fread() returns sizeof(buffer), this 
> > > writes beyond the allocated buffer boundaries.
> > > 
> > > Fix by limiting reads to sizeof(buffer) - 1 bytes in both functions, 
> > > ensuring space is always reserved for null termination. This prevents 
> > > buffer overflows while maintaining proper string handling.
> > > 
> > > Signed-off-by: Kaushlendra Kumar <kaushlendra.kumar@intel.com>
> > 
> > Acked-by: SeongJae Park <sj@kernel.org>
> > 
> > 
> > Thanks,
> > SJ
> 
> Hi SeongJae,
> 
> Thank you for the Acked-by! 
> 
> Since this patch has received your acknowledgment, are we going to merge this 
> patch? Should I expect it to be picked up for the next kernel release, or 
> are there any additional steps needed from my side?

I'm not a maintainer or a reviewr of slabinfo, so my Acked-by: doesn't mean
many things.  I think the next steps and decisions are up to Andrew.

And I think Andrew should be busy for the preparation of the next merge window.
I'd suggest pinging Andrew again, after the next MM pull requests for 6.18-rc1
are done.


Thanks,
SJ

[...]