All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Maurizio Lombardi <mlombard@redhat.com>
Cc: kbusch@kernel.org, hch@lst.de, sagi@grimberg.me, hare@suse.de,
	mlombard@bsdbackstore.eu, linux-nvme@lists.infradead.org
Subject: Re: [PATCH RFC 1/1] nvme-core: register namespaces in order during async scan
Date: Mon, 22 Sep 2025 19:30:33 +0200	[thread overview]
Message-ID: <20250922173033.GA13802@lst.de> (raw)
In-Reply-To: <20250804114355.30212-2-mlombard@redhat.com>

This idea looks fine to me, but I hate duplicating the logic
from SCSI here.  Any chance you could try to factor the logic
into a common helper?


> +	struct async_scan_task *task = kzalloc(sizeof(*task), GFP_KERNEL);
> +	if (!task)

Always keep an empty line after function declarations.



  reply	other threads:[~2025-09-22 17:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-04 11:43 [PATCH RFC 0/1] Ensure ordered namespace registration during async scan Maurizio Lombardi
2025-08-04 11:43 ` [PATCH RFC 1/1] nvme-core: register namespaces in order " Maurizio Lombardi
2025-09-22 17:30   ` Christoph Hellwig [this message]
2025-09-26  8:43     ` Maurizio Lombardi
2025-10-03 10:14       ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250922173033.GA13802@lst.de \
    --to=hch@lst.de \
    --cc=hare@suse.de \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=mlombard@bsdbackstore.eu \
    --cc=mlombard@redhat.com \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.