From: Christoph Hellwig <hch@lst.de>
To: Max Gurtovoy <mgurtovoy@nvidia.com>
Cc: hch@lst.de, linux-nvme@lists.infradead.org, kbusch@kernel.org,
sagi@grimberg.me, kch@nvidia.com, israelr@nvidia.com
Subject: Re: [PATCH v2 1/1] nvmet: add safety check for subsys lock
Date: Mon, 22 Sep 2025 19:36:29 +0200 [thread overview]
Message-ID: <20250922173629.GA14701@lst.de> (raw)
In-Reply-To: <20250921124405.30432-1-mgurtovoy@nvidia.com>
On Sun, Sep 21, 2025 at 03:44:05PM +0300, Max Gurtovoy wrote:
> Replace comment about required lock with a lockdep_assert_held()
> check in the following functions:
> - nvmet_p2pmem_ns_add_p2p()
> - nvmet_setup_p2p_ns_map()
> - nvmet_release_p2p_ns_map()
>
> This ensures the subsystem lock is held at runtime.
Only if you enabled lockdep :)
But this still looks useful, so:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2025-09-22 17:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-21 12:44 [PATCH v2 1/1] nvmet: add safety check for subsys lock Max Gurtovoy
2025-09-22 17:36 ` Christoph Hellwig [this message]
2025-09-22 20:24 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250922173629.GA14701@lst.de \
--to=hch@lst.de \
--cc=israelr@nvidia.com \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=linux-nvme@lists.infradead.org \
--cc=mgurtovoy@nvidia.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.