From: Jakub Kicinski <kuba@kernel.org>
To: I Viswanath <viswanathiyyappan@gmail.com>
Cc: andrew@lunn.ch, andrew+netdev@lunn.ch, davem@davemloft.net,
david.hunter.linux@gmail.com, edumazet@google.com,
linux-kernel-mentees@lists.linux.dev,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
netdev@vger.kernel.org, pabeni@redhat.com, petkan@nucleusys.com,
skhan@linuxfoundation.org,
syzbot+78cae3f37c62ad092caa@syzkaller.appspotmail.com
Subject: Re: [PATCH net v2] net: usb: Remove disruptive netif_wake_queue in rtl8150_set_multicast
Date: Mon, 22 Sep 2025 18:07:42 -0700 [thread overview]
Message-ID: <20250922180742.6ef6e2d5@kernel.org> (raw)
In-Reply-To: <20250920181852.18164-1-viswanathiyyappan@gmail.com>
On Sat, 20 Sep 2025 23:48:52 +0530 I Viswanath wrote:
> rtl8150_set_multicast is rtl8150's implementation of ndo_set_rx_mode and
> should not be calling netif_stop_queue and notif_start_queue as these handle
> TX queue synchronization.
>
> The net core function dev_set_rx_mode handles the synchronization
> for rtl8150_set_multicast making it safe to remove these locks.
Last time someone tried to add device ID to this driver was 20 years
ago. Please post a patch to delete this driver completely. If someone
speaks up we'll revert the removal and ask them to test the fix.
--
pw-bot: cr
next prev parent reply other threads:[~2025-09-23 1:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-20 4:50 [PATCH] net: usb: Remove disruptive netif_wake_queue in rtl8150_set_multicast I Viswanath
2025-09-20 15:30 ` Andrew Lunn
2025-09-20 16:52 ` viswanath
2025-09-20 17:28 ` Andrew Lunn
2025-09-20 18:18 ` [PATCH net v2] " I Viswanath
2025-09-23 1:07 ` Jakub Kicinski [this message]
2025-09-23 7:47 ` Michal Pecio
2025-09-23 14:28 ` Jakub Kicinski
2025-09-23 23:20 ` Michal Pecio
2025-09-23 23:37 ` Jakub Kicinski
2025-09-25 5:59 ` Deepak Sharma
2025-09-24 7:47 ` Michal Pecio
2025-09-24 8:02 ` viswanath
2025-09-24 9:36 ` Michal Pecio
2025-09-24 10:25 ` viswanath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250922180742.6ef6e2d5@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=david.hunter.linux@gmail.com \
--cc=edumazet@google.com \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petkan@nucleusys.com \
--cc=skhan@linuxfoundation.org \
--cc=syzbot+78cae3f37c62ad092caa@syzkaller.appspotmail.com \
--cc=viswanathiyyappan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.