Re: [PATCH] rust: print: Fix issue with rust_build_error

[Joel Fernandes <joelagnelf@nvidia.com>]

On Sun, Sep 21, 2025 at 11:13:11AM +0200, Miguel Ojeda wrote:
> On Sun, Sep 21, 2025 at 2:45 AM Joel Fernandes <joelagnelf@nvidia.com> wrote:
> >
> > But even if the pointer is a C const pointer, LLVM seems to
> > always want to reload it.
> 
> What do you mean by this? I think I mentioned in the other thread that
> a C pointer to const still allows the callee to change the value.

Apologies, indeed a const pointer in C does not mean the pointee cannot be
modified.

I think I somewhat understand the issue but still not fully. MIR optimization
is supposed to optimize away the dead code in build_assert. This is what I
see for "good" cases when things work.

But the information that the data being printed is an immutable reference, is
lost somehow during MIR optimization phase when a printk is involved.  Per the
github issue [1], there is likely some provenance information in the immutable
reference to the data, that gets lost during "MIR inlining" optimization. In
other words, this is not an LLVM problem as I was pointing out, but an MIR
optimization problem.  Benno/Gary correct me anything I said is wrong.

I guess I still have a few more questions:

1. What is being inlined when we talk about MIR inlining? The print
statement? Constructor to the Argument object? Something else?

2. What does 'noalias' mean in the github report [1], and why would that effect
'MIR inlining'?

3. Why does LLVM inlining still succeed when MIR inlining is disabled? This
has something to do with a new llvm feature Niki referred to in the report.

thanks,

 - Joel
[1] https://github.com/rust-lang/rust/issues/146844