Re: [RFC PATCH] ARM: dts: renesas: r9a06g032-rzn1d400-eb: describe LEDs

[Rob Herring <robh@kernel.org>]

On Fri, Sep 19, 2025 at 12:07:20PM +0200, Wolfram Sang wrote:
> To be able to use the LEDs, a configuration switch has to be set to a
> non-default value. So, infrastructure to support these switches (which
> modify signal routing via the CPLD on the demo board (DB)) is added as
> well.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> 
> This patch depends on "[PATCH v3 5/8] ARM: dts: r9a06g032: Add GPIO
> controllers" which is still in-flight. I send this out as RFC already,
> so we can discuss the introduction of the switch dependant settings. I
> copied this approach form RZ/G3S.
>  
> 
>  .../renesas/r9a06g032-rzn1d400-db-switches.h  | 22 ++++++++++++++
>  .../dts/renesas/r9a06g032-rzn1d400-db.dts     | 30 +++++++++++++++++++
>  .../dts/renesas/r9a06g032-rzn1d400-eb.dts     | 19 ++++++++++++
>  3 files changed, 71 insertions(+)
>  create mode 100644 arch/arm/boot/dts/renesas/r9a06g032-rzn1d400-db-switches.h
> 
> diff --git a/arch/arm/boot/dts/renesas/r9a06g032-rzn1d400-db-switches.h b/arch/arm/boot/dts/renesas/r9a06g032-rzn1d400-db-switches.h
> new file mode 100644
> index 000000000000..4560d16e7c60
> --- /dev/null
> +++ b/arch/arm/boot/dts/renesas/r9a06g032-rzn1d400-db-switches.h
> @@ -0,0 +1,22 @@
> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
> +/*
> + * On-board switches for the Renesas RZ/N1D demo board (DB) and extension
> + * board (EB)
> + *
> + * Copyright (C) 2025 Renesas Electronics Corp.
> + */
> +
> +#ifndef __N1D_DB_EB_SWITCHES_H__
> +#define __N1D_DB_EB_SWITCHES_H__
> +
> +#define SW_OFF         0
> +#define SW_ON          1
> +
> +/*
> + * SW_2-2:
> + *     SW_OFF - enable PMOD1-3+LEDs on the extension board
> + *     SW_ON  - enable CAT/S3 (default)
> + */
> +#define SW_2_2 SW_ON
> +
> +#endif
> diff --git a/arch/arm/boot/dts/renesas/r9a06g032-rzn1d400-db.dts b/arch/arm/boot/dts/renesas/r9a06g032-rzn1d400-db.dts
> index 3258b2e27434..849b5ad9c79d 100644
> --- a/arch/arm/boot/dts/renesas/r9a06g032-rzn1d400-db.dts
> +++ b/arch/arm/boot/dts/renesas/r9a06g032-rzn1d400-db.dts
> @@ -15,6 +15,7 @@
>  #include <dt-bindings/pinctrl/rzn1-pinctrl.h>
>  
>  #include "r9a06g032.dtsi"
> +#include "r9a06g032-rzn1d400-db-switches.h"
>  
>  / {
>  	model = "RZN1D-DB Board";
> @@ -185,6 +186,14 @@ fixed-link {
>  	};
>  };
>  
> +#if SW2_2 == SW_OFF

The "rule" for DT headers is #defines for numbers only.

If the switches are s/w readable, then I'd say firmware should read them 
and enable/disable the LEDs as appropriate. If not, then maybe the DT 
should have a property reflecting the switch state and firmware uses 
that to enable/disable.

Rob