All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Andrey Albershteyn <aalbersh@redhat.com>,
	"A. Wilcox" <AWilcox@wilcox-tech.com>,
	linux-xfs@vger.kernel.org
Subject: Re: [PATCH v2] xfs_scrub: fix strerror_r usage yet again
Date: Tue, 23 Sep 2025 17:53:53 -0700	[thread overview]
Message-ID: <20250924005353.GW8096@frogsfrogsfrogs> (raw)
In-Reply-To: <aNGA3WV3vO5PXhOH@infradead.org>

On Mon, Sep 22, 2025 at 10:01:17AM -0700, Christoph Hellwig wrote:
> The autoconf maigc looks good (as good as autoconf can look anyway),
> but why is this code using strerror_r to start with?  AFAIK on Linux
> strerror is using thread local storage since the damn of time, so
> just doing this as:
> 
> 	fprintf(stream, _("%s."), strerror(error));
> 
> should be perfectly fine, while also simpler and more portable.

But there's no guarantee that the implementation does this, is there?
The manpage doesn't say anything like that.

--D

  reply	other threads:[~2025-09-24  0:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-19 16:14 [PATCH v2] xfs_scrub: fix strerror_r usage yet again Darrick J. Wong
2025-09-20 11:21 ` A. Wilcox
2025-09-22 17:01 ` Christoph Hellwig
2025-09-24  0:53   ` Darrick J. Wong [this message]
2025-09-25  7:23     ` Christoph Hellwig
2025-09-25 20:04       ` Darrick J. Wong
2025-09-25 20:58         ` Holger Hoffstätte
2025-09-26 16:27           ` Darrick J. Wong
2025-10-03 10:07             ` Andrey Albershteyn
2025-09-29  6:34         ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250924005353.GW8096@frogsfrogsfrogs \
    --to=djwong@kernel.org \
    --cc=AWilcox@wilcox-tech.com \
    --cc=aalbersh@redhat.com \
    --cc=hch@infradead.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.