All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Bibo Mao <maobibo@loongson.cn>
Cc: Huacai Chen <chenhuacai@kernel.org>,
	Song Gao <gaosong@loongson.cn>,
	Jiaxun Yang <jiaxun.yang@flygoat.com>,
	WANG Xuerui <git@xen0n.name>,
	qemu-devel@nongnu.org
Subject: Re: [PATCH 3/3] tests/data/acpi/loongarch64: Update expected DSDT.*
Date: Wed, 24 Sep 2025 05:04:02 -0400	[thread overview]
Message-ID: <20250924050304-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <08a40419-c56e-4944-2a8e-045f0512fe04@loongson.cn>

On Wed, Sep 24, 2025 at 03:26:13PM +0800, Bibo Mao wrote:
> Add Michael
> 
> On 2025/9/23 下午10:35, Huacai Chen wrote:
> > DSDT diffs from "iasl -d":
> > 
> > @@ -11,7 +11,7 @@
> >    *     Signature        "DSDT"
> >    *     Length           0x000011FB (4603)
> >    *     Revision         0x01 **** 32-bit table (V1), no 64-bit math support
> > - *     Checksum         0x5D
> > + *     Checksum         0x5B
> >    *     OEM ID           "BOCHS "
> >    *     OEM Table ID     "BXPC    "
> >    *     OEM Revision     0x00000001 (1)
> > @@ -1426,11 +1426,11 @@
> >               Name (_CRS, ResourceTemplate ()  // _CRS: Current Resource Settings
> >               {
> >                   Memory32Fixed (ReadWrite,
> > -                    0x100E001F,         // Address Base
> > +                    0x100E0020,         // Address Base
> >                       0x0000000C,         // Address Length
> >                       )
> >               })
> > -            OperationRegion (PRST, SystemMemory, 0x100E001F, 0x0C)
> > +            OperationRegion (PRST, SystemMemory, 0x100E0020, 0x0C)
> >               Field (PRST, ByteAcc, NoLock, WriteAsZeros)
> >               {
> >                   Offset (0x04),
> > 
> > Signed-off-by: Huacai Chen <chenhuacai@kernel.org>


this does what the patch says it does

Acked-by: Michael S. Tsirkin <mst@redhat.com>

up to maintainers to figure out if it's TRT

> > ---
> >   tests/data/acpi/loongarch64/virt/DSDT         | Bin 4603 -> 4603 bytes
> >   tests/data/acpi/loongarch64/virt/DSDT.memhp   | Bin 5824 -> 5824 bytes
> >   tests/data/acpi/loongarch64/virt/DSDT.numamem | Bin 4609 -> 4609 bytes
> >   .../data/acpi/loongarch64/virt/DSDT.topology  | Bin 4905 -> 4905 bytes
> >   tests/qtest/bios-tables-test-allowed-diff.h   |   4 ----
> >   5 files changed, 4 deletions(-)
> > 
> > diff --git a/tests/data/acpi/loongarch64/virt/DSDT b/tests/data/acpi/loongarch64/virt/DSDT
> > index b31841aec6ed296f10ea1695a67ead38f45424d5..55aa34f988d6ef69293e91c5fe45bee0a02bc5f1 100644
> > GIT binary patch
> > delta 44
> > zcmeyZ{9BpJCD<k8w;%%pWAsL@BfP>2415AS3=9mF4ABh%LBSymJPMm1@=CD)02#3h
> > APXGV_
> > 
> > delta 44
> > zcmeyZ{9BpJCD<k8w;%%pW9&w*BfP@$415AS3=9mF4ABh%LBSymJo1|#@=CD)02$8<
> > APXGV_
> > 
> > diff --git a/tests/data/acpi/loongarch64/virt/DSDT.memhp b/tests/data/acpi/loongarch64/virt/DSDT.memhp
> > index e291200fc91caa3d93dcd6ec4736f7340f5e3f65..c0955eb60448cc5f4d38d410abc260ae54ea2e9a 100644
> > GIT binary patch
> > delta 44
> > zcmX@0dq9`VCD<k8fEWV<W5PzRW+7n(20j5E1_p*ohUkWXpx_V&9)-;dgcMi+`vnS0
> > 
> > delta 44
> > zcmX@0dq9`VCD<k8fEWV<W70;hW+7pD20j5E1_p*ohUkWXpx_V&9{J4+gcMi+`y&cU
> > 
> > diff --git a/tests/data/acpi/loongarch64/virt/DSDT.numamem b/tests/data/acpi/loongarch64/virt/DSDT.numamem
> > index 07923ac39584c5a5e73c9556d251814ce10de6cc..61e47e7252155dcf9c76879c4f60f4b3eef63f86 100644
> > GIT binary patch
> > delta 44
> > zcmZovX;k5I33dr#6k=dte72G62(PdL1D^m70|P@PLv%wxP;dwXkHY4Myb3G;-$V)Z
> > 
> > delta 44
> > zcmZovX;k5I33dr#6k=dte6f-12(Pd_1D^m70|P@PLv%wxP;dwXkNoC`yb3G;-(m^%
> > 
> > diff --git a/tests/data/acpi/loongarch64/virt/DSDT.topology b/tests/data/acpi/loongarch64/virt/DSDT.topology
> > index 6dfbb495f88b74b87849b58473e46717bc588a56..b2afebc938ce45d798c8aa5f45a463f1617e257e 100644
> > GIT binary patch
> > delta 44
> > zcmZ3fwo;ADCD<iIQ<#B)@!UqPBfP>2415AS3=9mF4ABh%LBSymJPMm1@_MiW0PuGT
> > Ag8%>k
> > 
> > delta 44
> > zcmZ3fwo;ADCD<iIQ<#B)@xn%~BfP@$415AS3=9mF4ABh%LBSymJo1|#@_MiW0PvLx
> > Ag8%>k
> > 
> > diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
> > index 2ed837faee..dfb8523c8b 100644
> > --- a/tests/qtest/bios-tables-test-allowed-diff.h
> > +++ b/tests/qtest/bios-tables-test-allowed-diff.h
> > @@ -1,5 +1 @@
> >   /* List of comma-separated changed AML files to ignore */
> > -"tests/data/acpi/loongarch64/virt/DSDT",
> > -"tests/data/acpi/loongarch64/virt/DSDT.memhp",
> > -"tests/data/acpi/loongarch64/virt/DSDT.numamem",
> > -"tests/data/acpi/loongarch64/virt/DSDT.topology",
> > 



  reply	other threads:[~2025-09-24  9:05 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-23 14:35 [PATCH 0/3] LoongArch: Align VIRT_GED_CPUHP_ADDR Huacai Chen
2025-09-23 14:35 ` [PATCH 1/3] bios-tables-test-allowed-diff.h: Allow LoongArch DSDT.* Huacai Chen
2025-09-28  3:15   ` Bibo Mao
2025-09-23 14:35 ` [PATCH 2/3] hw/loongarch/virt: Align VIRT_GED_CPUHP_ADDR to 4 bytes Huacai Chen
2025-09-24  7:20   ` Bibo Mao
2025-09-23 14:35 ` [PATCH 3/3] tests/data/acpi/loongarch64: Update expected DSDT.* Huacai Chen
2025-09-24  7:26   ` Bibo Mao
2025-09-24  9:04     ` Michael S. Tsirkin [this message]
2025-10-09  7:31 ` [PATCH 0/3] LoongArch: Align VIRT_GED_CPUHP_ADDR gaosong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250924050304-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=chenhuacai@kernel.org \
    --cc=gaosong@loongson.cn \
    --cc=git@xen0n.name \
    --cc=jiaxun.yang@flygoat.com \
    --cc=maobibo@loongson.cn \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.