Re: [PATCH v1 1/7] regulator: dt-bindings: add documentation for s2mps16-pmic regulators

[Rob Herring <robh@kernel.org>]

On Sun, Sep 14, 2025 at 03:42:21PM +0300, Ivaylo Ivanov wrote:
> The S2MPS16 is a PMIC found in exynos8890 devices, which controls voltage
> regulators - 38 LDOs, of which 11 are used for CP, and 11 BUCKs, of which
> 1 is used for CP. Provide documentation for devicetree definitions,
> regulator naming patterns, etc.
> 
> Signed-off-by: Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com>
> ---
>  .../bindings/regulator/samsung,s2mps16.yaml   | 50 +++++++++++++++++++
>  1 file changed, 50 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/regulator/samsung,s2mps16.yaml
> 
> diff --git a/Documentation/devicetree/bindings/regulator/samsung,s2mps16.yaml b/Documentation/devicetree/bindings/regulator/samsung,s2mps16.yaml
> new file mode 100644
> index 000000000..ede87d3b9
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/samsung,s2mps16.yaml
> @@ -0,0 +1,50 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/regulator/samsung,s2mps16.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Samsung S2MPS16 Power Management IC regulators
> +
> +maintainers:
> +  - Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com>
> +
> +description: |
> +  This is a part of device tree bindings for S2M and S5M family of Power
> +  Management IC (PMIC).
> +
> +  The S2MPS16 provides buck and LDO regulators.
> +
> +  See also Documentation/devicetree/bindings/mfd/samsung,s2mps11.yaml for
> +  additional information and example.
> +
> +patternProperties:
> +  # 27 LDOs
> +  "^ldo([1-9]|1[0-3]|2[5-9]|3[0-8])$":
> +    type: object
> +    $ref: regulator.yaml#
> +    unevaluatedProperties: false
> +    description:

You need '>' modifier to preserve paragraphs.

> +      Properties for single LDO regulator.
> +
> +      LDOs 14-24 are used for CP, and they're left unimplemented due to lack
> +      of documentation on them.

What does unimplemented mean? In some driver? If so, that's specific to 
a driver and not relevant to the binding.

> +
> +    required:
> +      - regulator-name
> +
> +  # 10 bucks
> +  "^buck([1-9]|1[0-1])$":
> +    type: object
> +    $ref: regulator.yaml#
> +    unevaluatedProperties: false
> +    description:
> +      Properties for single BUCK regulator.
> +
> +      BUCK 10 is used for CP, and it's left unimplemented due to lack of
> +      documentation on it.
> +
> +    required:
> +      - regulator-name
> +
> +additionalProperties: false
> -- 
> 2.43.0
>