From: Simon Horman <horms@kernel.org>
To: Tariq Toukan <tariqt@nvidia.com>
Cc: Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Saeed Mahameed <saeedm@nvidia.com>,
Leon Romanovsky <leon@kernel.org>, Mark Bloch <mbloch@nvidia.com>,
netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
linux-kernel@vger.kernel.org, Gal Pressman <gal@nvidia.com>,
Moshe Shemesh <moshe@nvidia.com>,
Vlad Dogaru <vdogaru@nvidia.com>,
Yevgeny Kliteynik <kliteyn@nvidia.com>
Subject: Re: [PATCH net-next 1/7] net/mlx5: HWS, Generalize complex matchers
Date: Wed, 24 Sep 2025 17:17:27 +0100 [thread overview]
Message-ID: <20250924161727.GM836419@horms.kernel.org> (raw)
In-Reply-To: <1758531671-819655-2-git-send-email-tariqt@nvidia.com>
On Mon, Sep 22, 2025 at 12:01:05PM +0300, Tariq Toukan wrote:
> From: Vlad Dogaru <vdogaru@nvidia.com>
...
> +static int hws_complex_subrule_create(struct mlx5hws_bwc_matcher *cmatcher,
> + struct mlx5hws_bwc_rule *subrule,
> + u32 *match_params, u32 flow_source,
> + int bwc_queue_idx, int subm_idx,
> + struct mlx5hws_rule_action *actions,
> + u32 *chain_id)
> {
...
> + ret = mlx5hws_bwc_rule_create_simple(subrule, match_params, actions,
> + flow_source, bwc_queue_idx);
> + if (ret) {
> + goto put_subrule_data;
> + goto unlock;
Hi Tariq and Vlad,
I guess it's a simple editing artifact.
But it seems that the line above is dead code.
Flagged by Smatch.
> }
...
next prev parent reply other threads:[~2025-09-24 16:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-22 9:01 [PATCH net-next 0/7] net/mlx5: misc changes 2025-09-22 Tariq Toukan
2025-09-22 9:01 ` [PATCH net-next 1/7] net/mlx5: HWS, Generalize complex matchers Tariq Toukan
2025-09-24 16:17 ` Simon Horman [this message]
2025-09-24 18:07 ` Vlad Dogaru
2025-09-22 9:01 ` [PATCH net-next 2/7] net/mlx5e: Prevent entering switchdev mode with inconsistent netns Tariq Toukan
2025-09-22 9:01 ` [PATCH net-next 3/7] net/mlx5: Improve QoS error messages with actual depth values Tariq Toukan
2025-09-23 0:06 ` Jakub Kicinski
2025-09-23 1:58 ` kernel test robot
2025-09-22 9:01 ` [PATCH net-next 4/7] net/mlx5e: Remove unused mdev param from RSS indir init Tariq Toukan
2025-09-22 9:01 ` [PATCH net-next 5/7] net/mlx5e: Introduce mlx5e_rss_init_params Tariq Toukan
2025-09-22 9:01 ` [PATCH net-next 6/7] net/mlx5e: Introduce mlx5e_rss_params for RSS configuration Tariq Toukan
2025-09-22 9:01 ` [PATCH net-next 7/7] net/mlx5e: Use extack in set rxfh callback Tariq Toukan
2025-09-23 4:06 ` kernel test robot
2025-09-24 16:21 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250924161727.GM836419@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=kliteyn@nvidia.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mbloch@nvidia.com \
--cc=moshe@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
--cc=vdogaru@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.