From: Jason Gunthorpe <jgg@nvidia.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: "Alex Williamson" <alex.williamson@redhat.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Christian König" <christian.koenig@amd.com>,
dri-devel@lists.freedesktop.org, iommu@lists.linux.dev,
"Jens Axboe" <axboe@kernel.dk>, "Joerg Roedel" <joro@8bytes.org>,
kvm@vger.kernel.org, linaro-mm-sig@lists.linaro.org,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org, linux-mm@kvack.org,
linux-pci@vger.kernel.org,
"Logan Gunthorpe" <logang@deltatee.com>,
"Marek Szyprowski" <m.szyprowski@samsung.com>,
"Robin Murphy" <robin.murphy@arm.com>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
"Vivek Kasireddy" <vivek.kasireddy@intel.com>,
"Will Deacon" <will@kernel.org>
Subject: Re: [PATCH v2 03/10] PCI/P2PDMA: Refactor to separate core P2P functionality from memory allocation
Date: Thu, 25 Sep 2025 08:53:08 -0300 [thread overview]
Message-ID: <20250925115308.GT2617119@nvidia.com> (raw)
In-Reply-To: <20250925070314.GA12165@unreal>
On Thu, Sep 25, 2025 at 10:03:14AM +0300, Leon Romanovsky wrote:
> > It would at least make sense to me then to store the provider on the
> > vfio_pci_dma_buf object at the time of the get feature call rather than
> > vfio_pci_core_init_dev() though. That would eliminate patch 08/ and
> > the inline #ifdefs.
>
> I'll change it now. If "enable" function goes to be "get" function, we
> won't need to store anything in vfio_pci_dma_buf too. At the end, we
> have exactly two lines "provider = priv->vdev->provider[priv->bar];",
> which can easily be changed to be "provider = pcim_p2pdma_provider(priv->vdev->pdev, priv->bar)"
Not without some kind of locking change. I'd keep the
priv->vdev->provider[priv->bar] because setup during probe doesn't
need special locking.
Jason
next prev parent reply other threads:[~2025-09-25 11:53 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-11 11:33 [PATCH v2 00/10] vfio/pci: Allow MMIO regions to be exported through dma-buf Leon Romanovsky
2025-09-11 11:33 ` [PATCH v2 01/10] PCI/P2PDMA: Separate the mmap() support from the core logic Leon Romanovsky
2025-09-11 11:33 ` [PATCH v2 02/10] PCI/P2PDMA: Simplify bus address mapping API Leon Romanovsky
2025-09-11 11:33 ` [PATCH v2 03/10] PCI/P2PDMA: Refactor to separate core P2P functionality from memory allocation Leon Romanovsky
2025-09-22 21:00 ` Alex Williamson
2025-09-23 15:04 ` Jason Gunthorpe
2025-09-23 17:30 ` Alex Williamson
2025-09-23 17:43 ` Jason Gunthorpe
2025-09-23 18:09 ` Alex Williamson
2025-09-25 7:03 ` Leon Romanovsky
2025-09-25 11:53 ` Jason Gunthorpe [this message]
2025-09-25 22:31 ` Alex Williamson
2025-09-25 23:02 ` Jason Gunthorpe
2025-09-26 14:13 ` Alex Williamson
2025-09-28 8:15 ` Leon Romanovsky
2025-09-23 17:12 ` Leon Romanovsky
2025-09-23 20:07 ` Alex Williamson
2025-09-11 11:33 ` [PATCH v2 04/10] PCI/P2PDMA: Export pci_p2pdma_map_type() function Leon Romanovsky
2025-09-11 11:33 ` [PATCH v2 05/10] types: move phys_vec definition to common header Leon Romanovsky
2025-09-11 11:33 ` [PATCH v2 06/10] vfio: Export vfio device get and put registration helpers Leon Romanovsky
2025-09-11 11:33 ` [PATCH v2 07/10] vfio/pci: Add dma-buf export config for MMIO regions Leon Romanovsky
2025-09-11 11:33 ` [PATCH v2 08/10] vfio/pci: Enable peer-to-peer DMA transactions by default Leon Romanovsky
2025-09-11 11:33 ` [PATCH v2 09/10] vfio/pci: Share the core device pointer while invoking feature functions Leon Romanovsky
2025-09-11 11:33 ` [PATCH v2 10/10] vfio/pci: Add dma-buf export support for MMIO regions Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250925115308.GT2617119@nvidia.com \
--to=jgg@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=alex.williamson@redhat.com \
--cc=axboe@kernel.dk \
--cc=bhelgaas@google.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=leon@kernel.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-pci@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=m.szyprowski@samsung.com \
--cc=robin.murphy@arm.com \
--cc=sumit.semwal@linaro.org \
--cc=vivek.kasireddy@intel.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.