From: Jakub Kicinski <kuba@kernel.org>
To: Petr Machata <petrm@nvidia.com>
Cc: Daniel Zahka <daniel.zahka@gmail.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Shuah Khan <shuah@kernel.org>,
Willem de Bruijn <willemb@google.com>,
Breno Leitao <leitao@debian.org>,
Yuyang Huang <yuyanghuang@google.com>,
Xiao Liang <shaw.leon@gmail.com>,
Carolina Jubran <cjubran@nvidia.com>,
Donald Hunter <donald.hunter@gmail.com>, <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 2/9] selftests: net: add skip all feature to ksft_run()
Date: Thu, 25 Sep 2025 19:18:21 -0700 [thread overview]
Message-ID: <20250925191821.7adfbdb4@kernel.org> (raw)
In-Reply-To: <87jz1mwksz.fsf@nvidia.com>
On Thu, 25 Sep 2025 18:09:33 +0200 Petr Machata wrote:
> > + if skip_all:
> > + raise KsftSkipEx()
> > case(*args)
> > except KsftSkipEx as e:
> > comment = "SKIP " + str(e)
>
> Personally I'm not very fond of this. Calling a run helper just to have
> it skip all tests... eh, wouldn't it make more sense to just not call
> the function at all then? If all tests have PSP as prereq, just have the
> test say so and bail out early?
Yes, good call. To be clear this was my bad idea, I think I wrote this
before the ksft took shape upstream. My tree says:
Date: Tue Apr 16 12:02:59 2024 -0700
on the patch from which this was factored out. So let's chalk this
lapse of reason to experimentation :)
next prev parent reply other threads:[~2025-09-26 2:18 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-24 19:49 [PATCH net-next 0/9] psp: add a kselftest suite and netdevsim implementation Daniel Zahka
2025-09-24 19:49 ` [PATCH net-next 1/9] netdevsim: a basic test PSP implementation Daniel Zahka
2025-09-25 0:12 ` Jakub Kicinski
2025-09-25 6:48 ` kernel test robot
2025-09-26 15:30 ` Simon Horman
2025-09-26 15:35 ` Simon Horman
2025-09-24 19:49 ` [PATCH net-next 2/9] selftests: net: add skip all feature to ksft_run() Daniel Zahka
2025-09-25 16:09 ` Petr Machata
2025-09-25 17:04 ` Daniel Zahka
2025-09-26 2:18 ` Jakub Kicinski [this message]
2025-09-24 19:49 ` [PATCH net-next 3/9] selftests: drv-net: base device access API test Daniel Zahka
2025-09-25 0:13 ` Jakub Kicinski
2025-09-24 19:49 ` [PATCH net-next 4/9] selftests: drv-net: add PSP responder Daniel Zahka
2025-09-24 19:49 ` [PATCH net-next 5/9] selftests: drv-net: psp: add basic data transfer and key rotation tests Daniel Zahka
2025-09-26 9:15 ` Petr Machata
2025-09-24 19:49 ` [PATCH net-next 6/9] selftests: drv-net: psp: add association tests Daniel Zahka
2025-09-24 19:49 ` [PATCH net-next 7/9] selftests: drv-net: psp: add connection breaking tests Daniel Zahka
2025-09-24 19:49 ` [PATCH net-next 8/9] selftests: drv-net: psp: add test for auto-adjusting TCP MSS Daniel Zahka
2025-09-24 19:49 ` [PATCH net-next 9/9] selftests: drv-net: psp: add tests for destroying devices Daniel Zahka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250925191821.7adfbdb4@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=cjubran@nvidia.com \
--cc=daniel.zahka@gmail.com \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=leitao@debian.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=shaw.leon@gmail.com \
--cc=shuah@kernel.org \
--cc=willemb@google.com \
--cc=yuyanghuang@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.