From: Nathan Chancellor <nathan@kernel.org>
To: Jeff Layton <jlayton@kernel.org>
Cc: Chuck Lever <chuck.lever@oracle.com>, NeilBrown <neil@brown.name>,
Olga Kornievskaia <okorniev@redhat.com>,
Dai Ngo <Dai.Ngo@oracle.com>, Tom Talpey <tom@talpey.com>,
Simon Horman <horms@kernel.org>,
linux-nfs@vger.kernel.org, patches@lists.linux.dev,
Anna Schumaker <anna.schumaker@oracle.com>
Subject: Re: [PATCH] nfsd: Move strlen declaration in nfsd4_encode_components_esc()
Date: Thu, 25 Sep 2025 16:32:33 -0400 [thread overview]
Message-ID: <20250925203233.GB491548@ax162> (raw)
In-Reply-To: <27d0b9176a444dcf87ecd40c17b6ed1865c1b789.camel@kernel.org>
On Thu, Sep 25, 2025 at 12:52:10PM -0400, Jeff Layton wrote:
> On Thu, 2025-09-25 at 09:43 -0400, Chuck Lever wrote:
> > Would anyone be heartbroken if this patch removed the dprintk call site?
Yeah, I had figured this print may be low value and worth removing as a
fix.
> > I think renaming the strlen variable to a name with a lower collision
> > risk would be sensible as well.
> >
>
> Fine with me on both counts. No point in overloading a well known
> function name here.
Agreed. Should I send a patch or does someone else want to?
Cheers,
Nathan
next prev parent reply other threads:[~2025-09-25 20:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-25 12:14 [PATCH] nfsd: Move strlen declaration in nfsd4_encode_components_esc() Nathan Chancellor
2025-09-25 13:43 ` Chuck Lever
2025-09-25 16:52 ` Jeff Layton
2025-09-25 20:32 ` Nathan Chancellor [this message]
2025-09-26 13:13 ` Chuck Lever
2025-09-28 19:22 ` Nathan Chancellor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250925203233.GB491548@ax162 \
--to=nathan@kernel.org \
--cc=Dai.Ngo@oracle.com \
--cc=anna.schumaker@oracle.com \
--cc=chuck.lever@oracle.com \
--cc=horms@kernel.org \
--cc=jlayton@kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neil@brown.name \
--cc=okorniev@redhat.com \
--cc=patches@lists.linux.dev \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.