From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: Daniel Jurgens <danielj@nvidia.com>,
netdev@vger.kernel.org, alex.williamson@redhat.com,
pabeni@redhat.com, virtualization@lists.linux.dev,
parav@nvidia.com, shshitrit@nvidia.com, yohadt@nvidia.com,
xuanzhuo@linux.alibaba.com, eperezma@redhat.com,
shameerali.kolothum.thodi@huawei.com, jgg@ziepe.ca,
kevin.tian@intel.com, kuba@kernel.org, andrew+netdev@lunn.ch,
edumazet@google.com, Yishai Hadas <yishaih@nvidia.com>
Subject: Re: [PATCH net-next v3 01/11] virtio-pci: Expose generic device capability operations
Date: Fri, 26 Sep 2025 10:26:37 -0400 [thread overview]
Message-ID: <20250926023237-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <CACGkMEuWRUANBCkeE5r+7+wob3nr-Mrnce_kLRHbpeF0OT_45Q@mail.gmail.com>
On Fri, Sep 26, 2025 at 12:55:11PM +0800, Jason Wang wrote:
> > > Looking at this, it's nothing admin virtqueue specific, I wonder why
> > > it is not part of virtio_config_ops.
> > >
> > > Thanks
> >
> > cap things are admin commands. But what I do not get is why they
> > need to be callbacks.
> >
> > The only thing about admin commands that is pci specific is finding
> > the admin vq.
>
> I think we had a discussion to decide to separate admin commands from
> the admin vq.
>
> Thanks
If what you are saying is that core should expose APIs to
submit admin commands, not to access admin vq, I think I agree.
--
MST
next prev parent reply other threads:[~2025-09-26 14:26 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-23 14:19 [PATCH net-next v3 00/11] virtio_net: Add ethtool flow rules support Daniel Jurgens
2025-09-23 14:19 ` [PATCH net-next v3 01/11] virtio-pci: Expose generic device capability operations Daniel Jurgens
2025-09-24 1:16 ` Jason Wang
2025-09-24 6:22 ` Michael S. Tsirkin
2025-09-24 19:02 ` Dan Jurgens
2025-09-25 6:16 ` Michael S. Tsirkin
2025-09-25 9:51 ` Parav Pandit
2025-09-25 10:35 ` Michael S. Tsirkin
2025-09-25 10:45 ` Parav Pandit
2025-09-25 11:49 ` Michael S. Tsirkin
2025-09-25 12:09 ` Parav Pandit
2025-09-25 13:08 ` Michael S. Tsirkin
2025-09-25 16:53 ` Dan Jurgens
2025-09-25 16:55 ` Michael S. Tsirkin
2025-09-26 4:55 ` Jason Wang
2025-09-26 14:26 ` Michael S. Tsirkin [this message]
2025-09-26 15:08 ` Dan Jurgens
2025-09-24 6:16 ` Michael S. Tsirkin
2025-09-23 14:19 ` [PATCH net-next v3 02/11] virtio-pci: Expose object create and destroy API Daniel Jurgens
2025-09-23 14:19 ` [PATCH net-next v3 03/11] virtio_net: Create virtio_net directory Daniel Jurgens
2025-09-25 3:56 ` Xuan Zhuo
2025-09-25 6:13 ` Michael S. Tsirkin
2025-09-25 15:48 ` Dan Jurgens
2025-09-25 20:10 ` Michael S. Tsirkin
2025-09-25 21:17 ` Michael S. Tsirkin
2025-09-23 14:19 ` [PATCH net-next v3 04/11] virtio_net: Query and set flow filter caps Daniel Jurgens
2025-09-25 21:01 ` Michael S. Tsirkin
2025-09-26 2:12 ` Dan Jurgens
2025-09-27 9:02 ` Michael S. Tsirkin
2025-09-25 21:16 ` Michael S. Tsirkin
2025-09-26 4:54 ` Dan Jurgens
2025-09-26 16:01 ` Simon Horman
2025-09-26 18:08 ` Dan Jurgens
2025-09-26 20:45 ` Jakub Kicinski
2025-09-23 14:19 ` [PATCH net-next v3 05/11] virtio_net: Create a FF group for ethtool steering Daniel Jurgens
2025-09-25 21:13 ` Michael S. Tsirkin
2025-09-23 14:19 ` [PATCH net-next v3 06/11] virtio_net: Implement layer 2 ethtool flow rules Daniel Jurgens
2025-09-25 20:58 ` Michael S. Tsirkin
2025-09-27 4:45 ` Dan Jurgens
2025-09-25 21:10 ` Michael S. Tsirkin
2025-09-27 5:02 ` Dan Jurgens
2025-09-26 20:48 ` Jakub Kicinski
2025-09-26 21:04 ` Dan Jurgens
2025-09-23 14:19 ` [PATCH net-next v3 07/11] virtio_net: Use existing classifier if possible Daniel Jurgens
2025-09-25 20:53 ` Michael S. Tsirkin
2025-09-23 14:19 ` [PATCH net-next v3 08/11] virtio_net: Implement IPv4 ethtool flow rules Daniel Jurgens
2025-09-25 20:53 ` Michael S. Tsirkin
2025-09-25 21:13 ` Dan Jurgens
2025-09-25 21:20 ` Michael S. Tsirkin
2025-10-01 14:15 ` Dan Jurgens
2025-09-23 14:19 ` [PATCH net-next v3 09/11] virtio_net: Add support for IPv6 ethtool steering Daniel Jurgens
2025-09-25 20:47 ` Michael S. Tsirkin
2025-09-23 14:19 ` [PATCH net-next v3 10/11] virtio_net: Add support for TCP and UDP ethtool rules Daniel Jurgens
2025-09-23 14:19 ` [PATCH net-next v3 11/11] virtio_net: Add get ethtool flow rules ops Daniel Jurgens
2025-09-25 20:44 ` Michael S. Tsirkin
2025-09-28 4:39 ` Dan Jurgens
2025-09-28 6:19 ` Michael S. Tsirkin
2025-09-25 21:19 ` [PATCH net-next v3 00/11] virtio_net: Add ethtool flow rules support Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250926023237-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=andrew+netdev@lunn.ch \
--cc=danielj@nvidia.com \
--cc=edumazet@google.com \
--cc=eperezma@redhat.com \
--cc=jasowang@redhat.com \
--cc=jgg@ziepe.ca \
--cc=kevin.tian@intel.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=parav@nvidia.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=shshitrit@nvidia.com \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
--cc=yishaih@nvidia.com \
--cc=yohadt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.