From: David Sterba <dsterba@suse.cz>
To: Nathan Chancellor <nathan@kernel.org>
Cc: Chris Mason <clm@fb.com>, David Sterba <dsterba@suse.com>,
Qu Wenruo <wqu@suse.com>,
linux-btrfs@vger.kernel.org, patches@lists.linux.dev
Subject: Re: [PATCH] btrfs: Fix PAGE_SIZE format specifier in open_ctree()
Date: Fri, 26 Sep 2025 08:54:01 +0200 [thread overview]
Message-ID: <20250926065401.GR5333@suse.cz> (raw)
In-Reply-To: <20250925-btrfs-fix-page_size-format-specifier-v1-1-8f98d300a909@kernel.org>
On Thu, Sep 25, 2025 at 07:03:04PM -0400, Nathan Chancellor wrote:
> There is an instance of -Wformat when targeting 32-bit architectures due
> to using a 'size_t' specifier (which is 'unsigned int' for 32-bit
> platforms) to print PAGE_SIZE:
>
> In file included from fs/btrfs/compression.h:17,
> from fs/btrfs/extent_io.h:15,
> from fs/btrfs/locking.h:13,
> from fs/btrfs/ctree.h:19,
> from fs/btrfs/disk-io.c:22:
> fs/btrfs/disk-io.c: In function 'open_ctree':
> include/linux/kern_levels.h:5:25: error: format '%zu' expects argument of type 'size_t', but argument 4 has type 'long unsigned int' [-Werror=format=]
> ...
> fs/btrfs/disk-io.c:3398:17: note: in expansion of macro 'btrfs_warn'
> 3398 | btrfs_warn(fs_info,
> | ^~~~~~~~~~
>
> PAGE_SIZE is consistently defined as an 'unsigned long' in
> include/vsdo/page.h so use '%lu' to clear up the warning.
>
> Fixes: 98077f7f2180 ("btrfs: enable experimental bs > ps support")
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Thanks, I'm planning to send it as fixup once the main pull request is
merged, until then it'll be in linux-next.
next prev parent reply other threads:[~2025-09-26 6:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-25 23:03 [PATCH] btrfs: Fix PAGE_SIZE format specifier in open_ctree() Nathan Chancellor
2025-09-25 23:53 ` Qu Wenruo
2025-09-26 6:54 ` David Sterba [this message]
2025-10-01 14:02 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250926065401.GR5333@suse.cz \
--to=dsterba@suse.cz \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=nathan@kernel.org \
--cc=patches@lists.linux.dev \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.