All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@nvidia.com>
To: bernard.metzler@linux.dev
Cc: leon@kernel.org, metze@samba.org, linux-rdma@vger.kernel.org
Subject: Re: [PATCH] RDMA/siw: Always report immediate post SQ errors
Date: Fri, 26 Sep 2025 13:15:31 -0300	[thread overview]
Message-ID: <20250926161531.GA2827732@nvidia.com> (raw)
In-Reply-To: <20250923144536.103825-1-bernard.metzler@linux.dev>

On Tue, Sep 23, 2025 at 04:45:36PM +0200, bernard.metzler@linux.dev wrote:
> From: Bernard Metzler <bernard.metzler@linux.dev>
> 
> In siw_post_send(), any immediate error encountered during
> processing of the work request list must be reported to the
> caller, even if previous work requests in that list were just
> accepted and added to the send queue.
> Not reporting those errors confuses the caller, which would
> wait indefinitely for the failing and potentially subsequently
> aborted work requests completion.
> This fixes a case where immediate errors were overwritten
> by subsequent code in siw_post_send().
> 
> Fixes: 303ae1cdfdf7 ("rdma/siw: application interface")
> Suggested-by: Stefan Metzmacher <metze@samba.org>
> Signed-off-by: Bernard Metzler <bernard.metzler@linux.dev>
> ---
>  drivers/infiniband/sw/siw/siw_verbs.c | 25 ++++++++++++++-----------
>  1 file changed, 14 insertions(+), 11 deletions(-)

Applied to for-next

Thanks,
Jason

      parent reply	other threads:[~2025-09-26 16:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-23 14:45 [PATCH] RDMA/siw: Always report immediate post SQ errors bernard.metzler
2025-09-23 15:44 ` Stefan Metzmacher
2025-09-23 16:08   ` Bernard Metzler
2025-09-26 16:15 ` Jason Gunthorpe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250926161531.GA2827732@nvidia.com \
    --to=jgg@nvidia.com \
    --cc=bernard.metzler@linux.dev \
    --cc=leon@kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=metze@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.