All of lore.kernel.org
 help / color / mirror / Atom feed
From: SeongJae Park <sj@kernel.org>
To: Enze Li <lienze@kylinos.cn>
Cc: SeongJae Park <sj@kernel.org>,
	akpm@linux-foundation.org, damon@lists.linux.dev,
	linux-mm@kvack.org, enze.li@gmx.com
Subject: Re: [RFC PATCH 0/2] DAMON: add priority-based scheme application control
Date: Fri, 26 Sep 2025 10:37:12 -0700	[thread overview]
Message-ID: <20250926173712.53778-1-sj@kernel.org> (raw)
In-Reply-To: <87bjmxvqve.fsf@>

On Fri, 26 Sep 2025 11:23:33 +0800 Enze Li <lienze@kylinos.cn> wrote:

> Hello SJ,
> 
> On Mon, Sep 22 2025 at 06:01:32 AM -0700, SeongJae Park wrote:
> 
> > Hello Enze,
> >
> > On Mon, 22 Sep 2025 18:10:20 +0800 Enze Li <lienze@kylinos.cn> wrote:
> >
> >> This patchset introduces a priority mechanism for DAMON's scheme
> >> application, allowing users to specify the relative importance of
> >> monitored processes.  The changes ensure that higher-priority targets
> >> receive more frequent memory management operations while maintaining
> >> fairness across all monitored processes.
> >
> > Thank you for this patchset.
> >
> > There are features for monitoring target-based DAMOS filtering
> > (DAMOS_FILTER_TYPE_TARGET) and per-scheme applying time interval
> > (apply_interval_us).  Couldn't those be used for your purpose?
> >
> 
> Sorry for the delay.  I've been testing it for the past few days.

No worry, take your time! :)

> 
> The combination of schemes and filters does indeed emulate a
> priority-like mechanism quite effectively.  This is a fantastic feature!
> It's exactly what I needed for managing my workload's priorities.

Thank you for letting me know it works for you!

[...]
> I've been wondering, though -- for users seeking a simpler interface,
> could we allow them to define a basic priority value and let the kernel
> handle the resource distribution automatically?  This would require the
> DAMON system to intelligently translate a user-defined priority value
> into appropriate internal operations based on current system resources.
> WDYT?

I agree the priority based interface could be better and easier to use than the
target filter + apply_interval combination, for some people.  That said, the
user interface for achieving the same goal already exists.  I think adding
another user interface here could be a duplicate that only increases maintenace
burden.  Particularly because we need to support every user interface of the
kernel for long term, the burden may be not that cheap.

And I think the kernel ABI is not necessarily the only single place that can be
modified to help users.  Users are recommended to use DAMON user-space tool
(damo) rather than directly using DAMON sysfs ABI.  So I think we could add
priority based interface as another wrapper of the target filter +
apply_interval combination, on DAMON user-space tool.


Thanks,
SJ

[...]

      reply	other threads:[~2025-09-26 17:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-22 10:10 [RFC PATCH 0/2] DAMON: add priority-based scheme application control Enze Li
2025-09-22 10:10 ` [RFC PATCH 1/2] mm/damon/core: introduce priority concept for DAMON Enze Li
2025-09-22 11:16   ` Gutierrez Asier
2025-09-26  3:57     ` Enze Li
2025-09-22 10:10 ` [RFC PATCH 2/2] mm/damon/sysfs: add priority support for DAMOS targets Enze Li
2025-09-22 13:01 ` [RFC PATCH 0/2] DAMON: add priority-based scheme application control SeongJae Park
2025-09-26  3:23   ` Enze Li
2025-09-26 17:37     ` SeongJae Park [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250926173712.53778-1-sj@kernel.org \
    --to=sj@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=damon@lists.linux.dev \
    --cc=enze.li@gmx.com \
    --cc=lienze@kylinos.cn \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.