All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Luke Howard <lukeh@padl.com>
Cc: oe-kbuild-all@lists.linux.dev
Subject: Re: [RFC net-next 3/5] net: dsa: mv88e6xxx: MQPRIO support
Date: Sat, 27 Sep 2025 23:18:28 +0800	[thread overview]
Message-ID: <202509272325.MTS85ySX-lkp@intel.com> (raw)
In-Reply-To: <20250927070724.734933-4-lukeh@padl.com>

Hi Luke,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build warnings:

[auto build test WARNING on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Luke-Howard/net-dsa-mv88e6xxx-add-num_tx_queues-to-chip-info-structure/20250927-155031
base:   net-next/main
patch link:    https://lore.kernel.org/r/20250927070724.734933-4-lukeh%40padl.com
patch subject: [RFC net-next 3/5] net: dsa: mv88e6xxx: MQPRIO support
config: x86_64-buildonly-randconfig-005-20250927 (https://download.01.org/0day-ci/archive/20250927/202509272325.MTS85ySX-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250927/202509272325.MTS85ySX-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202509272325.MTS85ySX-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/net/dsa/mv88e6xxx/avb.c:120:12: warning: 'mv88e6xxx_avb_set_hilimit' defined but not used [-Wunused-function]
     120 | static int mv88e6xxx_avb_set_hilimit(struct mv88e6xxx_chip *chip, u16 hilimit)
         |            ^~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/net/dsa/mv88e6xxx/avb.c:84:12: warning: 'mv88e6xxx_port_qav_write' defined but not used [-Wunused-function]
      84 | static int mv88e6xxx_port_qav_write(struct mv88e6xxx_chip *chip, int port,
         |            ^~~~~~~~~~~~~~~~~~~~~~~~
   drivers/net/dsa/mv88e6xxx/avb.c:75:12: warning: 'mv88e6xxx_port_qav_read' defined but not used [-Wunused-function]
      75 | static int mv88e6xxx_port_qav_read(struct mv88e6xxx_chip *chip, int port,
         |            ^~~~~~~~~~~~~~~~~~~~~~~
>> drivers/net/dsa/mv88e6xxx/avb.c:20:12: warning: 'mv88e6xxx_port_avb_read' defined but not used [-Wunused-function]
      20 | static int mv88e6xxx_port_avb_read(struct mv88e6xxx_chip *chip, int port,
         |            ^~~~~~~~~~~~~~~~~~~~~~~


vim +/mv88e6xxx_avb_set_hilimit +120 drivers/net/dsa/mv88e6xxx/avb.c

    19	
  > 20	static int mv88e6xxx_port_avb_read(struct mv88e6xxx_chip *chip, int port,
    21					   int addr, u16 *data, int len)
    22	{
    23		if (!chip->info->ops->avb_ops->port_avb_read)
    24			return -EOPNOTSUPP;
    25	
    26		return chip->info->ops->avb_ops->port_avb_read(chip, port, addr,
    27							       data, len);
    28	}
    29	
    30	static int mv88e6xxx_port_avb_write(struct mv88e6xxx_chip *chip, int port,
    31					    int addr, u16 data)
    32	{
    33		if (!chip->info->ops->avb_ops->port_avb_write)
    34			return -EOPNOTSUPP;
    35	
    36		return chip->info->ops->avb_ops->port_avb_write(chip, port, addr, data);
    37	}
    38	
    39	static int mv88e6xxx_avb_read(struct mv88e6xxx_chip *chip, int addr,
    40				      u16 *data, int len)
    41	{
    42		if (!chip->info->ops->avb_ops->avb_read)
    43			return -EOPNOTSUPP;
    44	
    45		return chip->info->ops->avb_ops->avb_read(chip, addr, data, len);
    46	}
    47	
    48	static int mv88e6xxx_avb_write(struct mv88e6xxx_chip *chip, int addr, u16 data)
    49	{
    50		if (!chip->info->ops->avb_ops->avb_write)
    51			return -EOPNOTSUPP;
    52	
    53		return chip->info->ops->avb_ops->avb_write(chip, addr, data);
    54	}
    55	
    56	/* 802.1Qav operation wrappers */
    57	
    58	static int mv88e6xxx_qav_read(struct mv88e6xxx_chip *chip, int addr,
    59				      u16 *data, int len)
    60	{
    61		if (!chip->info->ops->avb_ops->qav_read)
    62			return -EOPNOTSUPP;
    63	
    64		return chip->info->ops->avb_ops->qav_read(chip, addr, data, len);
    65	}
    66	
    67	static int mv88e6xxx_qav_write(struct mv88e6xxx_chip *chip, int addr, u16 data)
    68	{
    69		if (!chip->info->ops->avb_ops->qav_write)
    70			return -EOPNOTSUPP;
    71	
    72		return chip->info->ops->avb_ops->qav_write(chip, addr, data);
    73	}
    74	
    75	static int mv88e6xxx_port_qav_read(struct mv88e6xxx_chip *chip, int port,
    76					   int addr, u16 *data, int len)
    77	{
    78		if (!chip->info->ops->avb_ops->port_qav_read)
    79			return -EOPNOTSUPP;
    80	
    81		return chip->info->ops->avb_ops->port_qav_read(chip, port, addr, data, len);
    82	}
    83	
    84	static int mv88e6xxx_port_qav_write(struct mv88e6xxx_chip *chip, int port,
    85					    int addr, u16 data)
    86	{
    87		if (!chip->info->ops->avb_ops->port_qav_write)
    88			return -EOPNOTSUPP;
    89	
    90		return chip->info->ops->avb_ops->port_qav_write(chip, port, addr, data);
    91	}
    92	
    93	static int mv88e6xxx_tc_enable(struct mv88e6xxx_chip *chip,
    94				       const struct mv88e6xxx_avb_tc_policy *policy)
    95	{
    96		if (!chip->info->ops->tc_ops->tc_enable)
    97			return -EOPNOTSUPP;
    98	
    99		return chip->info->ops->tc_ops->tc_enable(chip, policy);
   100	}
   101	
   102	static int mv88e6xxx_tc_disable(struct mv88e6xxx_chip *chip)
   103	{
   104		if (!chip->info->ops->tc_ops->tc_disable)
   105			return -EOPNOTSUPP;
   106	
   107		return chip->info->ops->tc_ops->tc_disable(chip);
   108	}
   109	
   110	/* MQPRIO helpers */
   111	
   112	/* Set the AVB global policy limit registers. Caller must acquired register
   113	 * lock.
   114	 *
   115	 * @param chip		Marvell switch chip instance
   116	 * @param hilimit	Maximum frame size allowed for AVB Class A frames
   117	 *
   118	 * @return		0 on success, or a negative error value otherwise
   119	 */
 > 120	static int mv88e6xxx_avb_set_hilimit(struct mv88e6xxx_chip *chip, u16 hilimit)
   121	{
   122		u16 data;
   123		int err;
   124	
   125		if (hilimit > MV88E6XXX_AVB_CFG_HI_LIMIT_MASK)
   126			return -EINVAL;
   127	
   128		err = mv88e6xxx_avb_read(chip, MV88E6XXX_AVB_CFG_HI_LIMIT, &data, 1);
   129		if (err)
   130			return err;
   131	
   132		data &= ~(MV88E6XXX_AVB_CFG_HI_LIMIT_MASK);
   133		data |= MV88E6XXX_AVB_CFG_HI_LIMIT_SET(hilimit);
   134	
   135		err = mv88e6xxx_avb_write(chip, MV88E6XXX_AVB_CFG_HI_LIMIT, hilimit);
   136		if (err)
   137			return err;
   138	
   139		return 0;
   140	}
   141	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

  parent reply	other threads:[~2025-09-27 15:18 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-27  7:07 [RFC net-next 0/5] net: dsa: mv88e6xxx: support for 802.1Qav Luke Howard
2025-09-27  7:07 ` [RFC net-next 1/5] net: dsa: mv88e6xxx: add num_tx_queues to chip info structure Luke Howard
2025-09-27  7:07 ` [RFC net-next 2/5] net: dsa: mv88e6xxx: add MV88E6XXX_G1_ATU_CTL_MAC_AVB setter Luke Howard
2025-09-27 14:29   ` Andrew Lunn
2025-09-27  7:07 ` [RFC net-next 3/5] net: dsa: mv88e6xxx: MQPRIO support Luke Howard
2025-09-27 15:12   ` Andrew Lunn
2025-09-27 16:00     ` Luke Howard
2025-09-27 17:36       ` Andrew Lunn
2025-09-27 18:14         ` Luke Howard
2026-05-26  7:05           ` Luke Howard
2025-09-27 15:18   ` kernel test robot [this message]
2025-09-27  7:07 ` [RFC net-next 4/5] net: dsa: mv88e6xxx: CBS support Luke Howard
2025-09-27  7:07 ` [RFC net-next 5/5] dt-bindings: net: dsa: mv88e6xxx: add mv88e6xxx-avb-mode property Luke Howard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202509272325.MTS85ySX-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=lukeh@padl.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.