From: Chuck Lever <cel@kernel.org>
To: Daniel Gomez <da.gomez@kernel.org>
Cc: <kdevops@lists.linux.dev>, Chuck Lever <chuck.lever@oracle.com>
Subject: [RFC PATCH] Makefile: terraform wasn't building the kdevops_nodes file
Date: Sun, 28 Sep 2025 11:53:41 -0400 [thread overview]
Message-ID: <20250928155341.901825-1-cel@kernel.org> (raw)
From: Chuck Lever <chuck.lever@oracle.com>
When "make bringup" runs "terraform plan", it complains that the
kdevops_nodes variable isn't set.
extra_vars.yaml does contain the variable, but I'm guessing that
somehow gen_nodes runs after gen_tfvars now? Not really sure.
Fixes: 5457b742d611 ("Makefile: fix target dependency order")
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index fb7e9b816dbc..c1dd1232c7ff 100644
--- a/Makefile
+++ b/Makefile
@@ -258,7 +258,7 @@ ifneq (,$(KDEVOPS_BRING_UP_DEPS))
include scripts/bringup.Makefile
endif
-$(ANSIBLE_INVENTORY_FILE): .config $(ANSIBLE_CFG_FILE) $(KDEVOPS_HOSTS_TEMPLATE) $(KDEVOPS_EXTRA_VARS)
+$(ANSIBLE_INVENTORY_FILE): .config $(ANSIBLE_CFG_FILE) $(KDEVOPS_HOSTS_TEMPLATE) $(KDEVOPS_NODES) $(KDEVOPS_EXTRA_VARS)
$(Q)ANSIBLE_LOCALHOST_WARNING=False ANSIBLE_INVENTORY_UNPARSED_WARNING=False \
ansible-playbook $(ANSIBLE_VERBOSE) \
$(KDEVOPS_PLAYBOOKS_DIR)/gen_hosts.yml \
--
2.51.0
next reply other threads:[~2025-09-28 15:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-28 15:53 Chuck Lever [this message]
2025-09-28 19:53 ` [RFC PATCH] Makefile: terraform wasn't building the kdevops_nodes file Daniel Gomez
2025-09-28 19:57 ` Chuck Lever
2025-09-28 20:08 ` Daniel Gomez
2025-09-28 20:30 ` Chuck Lever
2025-09-29 19:16 ` Daniel Gomez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250928155341.901825-1-cel@kernel.org \
--to=cel@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=da.gomez@kernel.org \
--cc=kdevops@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.